The debug logging in gud_disconnect() adds zero detail and is
unnecessary, as it only prints the function name.

The same functionality can be achieved by using ftrace, and is
highlighted by checkpatch, stating the same.

This patch removes the debug log in the gud_disconnect() function.

Signed-off-by: Ruben Wauters <rubenru09@aol.com>
---
 drivers/gpu/drm/gud/gud_drv.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/gud/gud_drv.c b/drivers/gpu/drm/gud/gud_drv.c
index 5385a2126e45..b52a12cbba3e 100644
--- a/drivers/gpu/drm/gud/gud_drv.c
+++ b/drivers/gpu/drm/gud/gud_drv.c
@@ -620,8 +620,6 @@ static void gud_disconnect(struct usb_interface *interface)
 	struct gud_device *gdrm = usb_get_intfdata(interface);
 	struct drm_device *drm = &gdrm->drm;
 
-	drm_dbg(drm, "%s:\n", __func__);
-
 	drm_kms_helper_poll_fini(drm);
 	drm_dev_unplug(drm);
 	drm_atomic_helper_shutdown(drm);
-- 
2.49.1

Hi

Am 22.07.25 um 01:22 schrieb Ruben Wauters:

I've been on vacation, hence the delay.

> The debug logging in gud_disconnect() adds zero detail and is
> unnecessary, as it only prints the function name.
>
> The same functionality can be achieved by using ftrace, and is
> highlighted by checkpatch, stating the same.
>
> This patch removes the debug log in the gud_disconnect() function.
>
> Signed-off-by: Ruben Wauters <rubenru09@aol.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

Thanks for the patch. I'll add it to drm-misc-next.

Best regards
Thomas

> ---
>   drivers/gpu/drm/gud/gud_drv.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/gud/gud_drv.c b/drivers/gpu/drm/gud/gud_drv.c
> index 5385a2126e45..b52a12cbba3e 100644
> --- a/drivers/gpu/drm/gud/gud_drv.c
> +++ b/drivers/gpu/drm/gud/gud_drv.c
> @@ -620,8 +620,6 @@ static void gud_disconnect(struct usb_interface *interface)
>   	struct gud_device *gdrm = usb_get_intfdata(interface);
>   	struct drm_device *drm = &gdrm->drm;
>   
> -	drm_dbg(drm, "%s:\n", __func__);
> -
>   	drm_kms_helper_poll_fini(drm);
>   	drm_dev_unplug(drm);
>   	drm_atomic_helper_shutdown(drm);

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)