Add MT8189 encoder compatible string, which will reference SCP device.

Signed-off-by: Kyrie Wu <kyrie.wu@mediatek.com>
---
 .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml      | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
index 7675391d7eb0..faee838d684e 100644
--- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
@@ -25,6 +25,7 @@ properties:
               - mediatek,mt8192-vcodec-enc
               - mediatek,mt8195-vcodec-enc
               - mediatek,mt8196-vcodec-enc
+              - mediatek,mt8189-vcodec-enc
       - items:
           - const: mediatek,mt8186-vcodec-enc
           - const: mediatek,mt8183-vcodec-enc
@@ -97,6 +98,7 @@ allOf:
               - mediatek,mt8188-vcodec-enc
               - mediatek,mt8192-vcodec-enc
               - mediatek,mt8195-vcodec-enc
+              - mediatek,mt8189-vcodec-enc
 
     then:
       required:
-- 
2.46.0

On Mon, Jul 21, 2025 at 06:55:19PM +0800, Kyrie Wu wrote:
> Add MT8189 encoder compatible string, which will reference SCP device.

And the device is not compatible or is different because of what?

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

On Tue, 2025-07-22 at 09:26 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Mon, Jul 21, 2025 at 06:55:19PM +0800, Kyrie Wu wrote:
> > Add MT8189 encoder compatible string, which will reference SCP
> > device.
> 
> And the device is not compatible or is different because of what?
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
> 
Dear Krzysztof,

The reason, adding a new compatible strings for the MT8189 encoder, is
same as for decoder, to use different of_device_id data and to
distinguish the chip name.

Thanks.

Regards,
Kyrie.

On 22/07/2025 10:16, Kyrie Wu (吴晗) wrote:
> On Tue, 2025-07-22 at 09:26 +0200, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> On Mon, Jul 21, 2025 at 06:55:19PM +0800, Kyrie Wu wrote:
>>> Add MT8189 encoder compatible string, which will reference SCP
>>> device.
>>
>> And the device is not compatible or is different because of what?
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> Best regards,
>> Krzysztof
>>
> Dear Krzysztof,
> 
> The reason, adding a new compatible strings for the MT8189 encoder, is
> same as for decoder, to use different of_device_id data and to
> distinguish the chip name.

You speak about drivers, this is not relevant. Explain the hardware -
WHY it is not compatible, what is the difference

Best regards,
Krzysztof

On Tue, 2025-07-22 at 13:09 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 22/07/2025 10:16, Kyrie Wu (吴晗) wrote:
> > On Tue, 2025-07-22 at 09:26 +0200, Krzysztof Kozlowski wrote:
> > > External email : Please do not click links or open attachments
> > > until
> > > you have verified the sender or the content.
> > > 
> > > 
> > > On Mon, Jul 21, 2025 at 06:55:19PM +0800, Kyrie Wu wrote:
> > > > Add MT8189 encoder compatible string, which will reference SCP
> > > > device.
> > > 
> > > And the device is not compatible or is different because of what?
> > > 
> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > 
> > > Best regards,
> > > Krzysztof
> > > 
> > 
> > Dear Krzysztof,
> > 
> > The reason, adding a new compatible strings for the MT8189 encoder,
> > is
> > same as for decoder, to use different of_device_id data and to
> > distinguish the chip name.
> 
> You speak about drivers, this is not relevant. Explain the hardware -
> WHY it is not compatible, what is the difference
> 
> Best regards,
> Krzysztof

Dear Krzysztof,

For encoder, the hardware differences are shown as follow:
Compared with MT8196, the maximum resolution of MT8189 encoder is only
4K, and the fps is only 30, which cannot reach the highest parameter of
MT8196: level6.2, 8K@60fps.
Compared with MT8188, the level can only support 5.1, which is less
than 5.2 of MT8188. But the maximum bitrate is 100Mbps, which is twice
that of MT8188.

The above informations will be updated to the commit messages in the
coming version.

Thanks.

Regards,
Kyire.