Add compatible for video decoder on MT8189 platform, which is a
pure single core architecture.

Signed-off-by: Kyrie Wu <kyrie.wu@mediatek.com>
---
 .../bindings/media/mediatek,vcodec-subdev-decoder.yaml           | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
index 74e1d88d3056..1bb5a2485e4c 100644
--- a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
@@ -77,6 +77,7 @@ properties:
       - mediatek,mt8188-vcodec-dec
       - mediatek,mt8195-vcodec-dec
       - mediatek,mt8196-vcodec-dec
+      - mediatek,mt8189-vcodec-dec
 
   reg:
     minItems: 1
-- 
2.46.0

On Mon, Jul 21, 2025 at 06:55:13PM +0800, Kyrie Wu wrote:
> Add compatible for video decoder on MT8189 platform, which is a
> pure single core architecture.

Looks compatible with existing ones and nothing in commit msg explains
why it was not made compatible. Describe the hardware, say something
useful to avoid such questions.

Best regards,
Krzysztof

On Tue, 2025-07-22 at 09:25 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Mon, Jul 21, 2025 at 06:55:13PM +0800, Kyrie Wu wrote:
> > Add compatible for video decoder on MT8189 platform, which is a
> > pure single core architecture.
> 
> Looks compatible with existing ones and nothing in commit msg
> explains
> why it was not made compatible. Describe the hardware, say something
> useful to avoid such questions.
> 
> Best regards,
> Krzysztof
> 
Dear Krzysztof,

There are two reasons for adding a new compatible string to MT8189:
On the one hand, MT8189 is a pure single-core hardware chip, so the
of_device_id data is different;
On the other hand, the correct chip name can be set through the
compatible strings;
The above two reasons are reflected in the following patch:

https://patchwork.linuxtv.org/project/linux-media/patch/20250721105520.5625-3-kyrie.wu@mediatek.com/

Thanks.

Regards,
Kyrie.

On 22/07/2025 10:11, Kyrie Wu (吴晗) wrote:
> On Tue, 2025-07-22 at 09:25 +0200, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> On Mon, Jul 21, 2025 at 06:55:13PM +0800, Kyrie Wu wrote:
>>> Add compatible for video decoder on MT8189 platform, which is a
>>> pure single core architecture.
>>
>> Looks compatible with existing ones and nothing in commit msg
>> explains
>> why it was not made compatible. Describe the hardware, say something
>> useful to avoid such questions.
>>
>> Best regards,
>> Krzysztof
>>
> Dear Krzysztof,
> 
> There are two reasons for adding a new compatible string to MT8189:
> On the one hand, MT8189 is a pure single-core hardware chip, so the
> of_device_id data is different;

Not relevant. Your of_device_id is wrong and based on that you claim the
hardware is different?

Describe the hardware.

Best regards,
Krzysztof

On Tue, 2025-07-22 at 13:09 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 22/07/2025 10:11, Kyrie Wu (吴晗) wrote:
> > On Tue, 2025-07-22 at 09:25 +0200, Krzysztof Kozlowski wrote:
> > > External email : Please do not click links or open attachments
> > > until
> > > you have verified the sender or the content.
> > > 
> > > 
> > > On Mon, Jul 21, 2025 at 06:55:13PM +0800, Kyrie Wu wrote:
> > > > Add compatible for video decoder on MT8189 platform, which is a
> > > > pure single core architecture.
> > > 
> > > Looks compatible with existing ones and nothing in commit msg
> > > explains
> > > why it was not made compatible. Describe the hardware, say
> > > something
> > > useful to avoid such questions.
> > > 
> > > Best regards,
> > > Krzysztof
> > > 
> > 
> > Dear Krzysztof,
> > 
> > There are two reasons for adding a new compatible string to MT8189:
> > On the one hand, MT8189 is a pure single-core hardware chip, so the
> > of_device_id data is different;
> 
> Not relevant. Your of_device_id is wrong and based on that you claim
> the
> hardware is different?
> 
> Describe the hardware.
> 
> Best regards,
> Krzysztof

Dear Krzysztof,

Sorry for the misunderstanding in your reply. I will update the commit
messages in the next version of patchset to introduce the hardware
differences of MT8189.

In summary, compared with other ICs, the MT8189 encoder and decoder use
iommu instead of smmu, and use scp architecture, the frequency is only
406MHZ, and cannot reach more than 700MHZ. At the same time, the
decoder supports the vp9 decoding protocol for the first time.

Thanks.

Regards,
Kyrie.