[v3] arm64: dts: qcom: ipq5018: Add crypto nodes

[PATCH v3] arm64: dts: qcom: ipq5018: Add crypto nodes

Posted by George Moussalem via B4 Relay 2 months, 2 weeks ago

From: George Moussalem <george.moussalem@outlook.com>

IPQ5018 uses Qualcomm QCE crypto engine v5.1 which is already supported.
So let's add the dts nodes for its DMA v1.7.4 and QCE itself.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: George Moussalem <george.moussalem@outlook.com>
---
Changes in v3:
- Rebased on tip of master for patch to cleanly apply, no other changes.
- Link to v2: https://lore.kernel.org/r/20250524-ipq5018-crypto-v2-1-faa26aedc4cf@outlook.com

Changes in v2:
- As per Konrad's comment, the BAM DMA controller is v1.7.4, so updated
  the dma controller node accordingly.
- Link to v1: https://lore.kernel.org/r/20250523-ipq5018-crypto-v1-1-0818047d8a18@outlook.com
---
 arch/arm64/boot/dts/qcom/ipq5018.dtsi | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
index 9ce73682e4ae7cde90f151dfcd41a5201ced2aa6..a6d1f9dc53ff41b7f21caf658ea5ddb5d84ff05c 100644
--- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
@@ -340,6 +340,36 @@ tsens: thermal-sensor@4a9000 {
 			#thermal-sensor-cells = <1>;
 		};
 
+		cryptobam: dma-controller@704000 {
+			compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
+			reg = <0x00704000 0x20000>;
+			interrupts = <GIC_SPI 207 IRQ_TYPE_LEVEL_HIGH>;
+
+			clocks = <&gcc GCC_CRYPTO_AHB_CLK>;
+			clock-names = "bam_clk";
+
+			#dma-cells = <1>;
+			qcom,ee = <1>;
+			qcom,controlled-remotely;
+		};
+
+		crypto: crypto@73a000 {
+			compatible = "qcom,crypto-v5.1";
+			reg = <0x0073a000 0x6000>;
+
+			clocks = <&gcc GCC_CRYPTO_AHB_CLK>,
+				 <&gcc GCC_CRYPTO_AXI_CLK>,
+				 <&gcc GCC_CRYPTO_CLK>;
+			clock-names = "iface",
+				      "bus",
+				      "core";
+
+			dmas = <&cryptobam 2>,
+			       <&cryptobam 3>;
+			dma-names = "rx",
+				    "tx";
+		};
+
 		tlmm: pinctrl@1000000 {
 			compatible = "qcom,ipq5018-tlmm";
 			reg = <0x01000000 0x300000>;

---
base-commit: a350d73e26be09ba893b878248f29c9021528802
change-id: 20250523-ipq5018-crypto-0265b8854b0c

Best regards,
-- 
George Moussalem <george.moussalem@outlook.com>

Re: [PATCH v3] arm64: dts: qcom: ipq5018: Add crypto nodes

Posted by Bjorn Andersson 1 month, 3 weeks ago

On Mon, 21 Jul 2025 10:23:15 +0400, George Moussalem wrote:
> IPQ5018 uses Qualcomm QCE crypto engine v5.1 which is already supported.
> So let's add the dts nodes for its DMA v1.7.4 and QCE itself.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: ipq5018: Add crypto nodes
      commit: ed5789ba7c2ce548f01ebbdbd7488dd9cccc4513

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH v3] arm64: dts: qcom: ipq5018: Add crypto nodes

Posted by Dmitry Baryshkov 2 months, 2 weeks ago

On Mon, Jul 21, 2025 at 10:23:15AM +0400, George Moussalem wrote:
> IPQ5018 uses Qualcomm QCE crypto engine v5.1 which is already supported.
> So let's add the dts nodes for its DMA v1.7.4 and QCE itself.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: George Moussalem <george.moussalem@outlook.com>
> ---
> Changes in v3:
> - Rebased on tip of master for patch to cleanly apply, no other changes.
> - Link to v2: https://lore.kernel.org/r/20250524-ipq5018-crypto-v2-1-faa26aedc4cf@outlook.com
> 
> Changes in v2:
> - As per Konrad's comment, the BAM DMA controller is v1.7.4, so updated
>   the dma controller node accordingly.
> - Link to v1: https://lore.kernel.org/r/20250523-ipq5018-crypto-v1-1-0818047d8a18@outlook.com
> ---
>  arch/arm64/boot/dts/qcom/ipq5018.dtsi | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry