rust: list: remove nonexistent generic parameter in link

[PATCH] rust: list: remove nonexistent generic parameter in link

Posted by Miguel Ojeda 2 months, 2 weeks ago

`ListLinks` does not take a `T` generic parameter, unlike
`ListLinksSelfPtr`.

Thus fix it, which makes it also consistent with the rest of the links
in the file.

Fixes: 40c53294596b ("rust: list: add macro for implementing ListItem")
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
---
 rust/kernel/list/impl_list_item_mod.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/rust/kernel/list/impl_list_item_mod.rs b/rust/kernel/list/impl_list_item_mod.rs
index f4c91832a875..202bc6f97c13 100644
--- a/rust/kernel/list/impl_list_item_mod.rs
+++ b/rust/kernel/list/impl_list_item_mod.rs
@@ -17,13 +17,13 @@
 /// [`ListLinks<ID>`]: crate::list::ListLinks
 /// [`ListItem`]: crate::list::ListItem
 pub unsafe trait HasListLinks<const ID: u64 = 0> {
-    /// Returns a pointer to the [`ListLinks<T, ID>`] field.
+    /// Returns a pointer to the [`ListLinks<ID>`] field.
     ///
     /// # Safety
     ///
     /// The provided pointer must point at a valid struct of type `Self`.
     ///
-    /// [`ListLinks<T, ID>`]: crate::list::ListLinks
+    /// [`ListLinks<ID>`]: crate::list::ListLinks
     unsafe fn raw_get_list_links(ptr: *mut Self) -> *mut crate::list::ListLinks<ID>;
 }
 

base-commit: cc84ef3b88f407e8bd5a5f7b6906d1e69851c856
-- 
2.50.1

Re: [PATCH] rust: list: remove nonexistent generic parameter in link

Posted by Miguel Ojeda 2 months, 2 weeks ago

On Sun, Jul 20, 2025 at 1:25 AM Miguel Ojeda <ojeda@kernel.org> wrote:
>
> `ListLinks` does not take a `T` generic parameter, unlike
> `ListLinksSelfPtr`.
>
> Thus fix it, which makes it also consistent with the rest of the links
> in the file.
>
> Fixes: 40c53294596b ("rust: list: add macro for implementing ListItem")
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Applied to `rust-next` -- thanks!

Cheers,
Miguel

Re: [PATCH] rust: list: remove nonexistent generic parameter in link

Posted by Tamir Duberstein 2 months, 2 weeks ago

On Sat, Jul 19, 2025 at 7:25 PM Miguel Ojeda <ojeda@kernel.org> wrote:
>
> `ListLinks` does not take a `T` generic parameter, unlike
> `ListLinksSelfPtr`.
>
> Thus fix it, which makes it also consistent with the rest of the links
> in the file.
>
> Fixes: 40c53294596b ("rust: list: add macro for implementing ListItem")
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Reviewed-by: Tamir Duberstein <tamird@gmail.com>

> ---
>  rust/kernel/list/impl_list_item_mod.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/rust/kernel/list/impl_list_item_mod.rs b/rust/kernel/list/impl_list_item_mod.rs
> index f4c91832a875..202bc6f97c13 100644
> --- a/rust/kernel/list/impl_list_item_mod.rs
> +++ b/rust/kernel/list/impl_list_item_mod.rs
> @@ -17,13 +17,13 @@
>  /// [`ListLinks<ID>`]: crate::list::ListLinks
>  /// [`ListItem`]: crate::list::ListItem
>  pub unsafe trait HasListLinks<const ID: u64 = 0> {
> -    /// Returns a pointer to the [`ListLinks<T, ID>`] field.
> +    /// Returns a pointer to the [`ListLinks<ID>`] field.
>      ///
>      /// # Safety
>      ///
>      /// The provided pointer must point at a valid struct of type `Self`.
>      ///
> -    /// [`ListLinks<T, ID>`]: crate::list::ListLinks
> +    /// [`ListLinks<ID>`]: crate::list::ListLinks
>      unsafe fn raw_get_list_links(ptr: *mut Self) -> *mut crate::list::ListLinks<ID>;
>  }
>
>
> base-commit: cc84ef3b88f407e8bd5a5f7b6906d1e69851c856
> --
> 2.50.1
>
>