dt-bindings: firmware: imx95-scmi: Allow linux,code for protocol@81

[PATCH V2 RESEND] dt-bindings: firmware: imx95-scmi: Allow linux,code for protocol@81

Posted by Peng Fan 2 months, 2 weeks ago

From: Alexander Stein <alexander.stein@ew.tq-group.com>

BBM protocol supports a single power button, supported by driver
imx-sm-bbm-key.c. By default this is KEY_POWER, but can also be overwritten
using linux,code. Add a reference to this schema and add linux,code as a
supported property.

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---

Resend [1].
I not see a reason that why this patch could block i.MX95 remoteproc support[2].
But to speed up the work, I took Alexander's work and resend it. Hope this
could catch 6.17

[1]https://lore.kernel.org/imx/20250513-whimsical-almond-quoll-e3ad5b@sudeepholla/
[2]https://lore.kernel.org/linux-remoteproc/PAXPR04MB8459A0F330554EB69E990E048850A@PAXPR04MB8459.eurprd04.prod.outlook.com/T/#t

 .../devicetree/bindings/firmware/nxp,imx95-scmi.yaml   | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml
index 2bda2e0e1369..7a5a02da2719 100644
--- a/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml
+++ b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml
@@ -24,13 +24,19 @@ properties:
         const: 0x80
 
   protocol@81:
-    $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node'
-    unevaluatedProperties: false
+    type: object
+    allOf:
+      - $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node'
+      - $ref: /schemas/input/input.yaml#
+    additionalProperties: false
 
     properties:
       reg:
         const: 0x81
 
+      linux,code:
+        default: 116  # KEY_POWER
+
   protocol@82:
     description:
       SCMI CPU Protocol which allows an agent to start or stop a CPU. It is
-- 
2.37.1

Re: [PATCH V2 RESEND] dt-bindings: firmware: imx95-scmi: Allow linux,code for protocol@81

Posted by Peng Fan 1 month, 1 week ago

Hi Sudeep, Shawn

On Fri, Jul 18, 2025 at 05:47:22PM +0800, Peng Fan wrote:
>From: Alexander Stein <alexander.stein@ew.tq-group.com>
>
>BBM protocol supports a single power button, supported by driver
>imx-sm-bbm-key.c. By default this is KEY_POWER, but can also be overwritten
>using linux,code. Add a reference to this schema and add linux,code as a
>supported property.
>
>Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>Signed-off-by: Peng Fan <peng.fan@nxp.com>
>---

Not sure which tree this patch should be landed in. But would you please
pick it up?

Thanks,
Peng

Re: [PATCH V2 RESEND] dt-bindings: firmware: imx95-scmi: Allow linux,code for protocol@81

Posted by Shawn Guo 3 weeks, 5 days ago

On Mon, Aug 25, 2025 at 04:21:54PM +0800, Peng Fan wrote:
> Hi Sudeep, Shawn
> 
> On Fri, Jul 18, 2025 at 05:47:22PM +0800, Peng Fan wrote:
> >From: Alexander Stein <alexander.stein@ew.tq-group.com>
> >
> >BBM protocol supports a single power button, supported by driver
> >imx-sm-bbm-key.c. By default this is KEY_POWER, but can also be overwritten
> >using linux,code. Add a reference to this schema and add linux,code as a
> >supported property.
> >
> >Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> >Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> >Signed-off-by: Peng Fan <peng.fan@nxp.com>
> >---
> 
> Not sure which tree this patch should be landed in. But would you please
> pick it up?

I do not see the patch in next-20250910, nor reply from Sudeep
indicating it's been applied, so I just picked it up.

Shawn

Re: [PATCH V2 RESEND] dt-bindings: firmware: imx95-scmi: Allow linux, code for protocol@81

Posted by Alexander Stein 2 months, 2 weeks ago

Hi,

Am Freitag, 18. Juli 2025, 11:47:22 CEST schrieb Peng Fan:
> From: Alexander Stein <alexander.stein@ew.tq-group.com>
> 
> BBM protocol supports a single power button, supported by driver
> imx-sm-bbm-key.c. By default this is KEY_POWER, but can also be overwritten
> using linux,code. Add a reference to this schema and add linux,code as a
> supported property.
> 
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> 
> Resend [1].
> I not see a reason that why this patch could block i.MX95 remoteproc support[2].
> But to speed up the work, I took Alexander's work and resend it. Hope this
> could catch 6.17
> 
> [1]https://lore.kernel.org/imx/20250513-whimsical-almond-quoll-e3ad5b@sudeepholla/
> [2]https://lore.kernel.org/linux-remoteproc/PAXPR04MB8459A0F330554EB69E990E048850A@PAXPR04MB8459.eurprd04.prod.outlook.com/T/#t

Thanks for resending, I lost track of this patch and though it as applied already.

Best regards,
Alexander

> 
>  .../devicetree/bindings/firmware/nxp,imx95-scmi.yaml   | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml
> index 2bda2e0e1369..7a5a02da2719 100644
> --- a/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml
> +++ b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml
> @@ -24,13 +24,19 @@ properties:
>          const: 0x80
>  
>    protocol@81:
> -    $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node'
> -    unevaluatedProperties: false
> +    type: object
> +    allOf:
> +      - $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node'
> +      - $ref: /schemas/input/input.yaml#
> +    additionalProperties: false
>  
>      properties:
>        reg:
>          const: 0x81
>  
> +      linux,code:
> +        default: 116  # KEY_POWER
> +
>    protocol@82:
>      description:
>        SCMI CPU Protocol which allows an agent to start or stop a CPU. It is
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

Re: [PATCH V2 RESEND] dt-bindings: firmware: imx95-scmi: Allow linux, code for protocol@81

Posted by Sudeep Holla 2 months, 2 weeks ago

On Thu, Jul 24, 2025 at 12:17:17PM +0200, Alexander Stein wrote:
> Hi,
> 
> Am Freitag, 18. Juli 2025, 11:47:22 CEST schrieb Peng Fan:
> > From: Alexander Stein <alexander.stein@ew.tq-group.com>
> > 
> > BBM protocol supports a single power button, supported by driver
> > imx-sm-bbm-key.c. By default this is KEY_POWER, but can also be overwritten
> > using linux,code. Add a reference to this schema and add linux,code as a
> > supported property.
> > 
> > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > 
> > Resend [1].
> > I not see a reason that why this patch could block i.MX95 remoteproc support[2].
> > But to speed up the work, I took Alexander's work and resend it. Hope this
> > could catch 6.17
> > 
> > [1]https://lore.kernel.org/imx/20250513-whimsical-almond-quoll-e3ad5b@sudeepholla/
> > [2]https://lore.kernel.org/linux-remoteproc/PAXPR04MB8459A0F330554EB69E990E048850A@PAXPR04MB8459.eurprd04.prod.outlook.com/T/#t
> 
> Thanks for resending, I lost track of this patch and though it as applied already.
> 

Sorry if I missed it. I would have assumed anything without code in the
series should go via DT tree directly. I can pick it up for v6.18 unless
Rob is OK to pick it up for v6.17(assuming it is not too late)

-- 
Regards,
Sudeep