The gcc_aux_clk is required by the PCIe controller but not by the PCIe
PHY. In PCIe PHY, the source of aux_clk used in low-power mode should
be gcc_phy_aux_clk. Hence, remove gcc_aux_clk and replace it with
gcc_phy_aux_clk.
Removed the phy_aux clock from the PCIe PHY binding as it is no longer
used by any instance.
Fixes: fd2d4e4c1986 ("dt-bindings: phy: qcom,qmp: Add sa8775p QMP PCIe PHY")
Signed-off-by: Ziyue Zhang <ziyue.zhang@oss.qualcomm.com>
---
.../devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
index 2c6c9296e4c0..17fd6547d3b4 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
@@ -176,6 +176,8 @@ allOf:
contains:
enum:
- qcom,qcs615-qmp-gen3x1-pcie-phy
+ - qcom,sa8775p-qmp-gen4x2-pcie-phy
+ - qcom,sa8775p-qmp-gen4x4-pcie-phy
- qcom,sc8280xp-qmp-gen3x1-pcie-phy
- qcom,sc8280xp-qmp-gen3x2-pcie-phy
- qcom,sc8280xp-qmp-gen3x4-pcie-phy
@@ -197,8 +199,6 @@ allOf:
contains:
enum:
- qcom,qcs8300-qmp-gen4x2-pcie-phy
- - qcom,sa8775p-qmp-gen4x2-pcie-phy
- - qcom,sa8775p-qmp-gen4x4-pcie-phy
then:
properties:
clocks:
--
2.34.1
On Fri, 18 Jul 2025 16:17:15 +0800, Ziyue Zhang wrote: > The gcc_aux_clk is required by the PCIe controller but not by the PCIe > PHY. In PCIe PHY, the source of aux_clk used in low-power mode should > be gcc_phy_aux_clk. Hence, remove gcc_aux_clk and replace it with > gcc_phy_aux_clk. > > Removed the phy_aux clock from the PCIe PHY binding as it is no longer > used by any instance. > > Fixes: fd2d4e4c1986 ("dt-bindings: phy: qcom,qmp: Add sa8775p QMP PCIe PHY") > Signed-off-by: Ziyue Zhang <ziyue.zhang@oss.qualcomm.com> > --- > .../devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed. Missing tags: Acked-by: Rob Herring (Arm) <robh@kernel.org>
On Fri, Jul 18, 2025 at 04:17:15PM +0800, Ziyue Zhang wrote: > The gcc_aux_clk is required by the PCIe controller but not by the PCIe > PHY. In PCIe PHY, the source of aux_clk used in low-power mode should > be gcc_phy_aux_clk. Hence, remove gcc_aux_clk and replace it with > gcc_phy_aux_clk. > Removed the phy_aux clock from the PCIe PHY binding as it is no longer > used by any instance. This paragraph no longer applies to this patch (but to the qcs8300 one that removes the clock). > Fixes: fd2d4e4c1986 ("dt-bindings: phy: qcom,qmp: Add sa8775p QMP PCIe PHY") > Signed-off-by: Ziyue Zhang <ziyue.zhang@oss.qualcomm.com> > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml > @@ -176,6 +176,8 @@ allOf: > contains: > enum: > - qcom,qcs615-qmp-gen3x1-pcie-phy > + - qcom,sa8775p-qmp-gen4x2-pcie-phy > + - qcom,sa8775p-qmp-gen4x4-pcie-phy > - qcom,sc8280xp-qmp-gen3x1-pcie-phy > - qcom,sc8280xp-qmp-gen3x2-pcie-phy > - qcom,sc8280xp-qmp-gen3x4-pcie-phy > @@ -197,8 +199,6 @@ allOf: > contains: > enum: > - qcom,qcs8300-qmp-gen4x2-pcie-phy > - - qcom,sa8775p-qmp-gen4x2-pcie-phy > - - qcom,sa8775p-qmp-gen4x4-pcie-phy > then: > properties: > clocks: Johan
© 2016 - 2025 Red Hat, Inc.