[v1] pinctrl: rp1: use new GPIO line value setter callbacks

[RESEND PATCH] pinctrl: rp1: use new GPIO line value setter callbacks

Posted by Bartosz Golaszewski 2 months, 3 weeks ago

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
Resending with linux-gpio correctly in Cc.

Another driver we missed, that should be the last one under
drivers/pinctrl/.

 drivers/pinctrl/pinctrl-rp1.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-rp1.c b/drivers/pinctrl/pinctrl-rp1.c
index d300f28c52cd..6080b57a5d87 100644
--- a/drivers/pinctrl/pinctrl-rp1.c
+++ b/drivers/pinctrl/pinctrl-rp1.c
@@ -779,12 +779,14 @@ static int rp1_gpio_get(struct gpio_chip *chip, unsigned int offset)
 	return ret;
 }
 
-static void rp1_gpio_set(struct gpio_chip *chip, unsigned int offset, int value)
+static int rp1_gpio_set(struct gpio_chip *chip, unsigned int offset, int value)
 {
 	struct rp1_pin_info *pin = rp1_get_pin(chip, offset);
 
 	if (pin)
 		rp1_set_value(pin, value);
+
+	return 0;
 }
 
 static int rp1_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
@@ -849,7 +851,7 @@ static const struct gpio_chip rp1_gpio_chip = {
 	.direction_output = rp1_gpio_direction_output,
 	.get_direction = rp1_gpio_get_direction,
 	.get = rp1_gpio_get,
-	.set = rp1_gpio_set,
+	.set_rv = rp1_gpio_set,
 	.base = -1,
 	.set_config = rp1_gpio_set_config,
 	.ngpio = RP1_NUM_GPIOS,
-- 
2.48.1

Re: [RESEND PATCH] pinctrl: rp1: use new GPIO line value setter callbacks

Posted by Andrea della Porta 2 months, 2 weeks ago

Hi Bartosz,

On 15:13 Thu 17 Jul     , Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. Convert the driver to using
> them.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> Resending with linux-gpio correctly in Cc.
> 
> Another driver we missed, that should be the last one under
> drivers/pinctrl/.
> 
>  drivers/pinctrl/pinctrl-rp1.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-rp1.c b/drivers/pinctrl/pinctrl-rp1.c
> index d300f28c52cd..6080b57a5d87 100644
> --- a/drivers/pinctrl/pinctrl-rp1.c
> +++ b/drivers/pinctrl/pinctrl-rp1.c
> @@ -779,12 +779,14 @@ static int rp1_gpio_get(struct gpio_chip *chip, unsigned int offset)
>  	return ret;
>  }
>  
> -static void rp1_gpio_set(struct gpio_chip *chip, unsigned int offset, int value)
> +static int rp1_gpio_set(struct gpio_chip *chip, unsigned int offset, int value)
>  {
>  	struct rp1_pin_info *pin = rp1_get_pin(chip, offset);
>  
>  	if (pin)
>  		rp1_set_value(pin, value);
> +
> +	return 0;
>  }
>  
>  static int rp1_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
> @@ -849,7 +851,7 @@ static const struct gpio_chip rp1_gpio_chip = {
>  	.direction_output = rp1_gpio_direction_output,
>  	.get_direction = rp1_gpio_get_direction,
>  	.get = rp1_gpio_get,
> -	.set = rp1_gpio_set,
> +	.set_rv = rp1_gpio_set,
>  	.base = -1,
>  	.set_config = rp1_gpio_set_config,
>  	.ngpio = RP1_NUM_GPIOS,
> -- 
> 2.48.1
>

Reviewed-by: Andrea della Porta <andrea.porta@suse.com>