[PATCH 0/4] STi device-tree display subsystem rework

Raphael Gallais-Pou posted 4 patches 2 months, 2 weeks ago
arch/arm/boot/dts/st/stih410.dtsi | 316 ++++++++++++++++++++++----------------
drivers/gpu/drm/sti/sti_drv.c     |  18 +--
2 files changed, 192 insertions(+), 142 deletions(-)
[PATCH 0/4] STi device-tree display subsystem rework
Posted by Raphael Gallais-Pou 2 months, 2 weeks ago
This serie aims to rework the display-subsystem node, which was
previously included directly within the SoC node.  This was wrong
because it is an abstraction and describes how IPs behave together, not
what the hardware is.  Instead, extract display-subsystem outside of the
SoC node, and let IPs describe their connections.  Doing so helps the
readability, and eases the understanding of the hardware.

Several nodes have been renamed to stick to the generic names defined in
the device-tree specification.

This series depends on another sent a few days ago.  It is not critical
though, since not having it only triggers warnings when building
deprecated device-trees.  Please see link below.

Link: https://lore.kernel.org/lkml/20250714-sti-rework-v2-0-f4274920858b@gmail.com

Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
---
Raphael Gallais-Pou (4):
      drm/sti: check dma_set_coherent_mask return value
      drm/sti: make use of drm_of_component_probe
      ARM: dts: sti: extract display subsystem out of soc
      ARM: dts: sti: remove useless cells fields

 arch/arm/boot/dts/st/stih410.dtsi | 316 ++++++++++++++++++++++----------------
 drivers/gpu/drm/sti/sti_drv.c     |  18 +--
 2 files changed, 192 insertions(+), 142 deletions(-)
---
base-commit: b9a572f471993d3e8bf874fcb57f331d66650440
change-id: 20250401-sti-rework-b009551a362c

Best regards,
-- 
Raphael Gallais-Pou <rgallaispou@gmail.com>
Re: [PATCH 0/4] STi device-tree display subsystem rework
Posted by Raphaël Gallais-Pou 2 weeks, 5 days ago

Le 17/07/2025 à 21:15, Raphael Gallais-Pou a écrit :
> This serie aims to rework the display-subsystem node, which was
> previously included directly within the SoC node.  This was wrong
> because it is an abstraction and describes how IPs behave together, not
> what the hardware is.  Instead, extract display-subsystem outside of the
> SoC node, and let IPs describe their connections.  Doing so helps the
> readability, and eases the understanding of the hardware.
> 
> Several nodes have been renamed to stick to the generic names defined in
> the device-tree specification.
> 
> This series depends on another sent a few days ago.  It is not critical
> though, since not having it only triggers warnings when building
> deprecated device-trees.  Please see link below.
> 
> Link: https://lore.kernel.org/lkml/20250714-sti-rework-v2-0-f4274920858b@gmail.com
> 
> Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
> ---
> Raphael Gallais-Pou (4):
>        drm/sti: check dma_set_coherent_mask return value
>        drm/sti: make use of drm_of_component_probe
>        ARM: dts: sti: extract display subsystem out of soc
>        ARM: dts: sti: remove useless cells fields
> 
Hi,

@Patrice
Would you agree to make the device-tree patches go through drm-misc 
instead of your tree ? So that the breaking change lands in -next in the 
same time as the driver changes.

I will send another series to convert display subsystem bindings to DT 
schema as soon as the series is merged.

@Alain
Do you prefer to merge it yourself or you rather let me do it ?

Best regards,
Raphaël>   arch/arm/boot/dts/st/stih410.dtsi | 316 
++++++++++++++++++++++----------------
>   drivers/gpu/drm/sti/sti_drv.c     |  18 +--
>   2 files changed, 192 insertions(+), 142 deletions(-)
> ---
> base-commit: b9a572f471993d3e8bf874fcb57f331d66650440
> change-id: 20250401-sti-rework-b009551a362c
> 
> Best regards,

Re: [PATCH 0/4] STi device-tree display subsystem rework
Posted by Alain Volmat 1 week, 6 days ago
Hi Raphaël,

On Wed, Sep 17, 2025 at 12:03:43AM +0200, Raphaël Gallais-Pou wrote:

(...)

> @Alain
> Do you prefer to merge it yourself or you rather let me do it ?

Please go ahead, you can merge it.

Thanks.
Alain

> 
> Best regards,
> Raphaël>   arch/arm/boot/dts/st/stih410.dtsi | 316
> ++++++++++++++++++++++----------------
> >   drivers/gpu/drm/sti/sti_drv.c     |  18 +--
> >   2 files changed, 192 insertions(+), 142 deletions(-)
> > ---
> > base-commit: b9a572f471993d3e8bf874fcb57f331d66650440
> > change-id: 20250401-sti-rework-b009551a362c
> > 
> > Best regards,
> 
Re: [PATCH 0/4] STi device-tree display subsystem rework
Posted by Patrice CHOTARD 2 weeks, 5 days ago

On 9/17/25 00:03, Raphaël Gallais-Pou wrote:
> 
> 
> Le 17/07/2025 à 21:15, Raphael Gallais-Pou a écrit :
>> This serie aims to rework the display-subsystem node, which was
>> previously included directly within the SoC node.  This was wrong
>> because it is an abstraction and describes how IPs behave together, not
>> what the hardware is.  Instead, extract display-subsystem outside of the
>> SoC node, and let IPs describe their connections.  Doing so helps the
>> readability, and eases the understanding of the hardware.
>>
>> Several nodes have been renamed to stick to the generic names defined in
>> the device-tree specification.
>>
>> This series depends on another sent a few days ago.  It is not critical
>> though, since not having it only triggers warnings when building
>> deprecated device-trees.  Please see link below.
>>
>> Link: https://lore.kernel.org/lkml/20250714-sti-rework-v2-0-f4274920858b@gmail.com
>>
>> Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
>> ---
>> Raphael Gallais-Pou (4):
>>        drm/sti: check dma_set_coherent_mask return value
>>        drm/sti: make use of drm_of_component_probe
>>        ARM: dts: sti: extract display subsystem out of soc
>>        ARM: dts: sti: remove useless cells fields
>>
> Hi,
> 
> @Patrice
> Would you agree to make the device-tree patches go through drm-misc instead of your tree ? So that the breaking change lands in -next in the same time as the driver changes.
> 

Hi Raphael

Yes of course.

Thanks
Patrice

> I will send another series to convert display subsystem bindings to DT schema as soon as the series is merged.
> 
> @Alain
> Do you prefer to merge it yourself or you rather let me do it ?
> 
> Best regards,
> Raphaël>   arch/arm/boot/dts/st/stih410.dtsi | 316 ++++++++++++++++++++++----------------
>>   drivers/gpu/drm/sti/sti_drv.c     |  18 +--
>>   2 files changed, 192 insertions(+), 142 deletions(-)
>> ---
>> base-commit: b9a572f471993d3e8bf874fcb57f331d66650440
>> change-id: 20250401-sti-rework-b009551a362c
>>
>> Best regards,
> 
Re: [PATCH 0/4] STi device-tree display subsystem rework
Posted by Rob Herring (Arm) 2 months, 2 weeks ago
On Thu, 17 Jul 2025 21:15:31 +0200, Raphael Gallais-Pou wrote:
> This serie aims to rework the display-subsystem node, which was
> previously included directly within the SoC node.  This was wrong
> because it is an abstraction and describes how IPs behave together, not
> what the hardware is.  Instead, extract display-subsystem outside of the
> SoC node, and let IPs describe their connections.  Doing so helps the
> readability, and eases the understanding of the hardware.
> 
> Several nodes have been renamed to stick to the generic names defined in
> the device-tree specification.
> 
> This series depends on another sent a few days ago.  It is not critical
> though, since not having it only triggers warnings when building
> deprecated device-trees.  Please see link below.
> 
> Link: https://lore.kernel.org/lkml/20250714-sti-rework-v2-0-f4274920858b@gmail.com
> 
> Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
> ---
> Raphael Gallais-Pou (4):
>       drm/sti: check dma_set_coherent_mask return value
>       drm/sti: make use of drm_of_component_probe
>       ARM: dts: sti: extract display subsystem out of soc
>       ARM: dts: sti: remove useless cells fields
> 
>  arch/arm/boot/dts/st/stih410.dtsi | 316 ++++++++++++++++++++++----------------
>  drivers/gpu/drm/sti/sti_drv.c     |  18 +--
>  2 files changed, 192 insertions(+), 142 deletions(-)
> ---
> base-commit: b9a572f471993d3e8bf874fcb57f331d66650440
> change-id: 20250401-sti-rework-b009551a362c
> 
> Best regards,
> --
> Raphael Gallais-Pou <rgallaispou@gmail.com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: base-commit b9a572f471993d3e8bf874fcb57f331d66650440 not known, ignoring
 Base: attempting to guess base-commit...
 Base: tags/v6.16-rc1-11-g2436e190bbdd (exact match)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/st/' for 20250717-sti-rework-v1-0-46d516fb1ebb@gmail.com:

arch/arm/boot/dts/st/stih410-b2120.dtb: soc (simple-bus): sti-display-subsystem@0: 'anyOf' conditional failed, one must be fixed:
	'reg' is a required property
	'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml#
arch/arm/boot/dts/st/stih410-b2120.dtb: /soc/display-controller@9d11000: failed to match any schema with compatible: ['st,stih407-compositor']
arch/arm/boot/dts/st/stih410-b2120.dtb: /soc/encoder@8d08000: failed to match any schema with compatible: ['st,stih407-tvout']
arch/arm/boot/dts/st/stih410-b2120.dtb: encoder@8d08000 (st,stih407-tvout): 'anyOf' conditional failed, one must be fixed:
	'clocks' is a required property
	'#clock-cells' is a required property
	from schema $id: http://devicetree.org/schemas/clock/clock.yaml#
arch/arm/boot/dts/st/stih410-b2120.dtb: /soc/hdmi@8d04000: failed to match any schema with compatible: ['st,stih407-hdmi']
arch/arm/boot/dts/st/stih410-b2260.dtb: /soc/display-controller@9d11000: failed to match any schema with compatible: ['st,stih407-compositor']
arch/arm/boot/dts/st/stih410-b2120.dtb: /soc/analog@8d02000: failed to match any schema with compatible: ['st,stih407-hda']
arch/arm/boot/dts/st/stih410-b2120.dtb: /soc/plane@9c00000: failed to match any schema with compatible: ['st,stih407-hqvdp']
arch/arm/boot/dts/st/stih410-b2260.dtb: /soc/encoder@8d08000: failed to match any schema with compatible: ['st,stih407-tvout']
arch/arm/boot/dts/st/stih410-b2260.dtb: encoder@8d08000 (st,stih407-tvout): 'anyOf' conditional failed, one must be fixed:
	'clocks' is a required property
	'#clock-cells' is a required property
	from schema $id: http://devicetree.org/schemas/clock/clock.yaml#
arch/arm/boot/dts/st/stih410-b2260.dtb: /soc/hdmi@8d04000: failed to match any schema with compatible: ['st,stih407-hdmi']
arch/arm/boot/dts/st/stih410-b2260.dtb: /soc/analog@8d02000: failed to match any schema with compatible: ['st,stih407-hda']
arch/arm/boot/dts/st/stih410-b2260.dtb: /soc/plane@9c00000: failed to match any schema with compatible: ['st,stih407-hqvdp']
arch/arm/boot/dts/st/stih410-b2120.dtb: /display-subsystem: failed to match any schema with compatible: ['st,sti-display-subsystem']
arch/arm/boot/dts/st/stih410-b2120.dtb: display-subsystem (st,sti-display-subsystem): 'anyOf' conditional failed, one must be fixed:
	'clocks' is a required property
	'#clock-cells' is a required property
	from schema $id: http://devicetree.org/schemas/clock/clock.yaml#
arch/arm/boot/dts/st/stih410-b2260.dtb: /display-subsystem: failed to match any schema with compatible: ['st,sti-display-subsystem']
arch/arm/boot/dts/st/stih410-b2260.dtb: display-subsystem (st,sti-display-subsystem): 'anyOf' conditional failed, one must be fixed:
	'clocks' is a required property
	'#clock-cells' is a required property
	from schema $id: http://devicetree.org/schemas/clock/clock.yaml#