[PATCH 2/4] arm64: dts: qcom: sm8150: use correct PD for DisplayPort controller

Dmitry Baryshkov posted 4 patches 2 months, 3 weeks ago
There is a newer version of this series
[PATCH 2/4] arm64: dts: qcom: sm8150: use correct PD for DisplayPort controller
Posted by Dmitry Baryshkov 2 months, 3 weeks ago
Commit 5dd110c90a50 ("arm64: dts: qcom: sm8150: add DisplayPort
controller") specified SM8250_MMCX for the DisplayPort power domain,
however on SM8160 this indices maps to SM8150_MX_AO. Use correct indice
instead (SM8150_MMCX).

Fixes: 5dd110c90a50 ("arm64: dts: qcom: sm8150: add DisplayPort controller")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index abf12e10d33f1ce5c74e3e9136585bcb0a578492..4b347ee3244100a4db515515b73575383c5a0cb7 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -3908,7 +3908,7 @@ mdss_dp: displayport-controller@ae90000 {
 				#sound-dai-cells = <0>;
 
 				operating-points-v2 = <&dp_opp_table>;
-				power-domains = <&rpmhpd SM8250_MMCX>;
+				power-domains = <&rpmhpd SM8150_MMCX>;
 
 				status = "disabled";
 

-- 
2.39.5
Re: [PATCH 2/4] arm64: dts: qcom: sm8150: use correct PD for DisplayPort controller
Posted by Konrad Dybcio 2 months, 3 weeks ago
On 7/17/25 2:48 PM, Dmitry Baryshkov wrote:
> Commit 5dd110c90a50 ("arm64: dts: qcom: sm8150: add DisplayPort
> controller") specified SM8250_MMCX for the DisplayPort power domain,
> however on SM8160 this indices maps to SM8150_MX_AO. Use correct indice

81*6*0 typo

> instead (SM8150_MMCX).
include/dt-bindings/power/qcom-rpmpd.h
90:#define SM8150_MMCX  9
91:#define SM8150_MMCX_AO       10
109:#define SM8250_MMCX 6
110:#define SM8250_MMCX_AO      7

(i.e. the commit message is misleading)


Konrad
Re: [PATCH 2/4] arm64: dts: qcom: sm8150: use correct PD for DisplayPort controller
Posted by Dmitry Baryshkov 2 months, 2 weeks ago
On Thu, Jul 17, 2025 at 04:27:33PM +0200, Konrad Dybcio wrote:
> On 7/17/25 2:48 PM, Dmitry Baryshkov wrote:
> > Commit 5dd110c90a50 ("arm64: dts: qcom: sm8150: add DisplayPort
> > controller") specified SM8250_MMCX for the DisplayPort power domain,
> > however on SM8160 this indices maps to SM8150_MX_AO. Use correct indice
> 
> 81*6*0 typo

Ack

> 
> > instead (SM8150_MMCX).
> include/dt-bindings/power/qcom-rpmpd.h
> 90:#define SM8150_MMCX  9
> 91:#define SM8150_MMCX_AO       10
> 109:#define SM8250_MMCX 6
> 110:#define SM8250_MMCX_AO      7
> 
> (i.e. the commit message is misleading)

#define SM8250_MMCX     6
#define SM8150_MX_AO    6
#define SM8150_MMCX     9

I will try to make it more obvious.

> 
> 
> Konrad

-- 
With best wishes
Dmitry