"fork: reorder function qualifiers for copy_clone_args_from_user"

[PATCH] "fork: reorder function qualifiers for copy_clone_args_from_user"

Posted by Dishank Jogi 2 months, 3 weeks ago

Change the order of function qualifiers from 'noinline static' to 'static noinline'
in copy_clone_args_from_user for consistency with kernel coding style.

This is a non-functional change intended to improve readability and maintain
consistent ordering of qualifiers across the codebase.

Signed-off-by: Dishank Jogi <dishank.jogi@siqol.com>
---
 kernel/fork.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/fork.c b/kernel/fork.c
index 1ee8eb11f38b..574ff0d983db 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -2743,7 +2743,7 @@ SYSCALL_DEFINE5(clone, unsigned long, clone_flags, unsigned long, newsp,
 }
 #endif
 
-noinline static int copy_clone_args_from_user(struct kernel_clone_args *kargs,
+static noinline int copy_clone_args_from_user(struct kernel_clone_args *kargs,
 					      struct clone_args __user *uargs,
 					      size_t usize)
 {
-- 
2.25.1

Re: [PATCH] "fork: reorder function qualifiers for copy_clone_args_from_user"

Posted by Kees Cook 2 months, 2 weeks ago

On Wed, 16 Jul 2025 15:05:25 +0530, Dishank Jogi wrote:
> Change the order of function qualifiers from 'noinline static' to 'static noinline'
> in copy_clone_args_from_user for consistency with kernel coding style.
> 
> This is a non-functional change intended to improve readability and maintain
> consistent ordering of qualifiers across the codebase.
> 
> 
> [...]

I've tweaked the commit log and Subject and applied to for-next/execve, thanks!

[1/1] fork: reorder function qualifiers for copy_clone_args_from_user
      https://git.kernel.org/kees/c/7f71195c15dc

Take care,

-- 
Kees Cook

Re: [PATCH] "fork: reorder function qualifiers for copy_clone_args_from_user"

Posted by Liam R. Howlett 2 months, 3 weeks ago

* Dishank Jogi <dishank.jogi@siqol.com> [250716 05:35]:
> Change the order of function qualifiers from 'noinline static' to 'static noinline'
> in copy_clone_args_from_user for consistency with kernel coding style.
> 
> This is a non-functional change intended to improve readability and maintain
> consistent ordering of qualifiers across the codebase.
> 
> Signed-off-by: Dishank Jogi <dishank.jogi@siqol.com>

Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>

> ---
>  kernel/fork.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 1ee8eb11f38b..574ff0d983db 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -2743,7 +2743,7 @@ SYSCALL_DEFINE5(clone, unsigned long, clone_flags, unsigned long, newsp,
>  }
>  #endif
>  
> -noinline static int copy_clone_args_from_user(struct kernel_clone_args *kargs,
> +static noinline int copy_clone_args_from_user(struct kernel_clone_args *kargs,
>  					      struct clone_args __user *uargs,
>  					      size_t usize)
>  {
> -- 
> 2.25.1
>

Re: [PATCH] "fork: reorder function qualifiers for copy_clone_args_from_user"

Posted by Lorenzo Stoakes 2 months, 3 weeks ago

I'm not sure what the "'s are for, hopefully whoever merges this removes
them :)

On Wed, Jul 16, 2025 at 03:05:25PM +0530, Dishank Jogi wrote:
> Change the order of function qualifiers from 'noinline static' to 'static noinline'
> in copy_clone_args_from_user for consistency with kernel coding style.
>
> This is a non-functional change intended to improve readability and maintain
> consistent ordering of qualifiers across the codebase.
>
> Signed-off-by: Dishank Jogi <dishank.jogi@siqol.com>

This seems fine so:

Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

> ---
>  kernel/fork.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 1ee8eb11f38b..574ff0d983db 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -2743,7 +2743,7 @@ SYSCALL_DEFINE5(clone, unsigned long, clone_flags, unsigned long, newsp,
>  }
>  #endif
>
> -noinline static int copy_clone_args_from_user(struct kernel_clone_args *kargs,
> +static noinline int copy_clone_args_from_user(struct kernel_clone_args *kargs,
>  					      struct clone_args __user *uargs,
>  					      size_t usize)
>  {
> --
> 2.25.1
>

Re: [PATCH] "fork: reorder function qualifiers for copy_clone_args_from_user"

Posted by David Hildenbrand 2 months, 3 weeks ago

On 16.07.25 11:35, Dishank Jogi wrote:

"" in patch subject is weird

> Change the order of function qualifiers from 'noinline static' to 'static noinline'
> in copy_clone_args_from_user for consistency with kernel coding style.
> 
> This is a non-functional change intended to improve readability and maintain
> consistent ordering of qualifiers across the codebase.

Simplify to "No functional change intended." All the other stuff can be 
dropped from this sentence IMHO -- I'd even drop the whole sentence.

> 
> Signed-off-by: Dishank Jogi <dishank.jogi@siqol.com>
> ---
>   kernel/fork.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 1ee8eb11f38b..574ff0d983db 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -2743,7 +2743,7 @@ SYSCALL_DEFINE5(clone, unsigned long, clone_flags, unsigned long, newsp,
>   }
>   #endif
>   
> -noinline static int copy_clone_args_from_user(struct kernel_clone_args *kargs,
> +static noinline int copy_clone_args_from_user(struct kernel_clone_args *kargs,
>   					      struct clone_args __user *uargs,
>   					      size_t usize)
>   {

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb