On Tue, Jul 15, 2025 at 10:01 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> Hello,
>
> The --code-with-type option is to show normal annotate output with type
> information. It was supported only on --stdio, but this change adds it
> to TUI as well.
>
> v3 changes)
> * hide stack operation and stack canary by default
>
> v2 changes)
> * use 'T' key to toggle data type display (Arnaldo)
> * display '[Type]' in the title line when it's enabled (Arnaldo)
> * show warning when debug info is not available (Arnaldo)
> * fix a typo (Arnaldo)
>
> Actually the command line option sets the default behavior and users can
> change it by pressing 'T' key in the TUI annotate browser.
>
> The code is also available at 'perf/annotate-code-type-tui-v3' branch at
> https://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
>
> Thanks,
> Namhyung
For the series:
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
> Namhyung Kim (8):
> perf annotate: Rename to __hist_entry__tui_annotate()
> perf annotate: Remove __annotation_line__write()
> perf annotate: Pass annotation_print_data to annotation_line__write()
> perf annotate: Simplify width calculation in annotation_line__write()
> perf annotate: Add --code-with-type support for TUI
> perf annotate: Add 'T' hot key to toggle data type display
> perf annotate: Show warning when debuginfo is not available
> perf annotate: Hide data-type for stack operation and canary
>
> tools/perf/Documentation/perf-annotate.txt | 1 -
> tools/perf/builtin-annotate.c | 5 -
> tools/perf/ui/browsers/annotate.c | 66 +++++++--
> tools/perf/ui/browsers/hists.c | 2 +-
> tools/perf/util/annotate.c | 157 ++++++++++++++-------
> tools/perf/util/annotate.h | 27 ++--
> tools/perf/util/dso.h | 11 ++
> tools/perf/util/hist.h | 12 +-
> 8 files changed, 191 insertions(+), 90 deletions(-)
>
> --
> 2.50.0
>