[PATCH] net: usb: Remove duplicate assignments for net->pcpu_stat_type

Zqiang posted 1 patch 2 months, 3 weeks ago
drivers/net/usb/usbnet.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] net: usb: Remove duplicate assignments for net->pcpu_stat_type
Posted by Zqiang 2 months, 3 weeks ago
This commit remove duplicate assignments for net->pcpu_stat_type
in usbnet_probe().

Signed-off-by: Zqiang <qiang.zhang@linux.dev>
---
 drivers/net/usb/usbnet.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 6a3cca104af9..921c05bc73e3 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1759,7 +1759,6 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
 	dev->hard_mtu = net->mtu + net->hard_header_len;
 	net->min_mtu = 0;
 	net->max_mtu = ETH_MAX_MTU;
-	net->pcpu_stat_type = NETDEV_PCPU_STAT_TSTATS;
 
 	net->netdev_ops = &usbnet_netdev_ops;
 	net->watchdog_timeo = TX_TIMEOUT_JIFFIES;
-- 
2.48.1
Re: [PATCH] net: usb: Remove duplicate assignments for net->pcpu_stat_type
Posted by Jakub Kicinski 2 months, 3 weeks ago
On Wed, 16 Jul 2025 08:15:24 +0800 Zqiang wrote:
> Signed-off-by: Zqiang <qiang.zhang@linux.dev>

Your email address seems to suggest the latin spelling of your name
should be Qiang Zhang. Please use that instead of Zqiang?
-- 
pw-bot: cr
Re: [PATCH] net: usb: Remove duplicate assignments for net->pcpu_stat_type
Posted by qiang.zhang@linux.dev 2 months, 3 weeks ago
> 
> On Wed, 16 Jul 2025 08:15:24 +0800 Zqiang wrote:
> 
> > 
> > Signed-off-by: Zqiang <qiang.zhang@linux.dev>
> > 
> 
> Your email address seems to suggest the latin spelling of your name
> 
> should be Qiang Zhang. Please use that instead of Zqiang?

Thanks for replay, Zqiang has always been the name
I use in my life and in the community.

Thanks
Zqiang

> 
> -- 
> 
> pw-bot: cr
>
Re: [PATCH] net: usb: Remove duplicate assignments for net->pcpu_stat_type
Posted by Simon Horman 2 months, 3 weeks ago
On Wed, Jul 16, 2025 at 08:15:24AM +0800, Zqiang wrote:
> This commit remove duplicate assignments for net->pcpu_stat_type
> in usbnet_probe().
> 
> Signed-off-by: Zqiang <qiang.zhang@linux.dev>

This one looks good, thanks.

Reviewed-by: Simon Horman <horms@kernel.org>