[PATCH v2 3/3] NFSD: Minor cleanup in layoutcommit decoding

Sergey Bashirov posted 3 patches 2 months, 3 weeks ago
[PATCH v2 3/3] NFSD: Minor cleanup in layoutcommit decoding
Posted by Sergey Bashirov 2 months, 3 weeks ago
Use the appropriate xdr function to decode the lc_newoffset field,
which is a boolean value. See RFC 8881, section 18.42.1.

Signed-off-by: Sergey Bashirov <sergeybashirov@gmail.com>
---
 fs/nfsd/nfs4xdr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index 6479c1e3b7741..ca9e3321b6691 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -1813,7 +1813,7 @@ nfsd4_decode_layoutcommit(struct nfsd4_compoundargs *argp,
 	status = nfsd4_decode_stateid4(argp, &lcp->lc_sid);
 	if (status)
 		return status;
-	if (xdr_stream_decode_u32(argp->xdr, &lcp->lc_newoffset) < 0)
+	if (xdr_stream_decode_bool(argp->xdr, &lcp->lc_newoffset) < 0)
 		return nfserr_bad_xdr;
 	if (lcp->lc_newoffset) {
 		if (xdr_stream_decode_u64(argp->xdr, &lcp->lc_last_wr) < 0)
-- 
2.43.0
Re: [PATCH v2 3/3] NFSD: Minor cleanup in layoutcommit decoding
Posted by Christoph Hellwig 2 months, 3 weeks ago
On Tue, Jul 15, 2025 at 06:32:20PM +0300, Sergey Bashirov wrote:
> Use the appropriate xdr function to decode the lc_newoffset field,
> which is a boolean value. See RFC 8881, section 18.42.1.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>