[PATCH v2] pmdomain: ti: Select PM_GENERIC_DOMAINS

Guillaume La Roque posted 1 patch 2 months, 3 weeks ago
drivers/pmdomain/ti/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v2] pmdomain: ti: Select PM_GENERIC_DOMAINS
Posted by Guillaume La Roque 2 months, 3 weeks ago
Select PM_GENERIC_DOMAINS instead of depending on it to ensure
it is always enabled when TI_SCI_PM_DOMAINS is selected.
Since PM_GENERIC_DOMAINS is an implicit symbol, it can only be enabled
through 'select' and cannot be explicitly enabled in configuration.
This simplifies the dependency chain and prevents build issues

Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
---
Changes in v2:
- update commit message
- fix select rules
- Link to v1: https://lore.kernel.org/r/20250704-depspmdomain-v1-1-ef2710556e62@baylibre.com
---
 drivers/pmdomain/ti/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pmdomain/ti/Kconfig b/drivers/pmdomain/ti/Kconfig
index 67c608bf7ed0..5386b362a7ab 100644
--- a/drivers/pmdomain/ti/Kconfig
+++ b/drivers/pmdomain/ti/Kconfig
@@ -10,7 +10,7 @@ if SOC_TI
 config TI_SCI_PM_DOMAINS
 	tristate "TI SCI PM Domains Driver"
 	depends on TI_SCI_PROTOCOL
-	depends on PM_GENERIC_DOMAINS
+	select PM_GENERIC_DOMAINS if PM
 	help
 	  Generic power domain implementation for TI device implementing
 	  the TI SCI protocol.

---
base-commit: 8d6c58332c7a8ba025fcfa76888b6c37dbce9633
change-id: 20250704-depspmdomain-2c584745dca8

Best regards,
-- 
Guillaume La Roque <glaroque@baylibre.com>
Re: [PATCH v2] pmdomain: ti: Select PM_GENERIC_DOMAINS
Posted by Ulf Hansson 2 months, 3 weeks ago
On Tue, 15 Jul 2025 at 10:50, Guillaume La Roque <glaroque@baylibre.com> wrote:
>
> Select PM_GENERIC_DOMAINS instead of depending on it to ensure
> it is always enabled when TI_SCI_PM_DOMAINS is selected.
> Since PM_GENERIC_DOMAINS is an implicit symbol, it can only be enabled
> through 'select' and cannot be explicitly enabled in configuration.
> This simplifies the dependency chain and prevents build issues
>
> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
> Changes in v2:
> - update commit message
> - fix select rules
> - Link to v1: https://lore.kernel.org/r/20250704-depspmdomain-v1-1-ef2710556e62@baylibre.com
> ---
>  drivers/pmdomain/ti/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pmdomain/ti/Kconfig b/drivers/pmdomain/ti/Kconfig
> index 67c608bf7ed0..5386b362a7ab 100644
> --- a/drivers/pmdomain/ti/Kconfig
> +++ b/drivers/pmdomain/ti/Kconfig
> @@ -10,7 +10,7 @@ if SOC_TI
>  config TI_SCI_PM_DOMAINS
>         tristate "TI SCI PM Domains Driver"
>         depends on TI_SCI_PROTOCOL
> -       depends on PM_GENERIC_DOMAINS
> +       select PM_GENERIC_DOMAINS if PM
>         help
>           Generic power domain implementation for TI device implementing
>           the TI SCI protocol.
>
> ---
> base-commit: 8d6c58332c7a8ba025fcfa76888b6c37dbce9633
> change-id: 20250704-depspmdomain-2c584745dca8
>
> Best regards,
> --
> Guillaume La Roque <glaroque@baylibre.com>
>
Re: [PATCH v2] pmdomain: ti: Select PM_GENERIC_DOMAINS
Posted by Nishanth Menon 2 months, 3 weeks ago
On 10:50-20250715, Guillaume La Roque wrote:
> Select PM_GENERIC_DOMAINS instead of depending on it to ensure
> it is always enabled when TI_SCI_PM_DOMAINS is selected.
> Since PM_GENERIC_DOMAINS is an implicit symbol, it can only be enabled
> through 'select' and cannot be explicitly enabled in configuration.
> This simplifies the dependency chain and prevents build issues
> 
> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
> ---
> Changes in v2:
> - update commit message
> - fix select rules
> - Link to v1: https://lore.kernel.org/r/20250704-depspmdomain-v1-1-ef2710556e62@baylibre.com
> ---
>  drivers/pmdomain/ti/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pmdomain/ti/Kconfig b/drivers/pmdomain/ti/Kconfig
> index 67c608bf7ed0..5386b362a7ab 100644
> --- a/drivers/pmdomain/ti/Kconfig
> +++ b/drivers/pmdomain/ti/Kconfig
> @@ -10,7 +10,7 @@ if SOC_TI
>  config TI_SCI_PM_DOMAINS
>  	tristate "TI SCI PM Domains Driver"
>  	depends on TI_SCI_PROTOCOL
> -	depends on PM_GENERIC_DOMAINS
> +	select PM_GENERIC_DOMAINS if PM
>  	help
>  	  Generic power domain implementation for TI device implementing
>  	  the TI SCI protocol.
> 
> ---
> base-commit: 8d6c58332c7a8ba025fcfa76888b6c37dbce9633
> change-id: 20250704-depspmdomain-2c584745dca8
> 
> Best regards,
> -- 
> Guillaume La Roque <glaroque@baylibre.com>
> 


Reviewed-by: Nishanth Menon <nm@ti.com>

Ulf, I am hoping we can queue this up for 6.17, I know it has been a bit
late :(

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
https://ti.com/opensource