[v2] can: Kconfig: add missing COMPILE_TEST

[PATCH v2 0/3] can: Kconfig: add missing COMPILE_TEST

Posted by Vincent Mailhol 2 months, 3 weeks ago

The ti_hecc and tscan1 CAN drivers can not be built on an x86_64
platform. Add the COMPILE_TEST dependency to allow build testing.

Doing that, a so far unnoticed W=0 warning showed up in ti_hecc. Fix
this warning. To prevent any potential noise in some future git
bisect, the warning is fixed before introducing COMPILE_TEST.

Note that the mscan and mpc5xxx drivers have the same issue but those
two use some helper functions, such as in_8() and out_8(), which are
only available on the powerpc platform. Those two drivers would
require some deeper code refactor to be built on x86_64 and are thus
left out of scope.

Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
---
Changes in v2:
- Add HAS_IOPORT to tscan1's build depedencies

---
Vincent Mailhol (3):
      can: ti_hecc: fix -Woverflow compiler warning
      can: ti_hecc: Kconfig: add COMPILE_TEST
      can: tscan1: Kconfig: add COMPILE_TEST

 drivers/net/can/Kconfig         | 2 +-
 drivers/net/can/sja1000/Kconfig | 2 +-
 drivers/net/can/ti_hecc.c       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
---
base-commit: 55e8757c696210292cfda6f1464991d6f5c4300f
change-id: 20250713-can-compile-test-933d513473a1

Best regards,
-- 
Vincent Mailhol <mailhol.vincent@wanadoo.fr>

Re: [PATCH v2 0/3] can: Kconfig: add missing COMPILE_TEST

Posted by Marc Kleine-Budde 2 months, 3 weeks ago

On 15.07.2025 20:28:10, Vincent Mailhol wrote:
> The ti_hecc and tscan1 CAN drivers can not be built on an x86_64
> platform. Add the COMPILE_TEST dependency to allow build testing.
> 
> Doing that, a so far unnoticed W=0 warning showed up in ti_hecc. Fix
> this warning. To prevent any potential noise in some future git
> bisect, the warning is fixed before introducing COMPILE_TEST.
> 
> Note that the mscan and mpc5xxx drivers have the same issue but those
> two use some helper functions, such as in_8() and out_8(), which are
> only available on the powerpc platform. Those two drivers would
> require some deeper code refactor to be built on x86_64 and are thus
> left out of scope.

Added to linux-can-next.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |