[v1] arm64: dts: socfpga: enable ethernet support for Agilex5

[PATCH 1/4] dt-bindings: net: altr,socfpga-stmmac: Add compatible string for Agilex5

Posted by Matthew Gerlach 2 months, 3 weeks ago

Add compatible string for the Altera Agilex5 variant of the Synopsys DWC
XGMAC IP version 2.10.

Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
---
 .../devicetree/bindings/net/altr,socfpga-stmmac.yaml     | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
index ec34daff2aa0..6d5c31c891de 100644
--- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
+++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
@@ -11,8 +11,8 @@ maintainers:
 
 description:
   This binding describes the Altera SOCFPGA SoC implementation of the
-  Synopsys DWMAC for the Cyclone5, Arria5, Stratix10, and Agilex7 families
-  of chips.
+  Synopsys DWMAC for the Cyclone5, Arria5, Stratix10, Agilex5 and Agilex7
+  families of chips.
   # TODO: Determine how to handle the Arria10 reset-name, stmmaceth-ocp, that
   # does not validate against net/snps,dwmac.yaml.
 
@@ -23,6 +23,7 @@ select:
         enum:
           - altr,socfpga-stmmac
           - altr,socfpga-stmmac-a10-s10
+          - altr,socfpga-stmmac-agilex5
 
   required:
     - compatible
@@ -42,6 +43,10 @@ properties:
           - const: altr,socfpga-stmmac-a10-s10
           - const: snps,dwmac-3.74a
           - const: snps,dwmac
+      - items:
+          - const: altr,socfpga-stmmac-agilex5
+          - const: snps,dwxgmac-2.10
+          - const: snps,dwxgmac
 
   clocks:
     minItems: 1
-- 
2.49.0

Re: [PATCH 1/4] dt-bindings: net: altr,socfpga-stmmac: Add compatible string for Agilex5

Posted by Rob Herring 2 months, 3 weeks ago

On Mon, Jul 14, 2025 at 08:25:25AM -0700, Matthew Gerlach wrote:
> Add compatible string for the Altera Agilex5 variant of the Synopsys DWC
> XGMAC IP version 2.10.
> 
> Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
> ---
>  .../devicetree/bindings/net/altr,socfpga-stmmac.yaml     | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> index ec34daff2aa0..6d5c31c891de 100644
> --- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> +++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> @@ -11,8 +11,8 @@ maintainers:
>  
>  description:
>    This binding describes the Altera SOCFPGA SoC implementation of the
> -  Synopsys DWMAC for the Cyclone5, Arria5, Stratix10, and Agilex7 families
> -  of chips.
> +  Synopsys DWMAC for the Cyclone5, Arria5, Stratix10, Agilex5 and Agilex7
> +  families of chips.
>    # TODO: Determine how to handle the Arria10 reset-name, stmmaceth-ocp, that
>    # does not validate against net/snps,dwmac.yaml.
>  
> @@ -23,6 +23,7 @@ select:
>          enum:
>            - altr,socfpga-stmmac
>            - altr,socfpga-stmmac-a10-s10
> +          - altr,socfpga-stmmac-agilex5
>  
>    required:
>      - compatible
> @@ -42,6 +43,10 @@ properties:
>            - const: altr,socfpga-stmmac-a10-s10
>            - const: snps,dwmac-3.74a
>            - const: snps,dwmac
> +      - items:
> +          - const: altr,socfpga-stmmac-agilex5

> +          - const: snps,dwxgmac-2.10
> +          - const: snps,dwxgmac

Is the distinction here useful? I doubt it, so I'd just drop the last 
one. Generally, we've moved away from any generic compatible for 
licensed IP like this because there's *always* some SoC specific 
difference. 

Rob

Re: [PATCH 1/4] dt-bindings: net: altr,socfpga-stmmac: Add compatible string for Agilex5

Posted by Matthew Gerlach 2 months, 3 weeks ago


On 7/14/25 8:57 PM, Rob Herring wrote:
> On Mon, Jul 14, 2025 at 08:25:25AM -0700, Matthew Gerlach wrote:
> > Add compatible string for the Altera Agilex5 variant of the Synopsys DWC
> > XGMAC IP version 2.10.
> > 
> > Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
> > ---
> >  .../devicetree/bindings/net/altr,socfpga-stmmac.yaml     | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> > index ec34daff2aa0..6d5c31c891de 100644
> > --- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> > @@ -11,8 +11,8 @@ maintainers:
> >  
> >  description:
> >    This binding describes the Altera SOCFPGA SoC implementation of the
> > -  Synopsys DWMAC for the Cyclone5, Arria5, Stratix10, and Agilex7 families
> > -  of chips.
> > +  Synopsys DWMAC for the Cyclone5, Arria5, Stratix10, Agilex5 and Agilex7
> > +  families of chips.
> >    # TODO: Determine how to handle the Arria10 reset-name, stmmaceth-ocp, that
> >    # does not validate against net/snps,dwmac.yaml.
> >  
> > @@ -23,6 +23,7 @@ select:
> >          enum:
> >            - altr,socfpga-stmmac
> >            - altr,socfpga-stmmac-a10-s10
> > +          - altr,socfpga-stmmac-agilex5
> >  
> >    required:
> >      - compatible
> > @@ -42,6 +43,10 @@ properties:
> >            - const: altr,socfpga-stmmac-a10-s10
> >            - const: snps,dwmac-3.74a
> >            - const: snps,dwmac
> > +      - items:
> > +          - const: altr,socfpga-stmmac-agilex5
>
> > +          - const: snps,dwxgmac-2.10
> > +          - const: snps,dwxgmac
>
> Is the distinction here useful? I doubt it, so I'd just drop the last
> one. Generally, we've moved away from any generic compatible for
> licensed IP like this because there's *always* some SoC specific
> difference.
>
> Rob

I will drop the '- const: snps, dwxgmac' in v2 and just list the following:

> +      - items:
> +          - const: altr,socfpga-stmmac-agilex5
> +          - const: snps,dwxgmac-2.10


Thanks for the feedback,
Matthew Gerlach