[v1] staging: atomisp: isp: fix open brace on new line

[PATCH] staging: atomisp: isp: fix open brace on new line

Posted by Martin Weidenauer 6 months, 4 weeks ago

	Fix checkpatch error "ERROR: that open brace { should be on the previous line"
	in ia_css_dvs.host.c:277.

	Signed-off-by: Martin Weidenauer <martin@weidenauer.cc>

	---

	Hey, this is my first patch, I appreciate any feedback. Greetings from DebConf25!
---
 .../atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c      | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c
index 30c84639d7e8..7fda12d3a646 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c
@@ -274,8 +274,7 @@ store_dvs_6axis_config(
 					       binary,
 					       dvs_in_frame_info);
 
-	if (!me)
-	{
+	if (!me) {
 		IA_CSS_LEAVE_ERR_PRIVATE(-ENOMEM);
 		return -ENOMEM;
 	}
-- 
2.39.5

Re: [PATCH] staging: atomisp: isp: fix open brace on new line

Posted by Greg KH 6 months, 4 weeks ago

On Mon, Jul 14, 2025 at 03:19:53PM +0200, Martin Weidenauer wrote:
> 	Fix checkpatch error "ERROR: that open brace { should be on the previous line"
> 	in ia_css_dvs.host.c:277.
> 
> 	Signed-off-by: Martin Weidenauer <martin@weidenauer.cc>
> 
> 	---
> 
> 	Hey, this is my first patch, I appreciate any feedback. Greetings from DebConf25!

Odd indentation, how did that happen?

thanks,

greg k-h

Re: [PATCH] staging: atomisp: isp: fix open brace on new line

Posted by Martin Weidenauer 6 months, 4 weeks ago

If you mean the indentation in the file, I think it's unfortunately just a messy driver in general.
I mean I could fix it in another commit in general if you want.

Be well,
Martin

On 14 July 2025 15:24:57 CEST, Greg KH <gregkh@linuxfoundation.org> wrote:
>On Mon, Jul 14, 2025 at 03:19:53PM +0200, Martin Weidenauer wrote:
>> 	Fix checkpatch error "ERROR: that open brace { should be on the previous line"
>> 	in ia_css_dvs.host.c:277.
>> 
>> 	Signed-off-by: Martin Weidenauer <martin@weidenauer.cc>
>> 
>> 	---
>> 
>> 	Hey, this is my first patch, I appreciate any feedback. Greetings from DebConf25!
>
>Odd indentation, how did that happen?
>
>thanks,
>
>greg k-h

Re: [PATCH] staging: atomisp: isp: fix open brace on new line

Posted by Andy Shevchenko 6 months, 4 weeks ago

On Mon, Jul 14, 2025 at 4:51 PM Martin Weidenauer <martin@weidenauer.cc> wrote:
>
> If you mean the indentation in the file, I think it's unfortunately just a messy driver in general.
> I mean I could fix it in another commit in general if you want.

Do not top-post!

The question was about the patch that may not be applied due to wrong
indentation.

> On 14 July 2025 15:24:57 CEST, Greg KH <gregkh@linuxfoundation.org> wrote:
> >On Mon, Jul 14, 2025 at 03:19:53PM +0200, Martin Weidenauer wrote:
> >>      Fix checkpatch error "ERROR: that open brace { should be on the previous line"
> >>      in ia_css_dvs.host.c:277.
> >>
> >>      Signed-off-by: Martin Weidenauer <martin@weidenauer.cc>
> >>
> >>      ---
> >>
> >>      Hey, this is my first patch, I appreciate any feedback. Greetings from DebConf25!
> >
> >Odd indentation, how did that happen?



-- 
With Best Regards,
Andy Shevchenko