1. Patchew
  2. linux
  3. View series

[PATCH v2] block: floppy: Fix uninitialized use of outparam

Purva Yeshi posted 1 patch 2 months, 3 weeks ago 
drivers/block/floppy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v2] block: floppy: Fix uninitialized use of outparam
Posted by Purva Yeshi 2 months, 3 weeks ago 
Fix Smatch-detected error:
drivers/block/floppy.c:3569 fd_locked_ioctl() error:
uninitialized symbol 'outparam'.

Smatch may incorrectly warn about uninitialized use of 'outparam'
in fd_locked_ioctl(), even though all _IOC_READ commands guarantee
its initialization. Initialize outparam to NULL to make this explicit
and suppress the false positive.

Signed-off-by: Purva Yeshi <purvayeshi550@gmail.com>
---
V1 - https://lore.kernel.org/all/7dd94691-0b37-4855-be43-661f954275c8@gmail.com/T/#t
V2 - Initialize outparam to NULL to suppress Smatch false positive.

 drivers/block/floppy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index e97432032f01..24be0c2c4075 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -3411,7 +3411,7 @@ static int fd_locked_ioctl(struct block_device *bdev, blk_mode_t mode,
 		struct floppy_max_errors max_errors;
 		struct floppy_drive_params dp;
 	} inparam;		/* parameters coming from user space */
-	const void *outparam;	/* parameters passed back to user space */
+	const void *outparam = NULL;	/* parameters passed back to user space */
 
 	/* convert compatibility eject ioctls into floppy eject ioctl.
 	 * We do this in order to provide a means to eject floppy disks before
-- 
2.34.1
Re: [PATCH v2] block: floppy: Fix uninitialized use of outparam
Posted by Jens Axboe 2 months, 3 weeks ago 
On Sun, 13 Jul 2025 12:30:20 +0530, Purva Yeshi wrote:
> Fix Smatch-detected error:
> drivers/block/floppy.c:3569 fd_locked_ioctl() error:
> uninitialized symbol 'outparam'.
> 
> Smatch may incorrectly warn about uninitialized use of 'outparam'
> in fd_locked_ioctl(), even though all _IOC_READ commands guarantee
> its initialization. Initialize outparam to NULL to make this explicit
> and suppress the false positive.
> 
> [...]

Applied, thanks!

[1/1] block: floppy: Fix uninitialized use of outparam
      commit: cb1bdf0797acd79c53a899f72a06ab8c1ebc5bcb

Best regards,
-- 
Jens Axboe
Re: [PATCH v2] block: floppy: Fix uninitialized use of outparam
Posted by Purva Yeshi 2 months, 3 weeks ago 
On 13/07/25 23:38, Jens Axboe wrote:
> 
> On Sun, 13 Jul 2025 12:30:20 +0530, Purva Yeshi wrote:
>> Fix Smatch-detected error:
>> drivers/block/floppy.c:3569 fd_locked_ioctl() error:
>> uninitialized symbol 'outparam'.
>>
>> Smatch may incorrectly warn about uninitialized use of 'outparam'
>> in fd_locked_ioctl(), even though all _IOC_READ commands guarantee
>> its initialization. Initialize outparam to NULL to make this explicit
>> and suppress the false positive.
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/1] block: floppy: Fix uninitialized use of outparam
>        commit: cb1bdf0797acd79c53a899f72a06ab8c1ebc5bcb
> 
> Best regards,

Hi Jens,

Thank you for applying the patch.

Best regards,
Purva Yeshi
Re: [PATCH v2] block: floppy: Fix uninitialized use of outparam
Posted by Denis Efremov 2 months, 3 weeks ago 

On 13/07/2025 11:00, Purva Yeshi wrote:
> Fix Smatch-detected error:
> drivers/block/floppy.c:3569 fd_locked_ioctl() error:
> uninitialized symbol 'outparam'.
> 
> Smatch may incorrectly warn about uninitialized use of 'outparam'
> in fd_locked_ioctl(), even though all _IOC_READ commands guarantee
> its initialization. Initialize outparam to NULL to make this explicit
> and suppress the false positive.
> 
> Signed-off-by: Purva Yeshi <purvayeshi550@gmail.com>
> ---
> V1 - https://lore.kernel.org/all/7dd94691-0b37-4855-be43-661f954275c8@gmail.com/T/#t
> V2 - Initialize outparam to NULL to suppress Smatch false positive.
> 
>  drivers/block/floppy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
> index e97432032f01..24be0c2c4075 100644
> --- a/drivers/block/floppy.c
> +++ b/drivers/block/floppy.c
> @@ -3411,7 +3411,7 @@ static int fd_locked_ioctl(struct block_device *bdev, blk_mode_t mode,
>  		struct floppy_max_errors max_errors;
>  		struct floppy_drive_params dp;
>  	} inparam;		/* parameters coming from user space */
> -	const void *outparam;	/* parameters passed back to user space */
> +	const void *outparam = NULL;	/* parameters passed back to user space */
>  
>  	/* convert compatibility eject ioctls into floppy eject ioctl.
>  	 * We do this in order to provide a means to eject floppy disks before

Reviewed-by: Denis Efremov <efremov@linux.com>

Denis
Re: [PATCH v2] block: floppy: Fix uninitialized use of outparam
Posted by Purva Yeshi 2 months, 3 weeks ago 
On 13/07/25 14:17, Denis Efremov wrote:
> 
> 
> On 13/07/2025 11:00, Purva Yeshi wrote:
>> Fix Smatch-detected error:
>> drivers/block/floppy.c:3569 fd_locked_ioctl() error:
>> uninitialized symbol 'outparam'.
>>
>> Smatch may incorrectly warn about uninitialized use of 'outparam'
>> in fd_locked_ioctl(), even though all _IOC_READ commands guarantee
>> its initialization. Initialize outparam to NULL to make this explicit
>> and suppress the false positive.
>>
>> Signed-off-by: Purva Yeshi <purvayeshi550@gmail.com>
>> ---
>> V1 - https://lore.kernel.org/all/7dd94691-0b37-4855-be43-661f954275c8@gmail.com/T/#t
>> V2 - Initialize outparam to NULL to suppress Smatch false positive.
>>
>>   drivers/block/floppy.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
>> index e97432032f01..24be0c2c4075 100644
>> --- a/drivers/block/floppy.c
>> +++ b/drivers/block/floppy.c
>> @@ -3411,7 +3411,7 @@ static int fd_locked_ioctl(struct block_device *bdev, blk_mode_t mode,
>>   		struct floppy_max_errors max_errors;
>>   		struct floppy_drive_params dp;
>>   	} inparam;		/* parameters coming from user space */
>> -	const void *outparam;	/* parameters passed back to user space */
>> +	const void *outparam = NULL;	/* parameters passed back to user space */
>>   
>>   	/* convert compatibility eject ioctls into floppy eject ioctl.
>>   	 * We do this in order to provide a means to eject floppy disks before
> 
> Reviewed-by: Denis Efremov <efremov@linux.com>
> 
> Denis

Hi,

Thank you for the review and for adding your Reviewed-by tag.

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.