Continuing the cleanup work that is being done on the AtomIsp driver,
This series:

- Process the error inside hmm_init().
- Unifies the HMM init tracking method.
- move hmm related function to hmm.c.

Previously, These patches were sent individualy but they build on
each other so i resent them as one patch series

Suggested-by: Hans de Goede <hansg@kernel.org>
Signed-off-by: Abdelrahman Fekry <abdelrahmanfekry375@gmail.com>
Abdelrahman Fekry (3):
  staging: media: atomisp: return early on hmm_bo_device_init() failure
  staging: media: atomisp: unify HMM initialization tracking
  staging: media: atomisp: move hmm_get_mmu_base_addr()

 .../staging/media/atomisp/include/hmm/hmm.h   |  4 +--
 .../media/atomisp/include/hmm/hmm_bo.h        | 11 ++-----
 .../media/atomisp/pci/atomisp_compat_css20.c  | 12 -------
 drivers/staging/media/atomisp/pci/hmm/hmm.c   | 31 ++++++++++---------
 .../staging/media/atomisp/pci/hmm/hmm_bo.c    | 17 ++++------
 5 files changed, 27 insertions(+), 48 deletions(-)

-- 
2.25.1

On Sat, Jul 12, 2025 at 10:13:22PM +0300, Abdelrahman Fekry wrote:
> Continuing the cleanup work that is being done on the AtomIsp driver,
> This series:
> 
> - Process the error inside hmm_init().
> - Unifies the HMM init tracking method.
> - move hmm related function to hmm.c.
> 
> Previously, These patches were sent individualy but they build on
> each other so i resent them as one patch series
> 
> Suggested-by: Hans de Goede <hansg@kernel.org>
> Signed-off-by: Abdelrahman Fekry <abdelrahmanfekry375@gmail.com>

These seem reasonable enough to me.

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

But it would be better if someone could test them as well.

regards,
dan carpenter

Hi Dan,
Thanks for your feedback

On Wed, Jul 16, 2025 at 9:21 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> On Sat, Jul 12, 2025 at 10:13:22PM +0300, Abdelrahman Fekry wrote:
> > Continuing the cleanup work that is being done on the AtomIsp driver,
> > This series:
> >
> > - Process the error inside hmm_init().
> > - Unifies the HMM init tracking method.
> > - move hmm related function to hmm.c.
> >
> > Previously, These patches were sent individualy but they build on
> > each other so i resent them as one patch series
> >
> > Suggested-by: Hans de Goede <hansg@kernel.org>
> > Signed-off-by: Abdelrahman Fekry <abdelrahmanfekry375@gmail.com>
>
> These seem reasonable enough to me.
>
> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
>
> But it would be better if someone could test them as well.
I tested this by building the driver and i really don't think further
testing is needed
since this series doesn't introduce any behavioral or functional change.
>
> regards,
> dan carpenter

Best Regards,
Abdelrahman Fekry

Hi Maintainers,
I'm just bringing attention to this patch series as I have a lot of
other patches that build on it .
Thank you!

On Thu, Jul 17, 2025 at 4:35 AM Abdelrahman Fekry
<abdelrahmanfekry375@gmail.com> wrote:
>
> Hi Dan,
> Thanks for your feedback
>
> On Wed, Jul 16, 2025 at 9:21 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
> >
> > On Sat, Jul 12, 2025 at 10:13:22PM +0300, Abdelrahman Fekry wrote:
> > > Continuing the cleanup work that is being done on the AtomIsp driver,
> > > This series:
> > >
> > > - Process the error inside hmm_init().
> > > - Unifies the HMM init tracking method.
> > > - move hmm related function to hmm.c.
> > >
> > > Previously, These patches were sent individualy but they build on
> > > each other so i resent them as one patch series
> > >
> > > Suggested-by: Hans de Goede <hansg@kernel.org>
> > > Signed-off-by: Abdelrahman Fekry <abdelrahmanfekry375@gmail.com>
> >
> > These seem reasonable enough to me.
> >
> > Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
> >
> > But it would be better if someone could test them as well.
> I tested this by building the driver and i really don't think further
> testing is needed
> since this series doesn't introduce any behavioral or functional change.
> >
> > regards,
> > dan carpenter
>
> Best Regards,
> Abdelrahman Fekry

On Thu, Jul 31, 2025 at 06:24:09AM +0300, Abdelrahman Fekry wrote:
> Hi Maintainers,
> I'm just bringing attention to this patch series as I have a lot of
> other patches that build on it .

It is the middle of the merge window.  Please wait for -rc1 to be
released, there is no rush.

thanks,

greg k-h

On Thu, Jul 31, 2025 at 7:35 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Jul 31, 2025 at 06:24:09AM +0300, Abdelrahman Fekry wrote:
> > Hi Maintainers,
> > I'm just bringing attention to this patch series as I have a lot of
> > other patches that build on it .
>
> It is the middle of the merge window.  Please wait for -rc1 to be
> released, there is no rush.
noted, thank you!
>
> thanks,
>
> greg k-h