hwmon: max31827: use sysfs_emit() in temp1_resolution_show()

[PATCH] hwmon: max31827: use sysfs_emit() in temp1_resolution_show()

Posted by Khaled Elnaggar 2 months, 3 weeks ago

Replace scnprintf() with sysfs_emit() in temp1_resolution_show(),
as recommended in Documentation/filesystems/sysfs.rst: show() callbacks
should use sysfs_emit() or sysfs_emit_at() to format values returned to
userspace.

Signed-off-by: Khaled Elnaggar <khaledelnaggarlinux@gmail.com>
---
 drivers/hwmon/max31827.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/max31827.c b/drivers/hwmon/max31827.c
index 48e8f8ba4d05..c423cabcb28b 100644
--- a/drivers/hwmon/max31827.c
+++ b/drivers/hwmon/max31827.c
@@ -445,7 +445,7 @@ static ssize_t temp1_resolution_show(struct device *dev,

 	val = FIELD_GET(MAX31827_CONFIGURATION_RESOLUTION_MASK, val);

-	return scnprintf(buf, PAGE_SIZE, "%u\n", max31827_resolutions[val]);
+	return sysfs_emit(buf, "%u\n", max31827_resolutions[val]);
 }

 static ssize_t temp1_resolution_store(struct device *dev,
--
2.47.2

Re: [PATCH] hwmon: max31827: use sysfs_emit() in temp1_resolution_show()

Posted by Guenter Roeck 2 months, 3 weeks ago

On Sat, Jul 12, 2025 at 04:14:46PM +0300, Khaled Elnaggar wrote:
> Replace scnprintf() with sysfs_emit() in temp1_resolution_show(),
> as recommended in Documentation/filesystems/sysfs.rst: show() callbacks
> should use sysfs_emit() or sysfs_emit_at() to format values returned to
> userspace.
> 
> Signed-off-by: Khaled Elnaggar <khaledelnaggarlinux@gmail.com>

Applied.

Thanks,
Guenter