ACPI: RISC-V: Remove unnecessary CPPC debug message

[PATCH] ACPI: RISC-V: Remove unnecessary CPPC debug message

Posted by Sunil V L 2 months, 3 weeks ago

The presence or absence of the CPPC SBI extension is currently logged
on every boot. This message is not particularly useful and can clutter
the boot log. Remove this debug message to reduce noise during boot.

This change has no functional impact.

Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
---
 drivers/acpi/riscv/cppc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/acpi/riscv/cppc.c b/drivers/acpi/riscv/cppc.c
index 4cdff387deff..440cf9fb91aa 100644
--- a/drivers/acpi/riscv/cppc.c
+++ b/drivers/acpi/riscv/cppc.c
@@ -37,10 +37,8 @@ static int __init sbi_cppc_init(void)
 {
 	if (sbi_spec_version >= sbi_mk_version(2, 0) &&
 	    sbi_probe_extension(SBI_EXT_CPPC) > 0) {
-		pr_info("SBI CPPC extension detected\n");
 		cppc_ext_present = true;
 	} else {
-		pr_info("SBI CPPC extension NOT detected!!\n");
 		cppc_ext_present = false;
 	}
 
-- 
2.43.0

Re: [PATCH] ACPI: RISC-V: Remove unnecessary CPPC debug message

Posted by Drew Fustini 2 months, 3 weeks ago

On Fri, Jul 11, 2025 at 07:30:13PM +0530, Sunil V L wrote:
> The presence or absence of the CPPC SBI extension is currently logged
> on every boot. This message is not particularly useful and can clutter
> the boot log. Remove this debug message to reduce noise during boot.
> 
> This change has no functional impact.
> 
> Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>

Thanks, I'm pleased to no longer see the "NOT dectected!!" when testing
defconfig on systems which don't have the CPPC extension.

Tested-by: Drew Fustini <fustini@kernel.org>

Re: [PATCH] ACPI: RISC-V: Remove unnecessary CPPC debug message

Posted by Anup Patel 2 months, 3 weeks ago

On Fri, Jul 11, 2025 at 7:30 PM Sunil V L <sunilvl@ventanamicro.com> wrote:
>
> The presence or absence of the CPPC SBI extension is currently logged
> on every boot. This message is not particularly useful and can clutter
> the boot log. Remove this debug message to reduce noise during boot.
>
> This change has no functional impact.
>
> Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>

LGTM.

Reviewed-by: Anup Patel <anup@brainfault.org>

Regards,
Anup

> ---
>  drivers/acpi/riscv/cppc.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/acpi/riscv/cppc.c b/drivers/acpi/riscv/cppc.c
> index 4cdff387deff..440cf9fb91aa 100644
> --- a/drivers/acpi/riscv/cppc.c
> +++ b/drivers/acpi/riscv/cppc.c
> @@ -37,10 +37,8 @@ static int __init sbi_cppc_init(void)
>  {
>         if (sbi_spec_version >= sbi_mk_version(2, 0) &&
>             sbi_probe_extension(SBI_EXT_CPPC) > 0) {
> -               pr_info("SBI CPPC extension detected\n");
>                 cppc_ext_present = true;
>         } else {
> -               pr_info("SBI CPPC extension NOT detected!!\n");
>                 cppc_ext_present = false;
>         }
>
> --
> 2.43.0
>
>