While targeting the compilation issue due to dangling variable,
I have noticed more opportunities for refactoring that helps to
avoid above mentioned compilation issue and make code cleaner in
general. Please, give it a try.

I put a revert as the first patch of the previous solution, but I believe
the previous solution may be pulled out without a problem.

Andy Shevchenko (7):
  Revert "panic: fix compilation error (`make W=1`)"
  panic: sys_info: Align constant definition names with parameters
  panic: sys_info: Capture si_bits_global before iterating over it
  panic: sys_info: Replace struct sys_info_name with plain array of
    strings
  panic: sys_info: Fix compilation error (`make W=1`)
  panic: sys_info: Deduplicate local variable 'table; assignments
  panic: sys_info: Factor out read and write handlers

 include/linux/sys_info.h |   2 +-
 kernel/panic.c           |   2 +-
 lib/sys_info.c           | 129 ++++++++++++++++++++++-----------------
 3 files changed, 74 insertions(+), 59 deletions(-)

-- 
2.47.2

On Fri, Jul 11, 2025 at 12:51:06PM +0300, Andy Shevchenko wrote:
> While targeting the compilation issue due to dangling variable,
> I have noticed more opportunities for refactoring that helps to
> avoid above mentioned compilation issue and make code cleaner in
> general. Please, give it a try.
> 
> I put a revert as the first patch of the previous solution, but I believe
> the previous solution may be pulled out without a problem.

Btw, I can try to pop the fix upper in the series, but since this
whole feature was only a few days old, I propose to drop it completely
for now and start again. Please, Cc me for the review.

-- 
With Best Regards,
Andy Shevchenko

On Fri, Jul 11, 2025 at 03:13:09PM +0300, Andy Shevchenko wrote:
> On Fri, Jul 11, 2025 at 12:51:06PM +0300, Andy Shevchenko wrote:
> > While targeting the compilation issue due to dangling variable,
> > I have noticed more opportunities for refactoring that helps to
> > avoid above mentioned compilation issue and make code cleaner in
> > general. Please, give it a try.
> > 
> > I put a revert as the first patch of the previous solution, but I believe
> > the previous solution may be pulled out without a problem.
> 
> Btw, I can try to pop the fix upper in the series, but since this
> whole feature was only a few days old, I propose to drop it completely
> for now and start again. Please, Cc me for the review.

Can we just take your fix and nice cleanups? Do we really need to drop
the whole series? My gcc haven't raised warnings in the past several
versions, and I will install clang for more complete compiling test
beside functional test for future patches.

Anyway I don't think it has fundamental blocking issue, but I'm fine
if you insist to do so.

Thanks,
Feng

> -- 
> With Best Regards,
> Andy Shevchenko
>

On Fri, Jul 11, 2025 at 11:42:13PM +0800, Feng Tang wrote:
> On Fri, Jul 11, 2025 at 03:13:09PM +0300, Andy Shevchenko wrote:
> > On Fri, Jul 11, 2025 at 12:51:06PM +0300, Andy Shevchenko wrote:
> > > While targeting the compilation issue due to dangling variable,
> > > I have noticed more opportunities for refactoring that helps to
> > > avoid above mentioned compilation issue and make code cleaner in
> > > general. Please, give it a try.
> > > 
> > > I put a revert as the first patch of the previous solution, but I believe
> > > the previous solution may be pulled out without a problem.
> > 
> > Btw, I can try to pop the fix upper in the series, but since this
> > whole feature was only a few days old, I propose to drop it completely
> > for now and start again. Please, Cc me for the review.
> 
> Can we just take your fix and nice cleanups? Do we really need to drop
> the whole series? My gcc haven't raised warnings in the past several
> versions, and I will install clang for more complete compiling test
> beside functional test for future patches.

> Anyway I don't think it has fundamental blocking issue, but I'm fine
> if you insist to do so.

Let's hear Andrew who took the series in the first place. As he says
I will follow. But personally I prefer to drop the whole set and start
from the scratch.

-- 
With Best Regards,
Andy Shevchenko