Remote etm binding change was merged to fix the dt warning. Driver
changes were not merged at that time. qcom,qmi-instance-id is
required for remote etm driver to find the remote subsystem connection.
It is the instance id used by qmi to communicate with remote processor.

Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
---
 .../bindings/arm/qcom,coresight-remote-etm.yaml          | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml
index 4fd5752978cd..bd78f6bc2fdf 100644
--- a/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml
@@ -20,6 +20,12 @@ properties:
   compatible:
     const: qcom,coresight-remote-etm
 
+  qcom,qmi-instance-id:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Each remote processor has a unique instance id to establish the
+      QMI connection.
+
   out-ports:
     $ref: /schemas/graph.yaml#/properties/ports
     additionalProperties: false
@@ -32,6 +38,7 @@ properties:
 required:
   - compatible
   - out-ports
+  - qcom,qmi-instance-id
 
 additionalProperties: false
 
@@ -40,6 +47,8 @@ examples:
     etm {
         compatible = "qcom,coresight-remote-etm";
 
+        qcom,qmi-instance-id = <2>;
+
         out-ports {
             port {
                 modem_etm0_out_funnel_modem: endpoint {
-- 
2.25.1

On Fri, Jul 11, 2025 at 02:40:29AM -0700, Mao Jinlong wrote:
> Remote etm binding change was merged to fix the dt warning. Driver
> changes were not merged at that time. qcom,qmi-instance-id is
> required for remote etm driver to find the remote subsystem connection.

Again, driver... 


> It is the instance id used by qmi to communicate with remote processor.
> 
> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
> ---
>  .../bindings/arm/qcom,coresight-remote-etm.yaml          | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml
> index 4fd5752978cd..bd78f6bc2fdf 100644
> --- a/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml
> @@ -20,6 +20,12 @@ properties:
>    compatible:
>      const: qcom,coresight-remote-etm
>  
> +  qcom,qmi-instance-id:

Don't come with another, 20th property for your remote proc
architecture. Use existing properties.

This pattern in qcom is extremely confusing - similar thing for remote
proc called 20 different ways, just because in downstream you have 20
different drivers.

NAK

Come with unified schema for existing and future properties like that.
Assuming this is NOT FOR DRIVER in the first place.

Best regards,
Krzysztof