[PATCH v2 1/2] dt-bindings: input: goodix,gt9916: Document stylus support

Pengyu Luo posted 2 patches 2 months, 4 weeks ago
[PATCH v2 1/2] dt-bindings: input: goodix,gt9916: Document stylus support
Posted by Pengyu Luo 2 months, 4 weeks ago
Document stylus support. Optional support for DT properties:
  - `goodix,stylus-enable`
  - `goodix,stylus-pressure-level`
  - `touchscreen-x-mm`
  - `touchscreen-y-mm`

Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com>
---
 .../bindings/input/touchscreen/goodix,gt9916.yaml    | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix,gt9916.yaml b/Documentation/devicetree/bindings/input/touchscreen/goodix,gt9916.yaml
index c40d92b7f..e56d74ae4 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/goodix,gt9916.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/goodix,gt9916.yaml
@@ -43,6 +43,18 @@ properties:
   touchscreen-size-x: true
   touchscreen-size-y: true
   touchscreen-swapped-x-y: true
+  touchscreen-x-mm: true
+  touchscreen-y-mm: true
+
+  goodix,stylus-enable:
+    type: boolean
+
+  goodix,stylus-pressure-level:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Number of discrete pressure levels supported by the stylus.
+      The reported ABS_PRESSURE range will be 0 to
+      (goodix,stylus-pressure-level - 1).
 
 additionalProperties: false
 
-- 
2.50.0
Re: [PATCH v2 1/2] dt-bindings: input: goodix,gt9916: Document stylus support
Posted by Rob Herring (Arm) 2 months, 4 weeks ago
On Thu, 10 Jul 2025 19:57:32 +0800, Pengyu Luo wrote:
> Document stylus support. Optional support for DT properties:
>   - `goodix,stylus-enable`
>   - `goodix,stylus-pressure-level`
>   - `touchscreen-x-mm`
>   - `touchscreen-y-mm`
> 
> Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com>
> ---
>  .../bindings/input/touchscreen/goodix,gt9916.yaml    | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/touchscreen/goodix,gt9916.yaml: properties:goodix,stylus-enable: 'description' is a dependency of 'type'
	hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
	from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250710115733.226670-2-mitltlatltl@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.