This patch-series adds support for the Sitronix ST7567 Controller, which is is a
monochrome Dot Matrix LCD Controller that has SPI, I2C and parallel interfaces.

The st7571-i2c driver only has support for I2C so displays using other transport
interfaces are currently not supported.

The DRM_FORMAT_R1 pixel format and data commands are the same than what is used
by the ST7571 controller, so only is needed a different callback that implements
the expected initialization sequence for the ST7567 chip.

Patch #1 adds a Device Tree binding schema for the ST7567 Controller.

Patch #2 makes the "reset-gpios" property in the driver to be optional since that
isn't needed for the ST7567.

Patch #3 finally extends the st7571-i2c driver to also support the ST7567 device.


Javier Martinez Canillas (3):
  dt-bindings: display: Add Sitronix ST7567 LCD Controller
  drm/sitronix/st7571-i2c: Make the reset GPIO to be optional
  drm/sitronix/st7571-i2c: Add support for the ST7567 Controller

 .../bindings/display/sitronix,st7567.yaml     | 63 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 drivers/gpu/drm/sitronix/st7571-i2c.c         | 55 +++++++++++++++-
 3 files changed, 117 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/display/sitronix,st7567.yaml

-- 
2.49.0

base-commit: 93eacfcdfbb590d9ed6889d381d5a586dd1ac860
branch: drm-st7567

Hello Javier,


On Thu, Jul 10, 2025 at 12:24:32PM +0200, Javier Martinez Canillas wrote:
> This patch-series adds support for the Sitronix ST7567 Controller, which is is a
> monochrome Dot Matrix LCD Controller that has SPI, I2C and parallel interfaces.
> 
> The st7571-i2c driver only has support for I2C so displays using other transport
> interfaces are currently not supported.
> 
> The DRM_FORMAT_R1 pixel format and data commands are the same than what is used
> by the ST7571 controller, so only is needed a different callback that implements
> the expected initialization sequence for the ST7567 chip.
> 
> Patch #1 adds a Device Tree binding schema for the ST7567 Controller.
> 
> Patch #2 makes the "reset-gpios" property in the driver to be optional since that
> isn't needed for the ST7567.
> 
> Patch #3 finally extends the st7571-i2c driver to also support the ST7567 device.
> 
> 
> Javier Martinez Canillas (3):
>   dt-bindings: display: Add Sitronix ST7567 LCD Controller
>   drm/sitronix/st7571-i2c: Make the reset GPIO to be optional
>   drm/sitronix/st7571-i2c: Add support for the ST7567 Controller

For all patches in this series:

Reviewed-by: Marcus Folkesson <marcus.folkesson@gmail.com>

Marcus Folkesson <marcus.folkesson@gmail.com> writes:

Hello Marcus,

> Hello Javier,
>
>
> On Thu, Jul 10, 2025 at 12:24:32PM +0200, Javier Martinez Canillas wrote:
>> This patch-series adds support for the Sitronix ST7567 Controller, which is is a
>> monochrome Dot Matrix LCD Controller that has SPI, I2C and parallel interfaces.
>> 
>> The st7571-i2c driver only has support for I2C so displays using other transport
>> interfaces are currently not supported.
>> 
>> The DRM_FORMAT_R1 pixel format and data commands are the same than what is used
>> by the ST7571 controller, so only is needed a different callback that implements
>> the expected initialization sequence for the ST7567 chip.
>> 
>> Patch #1 adds a Device Tree binding schema for the ST7567 Controller.
>> 
>> Patch #2 makes the "reset-gpios" property in the driver to be optional since that
>> isn't needed for the ST7567.
>> 
>> Patch #3 finally extends the st7571-i2c driver to also support the ST7567 device.
>> 
>> 
>> Javier Martinez Canillas (3):
>>   dt-bindings: display: Add Sitronix ST7567 LCD Controller
>>   drm/sitronix/st7571-i2c: Make the reset GPIO to be optional
>>   drm/sitronix/st7571-i2c: Add support for the ST7567 Controller
>
> For all patches in this series:
>
> Reviewed-by: Marcus Folkesson <marcus.folkesson@gmail.com>

Thanks! I'll merge this patch series next week then, since I also got an
ack from a DT maintainer.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat