[PATCH net-next 1/3] net: fec: use phy_interface_mode_is_rgmii() to check RGMII mode

Wei Fang posted 3 patches 2 months, 4 weeks ago
There is a newer version of this series
[PATCH net-next 1/3] net: fec: use phy_interface_mode_is_rgmii() to check RGMII mode
Posted by Wei Fang 2 months, 4 weeks ago
Use the generic helper function phy_interface_mode_is_rgmii() to check
RGMII mode.

Signed-off-by: Wei Fang <wei.fang@nxp.com>
---
 drivers/net/ethernet/freescale/fec_main.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index d4eed252ad40..f4f1f38d94eb 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -1194,10 +1194,7 @@ fec_restart(struct net_device *ndev)
 		rcntl |= 0x40000000 | 0x00000020;
 
 		/* RGMII, RMII or MII */
-		if (fep->phy_interface == PHY_INTERFACE_MODE_RGMII ||
-		    fep->phy_interface == PHY_INTERFACE_MODE_RGMII_ID ||
-		    fep->phy_interface == PHY_INTERFACE_MODE_RGMII_RXID ||
-		    fep->phy_interface == PHY_INTERFACE_MODE_RGMII_TXID)
+		if (phy_interface_mode_is_rgmii(fep->phy_interface))
 			rcntl |= (1 << 6);
 		else if (fep->phy_interface == PHY_INTERFACE_MODE_RMII)
 			rcntl |= FEC_RCR_RMII;
-- 
2.34.1
Re: [PATCH net-next 1/3] net: fec: use phy_interface_mode_is_rgmii() to check RGMII mode
Posted by Maxime Chevallier 2 months, 4 weeks ago
On Thu, 10 Jul 2025 17:09:00 +0800
Wei Fang <wei.fang@nxp.com> wrote:

> Use the generic helper function phy_interface_mode_is_rgmii() to check
> RGMII mode.
> 
> Signed-off-by: Wei Fang <wei.fang@nxp.com>

Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Maxime