.../devicetree/bindings/rtc/s3c-rtc.yaml | 1 + .../boot/dts/exynos/exynosautov9-sadk.dts | 4 ++++ arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 10 ++++++++++ drivers/rtc/rtc-s3c.c | 18 ++++++++++++++++++ 4 files changed, 33 insertions(+)
Enable on-chip RTC support. The on-chip RTC of this SoC is similar to the previous versions of Samsung SoC. So re-use the existing RTC driver with applicable call-backs for initialization and IRQ handling. Add a separate call-back for disabling RTC since existing '.disable' call-backs updates additional bit not valid for RTC of ExynosAutov9. Setting and getting hardware clock has been tested using 'hwclock' and 'date' utilities. Alarm interrupt has been checked with incrementing interrupt count via "cat /proc/interrupts | grep rtc" for 10sec wakeup time via "echo +10 > /sys/class/rtc/rtc0/wakealarm" changelog --- Changes in v2: - Fixed the review comment of v1 for mis-aligmnent & asymmetry bit logic. - link for v1 : https://lore.kernel.org/linux-rtc/20250702052426.2404256-1-dev.tailor@samsung.com/ Devang Tailor (3): dt-bindings: rtc: s3c-rtc: add compatible for exynosautov9 rtc: s3c: support for exynosautov9 on-chip RTC arm64: dts: exynosautov9: add RTC DT node .../devicetree/bindings/rtc/s3c-rtc.yaml | 1 + .../boot/dts/exynos/exynosautov9-sadk.dts | 4 ++++ arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 10 ++++++++++ drivers/rtc/rtc-s3c.c | 18 ++++++++++++++++++ 4 files changed, 33 insertions(+) base-commit: 58ba80c4740212c29a1cf9b48f588e60a7612209 -- 2.34.1
Hi, > -----Original Message----- > From: Devang Tailor <dev.tailor@samsung.com> > Sent: 10 July 2025 14:05 > To: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; > alim.akhtar@samsung.com; alexandre.belloni@bootlin.com; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > rtc@vger.kernel.org; faraz.ata@samsung.com > Cc: Devang Tailor <dev.tailor@samsung.com> > Subject: [PATCH v2 0/3] On-chip RTC support for ExynosAutov9 > > Enable on-chip RTC support. The on-chip RTC of this SoC is similar to the > previous versions of Samsung SoC. So re-use the existing RTC driver with > applicable call-backs for initialization and IRQ handling. > Add a separate call-back for disabling RTC since existing '.disable' > call-backs updates additional bit not valid for RTC of ExynosAutov9. > > Setting and getting hardware clock has been tested using 'hwclock' > and 'date' utilities. > > Alarm interrupt has been checked with incrementing interrupt count via "cat > /proc/interrupts | grep rtc" for 10sec wakeup time via "echo +10 > > /sys/class/rtc/rtc0/wakealarm" > > changelog > --- > Changes in v2: > - Fixed the review comment of v1 for mis-aligmnent & asymmetry bit logic. > - link for v1 : https://lore.kernel.org/linux-rtc/20250702052426.2404256-1- > dev.tailor@samsung.com/ > Reminder! Can you please help to identify if anything is pending in this patch series ? I see all three patches are reviewed. > > Devang Tailor (3): > dt-bindings: rtc: s3c-rtc: add compatible for exynosautov9 > rtc: s3c: support for exynosautov9 on-chip RTC > arm64: dts: exynosautov9: add RTC DT node > > .../devicetree/bindings/rtc/s3c-rtc.yaml | 1 + > .../boot/dts/exynos/exynosautov9-sadk.dts | 4 ++++ > arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 10 ++++++++++ > drivers/rtc/rtc-s3c.c | 18 ++++++++++++++++++ > 4 files changed, 33 insertions(+) > > > base-commit: 58ba80c4740212c29a1cf9b48f588e60a7612209 > -- > 2.34.1
On 03/09/2025 17:09:32+0530, Devang Tailor wrote: > > Hi, > > > > -----Original Message----- > > From: Devang Tailor <dev.tailor@samsung.com> > > Sent: 10 July 2025 14:05 > > To: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; > > alim.akhtar@samsung.com; alexandre.belloni@bootlin.com; > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > > samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > > rtc@vger.kernel.org; faraz.ata@samsung.com > > Cc: Devang Tailor <dev.tailor@samsung.com> > > Subject: [PATCH v2 0/3] On-chip RTC support for ExynosAutov9 > > > > Enable on-chip RTC support. The on-chip RTC of this SoC is similar to the > > previous versions of Samsung SoC. So re-use the existing RTC driver with > > applicable call-backs for initialization and IRQ handling. > > Add a separate call-back for disabling RTC since existing '.disable' > > call-backs updates additional bit not valid for RTC of ExynosAutov9. > > > > Setting and getting hardware clock has been tested using 'hwclock' > > and 'date' utilities. > > > > Alarm interrupt has been checked with incrementing interrupt count via "cat > > /proc/interrupts | grep rtc" for 10sec wakeup time via "echo +10 > > > /sys/class/rtc/rtc0/wakealarm" > > > > changelog > > --- > > Changes in v2: > > - Fixed the review comment of v1 for mis-aligmnent & asymmetry bit logic. > > - link for v1 : https://lore.kernel.org/linux-rtc/20250702052426.2404256-1- > > dev.tailor@samsung.com/ > > > > Reminder! > Can you please help to identify if anything is pending in this patch series ? I see all three patches are reviewed. > You have actions after those reviews: https://lore.kernel.org/all/20250711-shapeless-adorable-lobster-d2efbf@krzk-bin/ > > > > Devang Tailor (3): > > dt-bindings: rtc: s3c-rtc: add compatible for exynosautov9 > > rtc: s3c: support for exynosautov9 on-chip RTC > > arm64: dts: exynosautov9: add RTC DT node > > > > .../devicetree/bindings/rtc/s3c-rtc.yaml | 1 + > > .../boot/dts/exynos/exynosautov9-sadk.dts | 4 ++++ > > arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 10 ++++++++++ > > drivers/rtc/rtc-s3c.c | 18 ++++++++++++++++++ > > 4 files changed, 33 insertions(+) > > > > > > base-commit: 58ba80c4740212c29a1cf9b48f588e60a7612209 > > -- > > 2.34.1 > > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Hi Alexandre, > -----Original Message----- > From: Alexandre Belloni <alexandre.belloni@bootlin.com> > Sent: 03 September 2025 17:54 > To: Devang Tailor <dev.tailor@samsung.com> > Cc: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; > alim.akhtar@samsung.com; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-rtc@vger.kernel.org; faraz.ata@samsung.com > Subject: Re: [PATCH v2 0/3] On-chip RTC support for ExynosAutov9 > > On 03/09/2025 17:09:32+0530, Devang Tailor wrote: > > > > Hi, > > > > > > > -----Original Message----- > > > From: Devang Tailor <dev.tailor@samsung.com> > > > Sent: 10 July 2025 14:05 > > > To: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; > > > alim.akhtar@samsung.com; alexandre.belloni@bootlin.com; > > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > > linux- samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org; > > > linux- rtc@vger.kernel.org; faraz.ata@samsung.com > > > Cc: Devang Tailor <dev.tailor@samsung.com> > > > Subject: [PATCH v2 0/3] On-chip RTC support for ExynosAutov9 > > > > > > Enable on-chip RTC support. The on-chip RTC of this SoC is similar > > > to the previous versions of Samsung SoC. So re-use the existing RTC > > > driver with applicable call-backs for initialization and IRQ handling. > > > Add a separate call-back for disabling RTC since existing '.disable' > > > call-backs updates additional bit not valid for RTC of ExynosAutov9. > > > > > > Setting and getting hardware clock has been tested using 'hwclock' > > > and 'date' utilities. > > > > > > Alarm interrupt has been checked with incrementing interrupt count > > > via "cat /proc/interrupts | grep rtc" for 10sec wakeup time via > > > "echo +10 > /sys/class/rtc/rtc0/wakealarm" > > > > > > changelog > > > --- > > > Changes in v2: > > > - Fixed the review comment of v1 for mis-aligmnent & asymmetry bit > logic. > > > - link for v1 : > > > https://lore.kernel.org/linux-rtc/20250702052426.2404256-1- > > > dev.tailor@samsung.com/ > > > > > > > Reminder! > > Can you please help to identify if anything is pending in this patch series ? I > see all three patches are reviewed. > > > > You have actions after those reviews: > > https://lore.kernel.org/all/20250711-shapeless-adorable-lobster-d2efbf@krzk- > bin/ > Thanks for the pointer. I had given the explanation for that, https://lore.kernel.org/all/188001dbf249$831afd00$8950f700$@samsung.com/ after which I didn't get any feedback. As per my understanding I have addressed the review comment given in V1 for [PATCH 2/3] (without ignoring any). So I am not getting what I have missed. Would you help to point out what was left ? > > > > > > Devang Tailor (3): > > > dt-bindings: rtc: s3c-rtc: add compatible for exynosautov9 > > > rtc: s3c: support for exynosautov9 on-chip RTC > > > arm64: dts: exynosautov9: add RTC DT node > > > > > > .../devicetree/bindings/rtc/s3c-rtc.yaml | 1 + > > > .../boot/dts/exynos/exynosautov9-sadk.dts | 4 ++++ > > > arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 10 ++++++++++ > > > drivers/rtc/rtc-s3c.c | 18 ++++++++++++++++++ > > > 4 files changed, 33 insertions(+) > > > > > > > > > base-commit: 58ba80c4740212c29a1cf9b48f588e60a7612209 > > > -- > > > 2.34.1 > > > > > > -- > Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel > engineering https://protect2.fireeye.com/v1/url?k=62b10b19-03cce365- > 62b08056-74fe485cc33c-bc602ba9f8c455fd&q=1&e=14890047-79c7-46fe- > 85a0-48fc7c9b3d91&u=https%3A%2F%2Fbootlin.com%2F
© 2016 - 2025 Red Hat, Inc.