irqchip: irq-msi-lib: fix build with PCI disabled

[PATCH] irqchip: irq-msi-lib: fix build with PCI disabled

Posted by Arnd Bergmann 2 months, 4 weeks ago

From: Arnd Bergmann <arnd@arndb.de>

The armada-370-xp irqchip fails in some randconfig builds because
of a missing declaration:

In file included from drivers/irqchip/irq-armada-370-xp.c:23:
include/linux/irqchip/irq-msi-lib.h:25:39: error: 'struct msi_domain_info' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]

Add a forward declaration for the msi_domain_info structure.

Fixes: e51b27438a10 ("irqchip: Make irq-msi-lib.h globally available")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 include/linux/irqchip/irq-msi-lib.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/irqchip/irq-msi-lib.h b/include/linux/irqchip/irq-msi-lib.h
index dd8d1d138544..224ac28e88d7 100644
--- a/include/linux/irqchip/irq-msi-lib.h
+++ b/include/linux/irqchip/irq-msi-lib.h
@@ -17,6 +17,7 @@
 
 #define MATCH_PLATFORM_MSI	BIT(DOMAIN_BUS_PLATFORM_MSI)
 
+struct msi_domain_info;
 int msi_lib_irq_domain_select(struct irq_domain *d, struct irq_fwspec *fwspec,
 			      enum irq_domain_bus_token bus_token);
 
-- 
2.39.5

Re: [PATCH] irqchip: irq-msi-lib: fix build with PCI disabled

Posted by Marc Zyngier 2 months, 4 weeks ago

On Thu, 10 Jul 2025 09:00:12 +0100,
Arnd Bergmann <arnd@kernel.org> wrote:
> 
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The armada-370-xp irqchip fails in some randconfig builds because
> of a missing declaration:
> 
> In file included from drivers/irqchip/irq-armada-370-xp.c:23:
> include/linux/irqchip/irq-msi-lib.h:25:39: error: 'struct msi_domain_info' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> 
> Add a forward declaration for the msi_domain_info structure.
> 
> Fixes: e51b27438a10 ("irqchip: Make irq-msi-lib.h globally available")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  include/linux/irqchip/irq-msi-lib.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/irqchip/irq-msi-lib.h b/include/linux/irqchip/irq-msi-lib.h
> index dd8d1d138544..224ac28e88d7 100644
> --- a/include/linux/irqchip/irq-msi-lib.h
> +++ b/include/linux/irqchip/irq-msi-lib.h
> @@ -17,6 +17,7 @@
>  
>  #define MATCH_PLATFORM_MSI	BIT(DOMAIN_BUS_PLATFORM_MSI)
>  
> +struct msi_domain_info;
>  int msi_lib_irq_domain_select(struct irq_domain *d, struct irq_fwspec *fwspec,
>  			      enum irq_domain_bus_token bus_token);
>  

Acked-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.

[tip: irq/urgent] irqchip/irq-msi-lib: Fix build with PCI disabled

Posted by tip-bot2 for Arnd Bergmann 2 months, 4 weeks ago

The following commit has been merged into the irq/urgent branch of tip:

Commit-ID:     a8b289f0f2dcbadd8c207ad8f33cf7ba2b4eb088
Gitweb:        https://git.kernel.org/tip/a8b289f0f2dcbadd8c207ad8f33cf7ba2b4eb088
Author:        Arnd Bergmann <arnd@arndb.de>
AuthorDate:    Thu, 10 Jul 2025 10:00:12 +02:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Thu, 10 Jul 2025 23:46:05 +02:00

irqchip/irq-msi-lib: Fix build with PCI disabled

The armada-370-xp irqchip fails in some randconfig builds because
of a missing declaration:

In file included from drivers/irqchip/irq-armada-370-xp.c:23:
include/linux/irqchip/irq-msi-lib.h:25:39: error: 'struct msi_domain_info' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]

Add a forward declaration for the msi_domain_info structure.

[ tglx: Fixed up the subsystem prefix. Is it really that hard to get right? ]

Fixes: e51b27438a10 ("irqchip: Make irq-msi-lib.h globally available")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/all/20250710080021.2303640-1-arnd@kernel.org

---
 include/linux/irqchip/irq-msi-lib.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/irqchip/irq-msi-lib.h b/include/linux/irqchip/irq-msi-lib.h
index dd8d1d1..224ac28 100644
--- a/include/linux/irqchip/irq-msi-lib.h
+++ b/include/linux/irqchip/irq-msi-lib.h
@@ -17,6 +17,7 @@
 
 #define MATCH_PLATFORM_MSI	BIT(DOMAIN_BUS_PLATFORM_MSI)
 
+struct msi_domain_info;
 int msi_lib_irq_domain_select(struct irq_domain *d, struct irq_fwspec *fwspec,
 			      enum irq_domain_bus_token bus_token);