Adding yet another feature to the ad7173 driver, this time,
filter support.

There are a couple of leading patches to rename some stuff to minimize
the diff in the main patch where filter support is actually added. And
there is a bonus patch to clean up the ABI docs for filter_type first
before adding the new filter types introduced in this series.

This was tested on the EVAL-AD7173-8ARDZ evaluation board.

This series depends on a bunch of fixes, so we'll have to wait for
those to make it back into iio/testing before we can merge this
series. There is also an outstanding patch to add SPI offload support
to this driver, but that doesn't actually have any merge conflicts
with this series, so they can be applied in any order.

---
David Lechner (5):
      iio: adc: ad7173: rename ad7173_chan_spec_ext_info
      iio: adc: ad7173: rename odr field
      iio: adc: ad7173: support changing filter type
      iio: ABI: alphabetize filter types
      iio: ABI: add filter types for ad7173

 Documentation/ABI/testing/sysfs-bus-iio |  25 ++--
 drivers/iio/adc/ad7173.c                | 204 +++++++++++++++++++++++++++++---
 2 files changed, 205 insertions(+), 24 deletions(-)
---
base-commit: f8f559752d573a051a984adda8d2d1464f92f954
change-id: 20250710-iio-adc-ad7137-add-filter-support-d0ffaa92afc9
prerequisite-change-id: 20250703-iio-adc-ad7173-fix-channels-index-for-syscalib_mode-49b404e99e0c:v1
prerequisite-patch-id: 982dde330c34b57a76a3e48ccfc73ea6977833d1
prerequisite-change-id: 20250703-iio-adc-ad7173-fix-num_slots-on-most-chips-b982206a20b1:v3
prerequisite-patch-id: 350fb675f3e0fe494e0ce4ddf5685d9369ffa11a
prerequisite-change-id: 20250708-iio-adc-ad7313-fix-calibration-channel-198ed65d9b0a:v1
prerequisite-patch-id: b94476eb0399877093321fd5010965d44738c097
prerequisite-change-id: 20250709-iio-adc-ad7173-fix-setup-use-limits-0a5d2b6a6780:v1
prerequisite-patch-id: 8ca40138b61bcf4eac7437b8184276576308536b
prerequisite-change-id: 20250710-iio-adc-ad7173-fix-setting-odr-in-probe-915972070e8a:v1
prerequisite-patch-id: 0f79cb2677f8a249283e239ca9ae9ae1a1eeb365

Best regards,
-- 
David Lechner <dlechner@baylibre.com>

On 7/10/25 5:39 PM, David Lechner wrote:
> Adding yet another feature to the ad7173 driver, this time,
> filter support.
> 
> There are a couple of leading patches to rename some stuff to minimize
> the diff in the main patch where filter support is actually added. And
> there is a bonus patch to clean up the ABI docs for filter_type first
> before adding the new filter types introduced in this series.
> 
> This was tested on the EVAL-AD7173-8ARDZ evaluation board.
> 
> This series depends on a bunch of fixes, so we'll have to wait for
> those to make it back into iio/testing before we can merge this
> series. There is also an outstanding patch to add SPI offload support
> to this driver, but that doesn't actually have any merge conflicts
> with this series, so they can be applied in any order.
> 
> ---
> David Lechner (5):
>       iio: adc: ad7173: rename ad7173_chan_spec_ext_info
>       iio: adc: ad7173: rename odr field
>       iio: adc: ad7173: support changing filter type
>       iio: ABI: alphabetize filter types
>       iio: ABI: add filter types for ad7173
> 
I don't know why, but I really struggle to write this part number
correctly. The subject of this cover letter is wrong, but at least
I got it right in all of the patch subject lines.

On Thu, Jul 10, 2025 at 05:47:14PM -0500, David Lechner wrote:
> On 7/10/25 5:39 PM, David Lechner wrote:
> > Adding yet another feature to the ad7173 driver, this time,
> > filter support.
> > 
> > There are a couple of leading patches to rename some stuff to minimize
> > the diff in the main patch where filter support is actually added. And
> > there is a bonus patch to clean up the ABI docs for filter_type first
> > before adding the new filter types introduced in this series.
> > 
> > This was tested on the EVAL-AD7173-8ARDZ evaluation board.
> > 
> > This series depends on a bunch of fixes, so we'll have to wait for
> > those to make it back into iio/testing before we can merge this
> > series. There is also an outstanding patch to add SPI offload support
> > to this driver, but that doesn't actually have any merge conflicts
> > with this series, so they can be applied in any order.
> > 
> > ---
> > David Lechner (5):
> >       iio: adc: ad7173: rename ad7173_chan_spec_ext_info
> >       iio: adc: ad7173: rename odr field
> >       iio: adc: ad7173: support changing filter type
> >       iio: ABI: alphabetize filter types
> >       iio: ABI: add filter types for ad7173
> > 
> I don't know why, but I really struggle to write this part number
> correctly. The subject of this cover letter is wrong, but at least
> I got it right in all of the patch subject lines.

Series looks good. Just some (apparent) typos and some other thing that
you may or may not change. So, at least with the typos fixed:

Reviewed-by: Nuno Sá <nuno.sa@analog.com>

On Thu, 10 Jul 2025 17:47:14 -0500
David Lechner <dlechner@baylibre.com> wrote:

> On 7/10/25 5:39 PM, David Lechner wrote:
> > Adding yet another feature to the ad7173 driver, this time,
> > filter support.
> > 
> > There are a couple of leading patches to rename some stuff to minimize
> > the diff in the main patch where filter support is actually added. And
> > there is a bonus patch to clean up the ABI docs for filter_type first
> > before adding the new filter types introduced in this series.
> > 
> > This was tested on the EVAL-AD7173-8ARDZ evaluation board.
> > 
> > This series depends on a bunch of fixes, so we'll have to wait for
> > those to make it back into iio/testing before we can merge this
> > series. There is also an outstanding patch to add SPI offload support
> > to this driver, but that doesn't actually have any merge conflicts
> > with this series, so they can be applied in any order.
> > 
> > ---
> > David Lechner (5):
> >       iio: adc: ad7173: rename ad7173_chan_spec_ext_info
> >       iio: adc: ad7173: rename odr field
> >       iio: adc: ad7173: support changing filter type
> >       iio: ABI: alphabetize filter types
> >       iio: ABI: add filter types for ad7173
> >   
> I don't know why, but I really struggle to write this part number
> correctly. The subject of this cover letter is wrong, but at least
> I got it right in all of the patch subject lines.
> 

Series look good to me. Give me a poke if it looks like I've forgotten
to pick this up after the precursor fix is in my tree.

Jonathan

On 7/24/25 8:20 AM, Jonathan Cameron wrote:
> On Thu, 10 Jul 2025 17:47:14 -0500
> David Lechner <dlechner@baylibre.com> wrote:
> 
>> On 7/10/25 5:39 PM, David Lechner wrote:
>>> Adding yet another feature to the ad7173 driver, this time,
>>> filter support.
>>>
>>> There are a couple of leading patches to rename some stuff to minimize
>>> the diff in the main patch where filter support is actually added. And
>>> there is a bonus patch to clean up the ABI docs for filter_type first
>>> before adding the new filter types introduced in this series.
>>>
>>> This was tested on the EVAL-AD7173-8ARDZ evaluation board.
>>>
>>> This series depends on a bunch of fixes, so we'll have to wait for
>>> those to make it back into iio/testing before we can merge this
>>> series. There is also an outstanding patch to add SPI offload support
>>> to this driver, but that doesn't actually have any merge conflicts
>>> with this series, so they can be applied in any order.
>>>
>>> ---
>>> David Lechner (5):
>>>       iio: adc: ad7173: rename ad7173_chan_spec_ext_info
>>>       iio: adc: ad7173: rename odr field
>>>       iio: adc: ad7173: support changing filter type
>>>       iio: ABI: alphabetize filter types
>>>       iio: ABI: add filter types for ad7173
>>>   
>> I don't know why, but I really struggle to write this part number
>> correctly. The subject of this cover letter is wrong, but at least
>> I got it right in all of the patch subject lines.
>>
> 
> Series look good to me. Give me a poke if it looks like I've forgotten
> to pick this up after the precursor fix is in my tree.
> 
> Jonathan

Sure, no problem. Can we pick up PATCH 4/5 ("iio: ABI: alphabetize
filter types") sooner though? I know there is at least one other
series under review that is adding more filter types and I am
getting ready to start on another one that will likely introduce
some more variants.

On Thu, 24 Jul 2025 13:50:01 -0500
David Lechner <dlechner@baylibre.com> wrote:

> On 7/24/25 8:20 AM, Jonathan Cameron wrote:
> > On Thu, 10 Jul 2025 17:47:14 -0500
> > David Lechner <dlechner@baylibre.com> wrote:
> >   
> >> On 7/10/25 5:39 PM, David Lechner wrote:  
> >>> Adding yet another feature to the ad7173 driver, this time,
> >>> filter support.
> >>>
> >>> There are a couple of leading patches to rename some stuff to minimize
> >>> the diff in the main patch where filter support is actually added. And
> >>> there is a bonus patch to clean up the ABI docs for filter_type first
> >>> before adding the new filter types introduced in this series.
> >>>
> >>> This was tested on the EVAL-AD7173-8ARDZ evaluation board.
> >>>
> >>> This series depends on a bunch of fixes, so we'll have to wait for
> >>> those to make it back into iio/testing before we can merge this
> >>> series. There is also an outstanding patch to add SPI offload support
> >>> to this driver, but that doesn't actually have any merge conflicts
> >>> with this series, so they can be applied in any order.
> >>>
> >>> ---
> >>> David Lechner (5):
> >>>       iio: adc: ad7173: rename ad7173_chan_spec_ext_info
> >>>       iio: adc: ad7173: rename odr field
> >>>       iio: adc: ad7173: support changing filter type
> >>>       iio: ABI: alphabetize filter types
> >>>       iio: ABI: add filter types for ad7173
> >>>     
> >> I don't know why, but I really struggle to write this part number
> >> correctly. The subject of this cover letter is wrong, but at least
> >> I got it right in all of the patch subject lines.
> >>  
> > 
> > Series look good to me. Give me a poke if it looks like I've forgotten
> > to pick this up after the precursor fix is in my tree.
> > 
> > Jonathan  
> 
> Sure, no problem. Can we pick up PATCH 4/5 ("iio: ABI: alphabetize
> filter types") sooner though? I know there is at least one other
> series under review that is adding more filter types and I am
> getting ready to start on another one that will likely introduce
> some more variants.
> 
Sure.  Patch 4 applied to the testing branch of iio.git.

Thanks,

Jonathan