[PATCH v7 0/3] arm64: dts: qcom: x1-hp-x14: Add support for X1P42100 HP Omnibook X14

Jens Glathe via B4 Relay posted 3 patches 2 months, 4 weeks ago
There is a newer version of this series
Documentation/devicetree/bindings/arm/qcom.yaml    |    1 +
arch/arm64/boot/dts/qcom/Makefile                  |    2 +
arch/arm64/boot/dts/qcom/x1-hp-omnibook-x14.dtsi   | 1549 ++++++++++++++++++++
.../boot/dts/qcom/x1e80100-hp-omnibook-x14.dts     | 1549 +-------------------
.../boot/dts/qcom/x1p42100-hp-omnibook-x14.dts     |   33 +
5 files changed, 1589 insertions(+), 1545 deletions(-)
[PATCH v7 0/3] arm64: dts: qcom: x1-hp-x14: Add support for X1P42100 HP Omnibook X14
Posted by Jens Glathe via B4 Relay 2 months, 4 weeks ago
This patch series adds support for the HP Omnibook X Laptop 14-fe1xxx. [1]

Since this is actually the same model as the 14-fe0xxx, but with an
X1P-42-100 SoC (Purwa), it needs a slightly different device tree.
To have as minimal duplicate definition as possible, the hp X14 gets 
commonalized into a dtsi (and it stays compatible to the derived 
device trees, like the Ultrabook G1q). 

The supported features are the same as for the original Omnibook X14:

- Keyboard (no function keys though)
- Display
- PWM brightness control
- Touchpad
- Touchscreen
- PCIe ports (pcie4, pcie6a)
- USB type-c, type-a
- WCN6855 Wifi-6E
- WCN6855 Bluetooth
- ADSP and CDSP
- X1 GPU
- GPIO Keys (Lid switch)
- Audio definition (works via USB and with internal speakers)

[1]: https://www.hp.com/us-en/shop/pdp/hp-omnibook-x-laptop-next-gen-ai-pc-14-fe100-14-a4nd1av-1#techSpecs

Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
---
Changes in v7:
- rebased to next-20250710.
- reworded commit message for patch #2
- picked up reviewed-by for patch #3 (thanks)
- fixed link ref in patch #3
- Link to v6: https://lore.kernel.org/r/20250709-hp-x14-x1p-v6-0-f45cc186a62d@oldschoolsolutions.biz

Changes in v6:
- rebased to next-20250709.
- picked up reviewed-by for patch #1 (thanks)
- corrected typo in patch #1
- removed model, compatible, chassis nodes from x1-hp-omnibook-x14.dtsi
- amended copyright strings as discussed
- Link to v5: https://lore.kernel.org/r/20250708-hp-x14-x1p-v5-0-44c916efa973@oldschoolsolutions.biz

Changes in v5:
- rebased to next-20250708.
- changed commit message for patch #1 to reflect what happens
- moved gpu node into the common dtsi part (always supported now)
- switched over to gpu_zap_shader definition in the individual parts
- Link to v4: https://lore.kernel.org/r/20250705-hp-x14-x1p-v4-0-1c351dbeaf18@oldschoolsolutions.biz

Changes in v4:
- leave the qcom,jp-omnibook-x14 ABI unchanged, reuse it for the -fe0 variant
- hacked b4 to create an easier reviewable patch: https://lore.kernel.org/all/20250705-format-harder-v1-1-55c5342be55c@oldschoolsolutions.biz
- Link to v3: https://lore.kernel.org/r/20250703-hp-x14-x1p-v3-0-affe103b4356@oldschoolsolutions.biz

Changes in v3:
- removed copyright strings
- amended changed commit message  
- Link to v2: https://lore.kernel.org/r/20250702-hp-x14-x1p-v2-0-af5b588d1979@oldschoolsolutions.biz

Changes in v2:
- remove pm8010 handling
- Link to v1: https://lore.kernel.org/r/20250702-hp-x14-x1p-v1-0-219356e83207@oldschoolsolutions.biz

---
Jens Glathe (3):
      dt-bindings: arm: qcom: Add HP Omnibook X14 AI X1P4200 variant
      arm64: dts: qcom: x1-hp-x14: Unify HP Omnibook X14 device tree structure
      arm64: dts: qcom: x1-hp-x14: Add support for X1P42100 HP Omnibook X14

 Documentation/devicetree/bindings/arm/qcom.yaml    |    1 +
 arch/arm64/boot/dts/qcom/Makefile                  |    2 +
 arch/arm64/boot/dts/qcom/x1-hp-omnibook-x14.dtsi   | 1549 ++++++++++++++++++++
 .../boot/dts/qcom/x1e80100-hp-omnibook-x14.dts     | 1549 +-------------------
 .../boot/dts/qcom/x1p42100-hp-omnibook-x14.dts     |   33 +
 5 files changed, 1589 insertions(+), 1545 deletions(-)
---
base-commit: b551c4e2a98a177a06148cf16505643cd2108386
change-id: 20250702-hp-x14-x1p-eb32f4696d96

Best regards,
-- 
Jens Glathe <jens.glathe@oldschoolsolutions.biz>
Re: [PATCH v7 0/3] arm64: dts: qcom: x1-hp-x14: Add support for X1P42100 HP Omnibook X14
Posted by Bjorn Andersson 2 weeks, 6 days ago
On Thu, 10 Jul 2025 12:50:32 +0200, Jens Glathe wrote:
> This patch series adds support for the HP Omnibook X Laptop 14-fe1xxx. [1]
> 
> Since this is actually the same model as the 14-fe0xxx, but with an
> X1P-42-100 SoC (Purwa), it needs a slightly different device tree.
> To have as minimal duplicate definition as possible, the hp X14 gets
> commonalized into a dtsi (and it stays compatible to the derived
> device trees, like the Ultrabook G1q).
> 
> [...]

Applied, thanks!

[1/3] dt-bindings: arm: qcom: Add HP Omnibook X14 AI X1P4200 variant
      commit: a58d6100ee2c4a732fb4e1520885958480a82110
[2/3] arm64: dts: qcom: x1-hp-x14: Unify HP Omnibook X14 device tree structure
      commit: 72b50c2fd887f632501ce69e03d8e6bb35c8a1e8
[3/3] arm64: dts: qcom: x1-hp-x14: Add support for X1P42100 HP Omnibook X14
      commit: f8f7cc59dcd234f0dcc4964ff2188a7a2ae09fd6

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>
Re: [PATCH v7 0/3] arm64: dts: qcom: x1-hp-x14: Add support for X1P42100 HP Omnibook X14
Posted by Krzysztof Kozlowski 2 months, 4 weeks ago
On 10/07/2025 12:50, Jens Glathe via B4 Relay wrote:
> This patch series adds support for the HP Omnibook X Laptop 14-fe1xxx. [1]
> 
> Since this is actually the same model as the 14-fe0xxx, but with an
> X1P-42-100 SoC (Purwa), it needs a slightly different device tree.
> To have as minimal duplicate definition as possible, the hp X14 gets 
> commonalized into a dtsi (and it stays compatible to the derived 
> device trees, like the Ultrabook G1q). 
> 
> The supported features are the same as for the original Omnibook X14:
> 
> - Keyboard (no function keys though)
> - Display
> - PWM brightness control
> - Touchpad
> - Touchscreen
> - PCIe ports (pcie4, pcie6a)
> - USB type-c, type-a
> - WCN6855 Wifi-6E
> - WCN6855 Bluetooth
> - ADSP and CDSP
> - X1 GPU
> - GPIO Keys (Lid switch)
> - Audio definition (works via USB and with internal speakers)
> 
> [1]: https://www.hp.com/us-en/shop/pdp/hp-omnibook-x-laptop-next-gen-ai-pc-14-fe100-14-a4nd1av-1#techSpecs
> 
> Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
> ---
> Changes in v7:
> - rebased to next-20250710.
> - reworded commit message for patch #2
> - picked up reviewed-by for patch #3 (thanks)
> - fixed link ref in patch #3
> - Link to v6: https://lore.kernel.org/r/20250709-hp-x14-x1p-v6-0-f45cc186a62d@oldschoolsolutions.biz

Please slow down a bit. You keep sending every day. It is fine for
simple patchsets reaching v2 or v3... but this keeps going and you
reached v7!

Instead wait for few days to give people actually chance to review.

Best regards,
Krzysztof