From: jiebing chen <jiebing.chen@amlogic.com>

Add S4 SoC tocodec compatibility support.

Acked-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Jiebing Chen <jiebing.chen@amlogic.com>
---
 Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml b/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml
index 23f82bb89750898d20c866015bc2e1a4b0554846..ea669f4359bc81b0f45bc2105c832fc2b11d8441 100644
--- a/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml
+++ b/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml
@@ -26,6 +26,7 @@ properties:
       - items:
           - enum:
               - amlogic,sm1-toacodec
+              - amlogic,s4-toacodec
           - const: amlogic,g12a-toacodec
 
   reg:

-- 
2.43.0

On 10/07/2025 05:35, jiebing chen via B4 Relay wrote:
> From: jiebing chen <jiebing.chen@amlogic.com>
> 
> Add S4 SoC tocodec compatibility support.
> 
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> Signed-off-by: Jiebing Chen <jiebing.chen@amlogic.com>
> ---

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters


<form letter>
This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.
</form letter>


Best regards,
Krzysztof

On 14/07/2025 08:10, Krzysztof Kozlowski wrote:
> On 10/07/2025 05:35, jiebing chen via B4 Relay wrote:
>> From: jiebing chen <jiebing.chen@amlogic.com>
>>
>> Add S4 SoC tocodec compatibility support.
>>
>> Acked-by: Rob Herring (Arm) <robh@kernel.org>
>> Signed-off-by: Jiebing Chen <jiebing.chen@amlogic.com>
>> ---
> 
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
> 
> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
> 
> Thank you.
> </form letter>
> 
You responded in private, but that's not how we discuss here. Please
keep all discussions public.

Above form letter means you received feedback at v1 or v2 and you did
not implement it. You did not respond to it, either.

Please go back to v1 or v2 and implement entire feedback.

Best regards,
Krzysztof

在 2025/7/14 15:22, Krzysztof Kozlowski 写道:
> [ EXTERNAL EMAIL ]
>
> On 14/07/2025 08:10, Krzysztof Kozlowski wrote:
>> On 10/07/2025 05:35, jiebing chen via B4 Relay wrote:
>>> From: jiebing chen <jiebing.chen@amlogic.com>
>>>
>>> Add S4 SoC tocodec compatibility support.
>>>
>>> Acked-by: Rob Herring (Arm) <robh@kernel.org>
>>> Signed-off-by: Jiebing Chen <jiebing.chen@amlogic.com>
>>> ---
>> Please use subject prefixes matching the subsystem. You can get them for
>> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
>> your patch is touching. For bindings, the preferred subjects are
>> explained here:
>> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>>
>>
>> <form letter>
>> This is a friendly reminder during the review process.
>>
>> It seems my or other reviewer's previous comments were not fully
>> addressed. Maybe the feedback got lost between the quotes, maybe you
>> just forgot to apply it. Please go back to the previous discussion and
>> either implement all requested changes or keep discussing them.
>>
>> Thank you.
>> </form letter>
>>
> You responded in private, but that's not how we discuss here. Please
> keep all discussions public.
>
> Above form letter means you received feedback at v1 or v2 and you did
> not implement it. You did not respond to it, either.
>
> Please go back to v1 or v2 and implement entire feedback.

thanks, I will refer to the previous submission.


3fda85324b8d ASoC: dt-bindings: Extend name-prefix.yaml into common DAI
properties

ASoC: dt-bindings:

>
> Best regards,
> Krzysztof

On Thu, Jul 10, 2025 at 11:35:39AM +0800, jiebing chen wrote:
> Add S4 SoC tocodec compatibility support.
> 
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> Signed-off-by: Jiebing Chen <jiebing.chen@amlogic.com>
> ---
>  Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml b/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml
> index 23f82bb89750898d20c866015bc2e1a4b0554846..ea669f4359bc81b0f45bc2105c832fc2b11d8441 100644
> --- a/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml
> +++ b/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml
> @@ -26,6 +26,7 @@ properties:
>        - items:
>            - enum:
>                - amlogic,sm1-toacodec
> +              - amlogic,s4-toacodec

Keep the list sorted.

>            - const: amlogic,g12a-toacodec
>  
>    reg:
> 
> -- 
> 2.43.0
>