[PATCH 3/6] dt-bindings: reset: add BCM63268 ephy reset definitions

Kyle Hendry posted 6 patches 3 months ago
There is a newer version of this series
[PATCH 3/6] dt-bindings: reset: add BCM63268 ephy reset definitions
Posted by Kyle Hendry 3 months ago
Add definitions for resets in the ephy control register.

Signed-off-by: Kyle Hendry <kylehendrydev@gmail.com>
---
 include/dt-bindings/reset/bcm63268-reset.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/dt-bindings/reset/bcm63268-reset.h b/include/dt-bindings/reset/bcm63268-reset.h
index d87a7882782a..676a62c9777b 100644
--- a/include/dt-bindings/reset/bcm63268-reset.h
+++ b/include/dt-bindings/reset/bcm63268-reset.h
@@ -27,4 +27,8 @@
 #define BCM63268_TRST_HW	30
 #define BCM63268_TRST_POR	31
 
+#define BCM63268_RST_EPHY1 0
+#define BCM63268_RST_EPHY2 1
+#define BCM63268_RST_EPHY3 2
+
 #endif /* __DT_BINDINGS_RESET_BCM63268_H */
-- 
2.43.0
Re: [PATCH 3/6] dt-bindings: reset: add BCM63268 ephy reset definitions
Posted by Rob Herring 2 months, 4 weeks ago
On Tue, Jul 08, 2025 at 07:47:27PM -0700, Kyle Hendry wrote:
> Add definitions for resets in the ephy control register.
> 
> Signed-off-by: Kyle Hendry <kylehendrydev@gmail.com>
> ---
>  include/dt-bindings/reset/bcm63268-reset.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/dt-bindings/reset/bcm63268-reset.h b/include/dt-bindings/reset/bcm63268-reset.h
> index d87a7882782a..676a62c9777b 100644
> --- a/include/dt-bindings/reset/bcm63268-reset.h
> +++ b/include/dt-bindings/reset/bcm63268-reset.h
> @@ -27,4 +27,8 @@
>  #define BCM63268_TRST_HW	30
>  #define BCM63268_TRST_POR	31
>  
> +#define BCM63268_RST_EPHY1 0
> +#define BCM63268_RST_EPHY2 1
> +#define BCM63268_RST_EPHY3 2

These are kind of pointless IMO. The provider is only for the EPHYs and 
your number is just index+1.

Rob