[PATCH] rust: init: remove old workaround

Tamir Duberstein posted 1 patch 5 months, 1 week ago
There is a newer version of this series
rust/kernel/init.rs | 7 -------
1 file changed, 7 deletions(-)
[PATCH] rust: init: remove old workaround
Posted by Tamir Duberstein 5 months, 1 week ago
`Error::from_errno` is `pub` since commit 5ed147473458 ("rust: error:
make conversion functions public"), thus remove this workaround which is
no longer needed.

Signed-off-by: Tamir Duberstein <tamird@gmail.com>
---
 rust/kernel/init.rs | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/rust/kernel/init.rs b/rust/kernel/init.rs
index 8d228c237954..be3a25932342 100644
--- a/rust/kernel/init.rs
+++ b/rust/kernel/init.rs
@@ -77,13 +77,6 @@
 //! #     pub unsafe fn destroy_foo(_ptr: *mut foo) {}
 //! #     pub unsafe fn enable_foo(_ptr: *mut foo, _flags: u32) -> i32 { 0 }
 //! # }
-//! # // `Error::from_errno` is `pub(crate)` in the `kernel` crate, thus provide a workaround.
-//! # trait FromErrno {
-//! #     fn from_errno(errno: core::ffi::c_int) -> Error {
-//! #         // Dummy error that can be constructed outside the `kernel` crate.
-//! #         Error::from(core::fmt::Error)
-//! #     }
-//! # }
 //! # impl FromErrno for Error {}
 //! /// # Invariants
 //! ///

---
base-commit: 2009a2d5696944d85c34d75e691a6f3884e787c0
change-id: 20250709-init-remove-old-workaround-a6ec6792e010

Best regards,
--  
Tamir Duberstein <tamird@gmail.com>
Re: [PATCH] rust: init: remove old workaround
Posted by Miguel Ojeda 5 months ago
On Thu, Jul 10, 2025 at 12:34 AM Tamir Duberstein <tamird@gmail.com> wrote:
>
> `Error::from_errno` is `pub` since commit 5ed147473458 ("rust: error:
> make conversion functions public"), thus remove this workaround which is
> no longer needed.
>
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>

This seems the same as this one applied a few weeks ago:

    https://lore.kernel.org/rust-for-linux/20250526152914.2453949-2-ojeda@kernel.org/

Cheers,
Miguel
Re: [PATCH] rust: init: remove old workaround
Posted by Alice Ryhl 5 months ago
On Wed, Jul 09, 2025 at 06:34:33PM -0400, Tamir Duberstein wrote:
> `Error::from_errno` is `pub` since commit 5ed147473458 ("rust: error:
> make conversion functions public"), thus remove this workaround which is
> no longer needed.
> 
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>

Huh. We should just have made it `pub` right away when we felt the need
to add this workaround.

Reviewed-by: Alice Ryhl <aliceryhl@google.com>