[PATCH 4/8] dt-bindings: clock: qcom,qcs404-turingcc: Reference qcom,gcc.yaml

Satya Priya Kakitapalli posted 8 patches 3 months ago
There is a newer version of this series
[PATCH 4/8] dt-bindings: clock: qcom,qcs404-turingcc: Reference qcom,gcc.yaml
Posted by Satya Priya Kakitapalli 3 months ago
Reference the common qcom,gcc.yaml schema to unify the common
parts of the binding.

Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
---
 .../devicetree/bindings/clock/qcom,qcs404-turingcc.yaml | 17 ++++-------------
 1 file changed, 4 insertions(+), 13 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml b/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml
index 033e010754a26bd03e02a364b0a6f36d87a3af62..794984f563fe3eb253aaf7524205097cf0c62711 100644
--- a/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml
@@ -13,26 +13,17 @@ properties:
   compatible:
     const: qcom,qcs404-turingcc
 
-  reg:
-    maxItems: 1
-
   clocks:
     maxItems: 1
 
-  '#clock-cells':
-    const: 1
-
-  '#reset-cells':
-    const: 1
-
 required:
   - compatible
-  - reg
   - clocks
-  - '#clock-cells'
-  - '#reset-cells'
 
-additionalProperties: false
+allOf:
+  - $ref: qcom,gcc.yaml#
+
+unevaluatedProperties: false
 
 examples:
   - |

-- 
2.25.1
Re: [PATCH 4/8] dt-bindings: clock: qcom,qcs404-turingcc: Reference qcom,gcc.yaml
Posted by Krzysztof Kozlowski 3 months ago
On 09/07/2025 11:37, Satya Priya Kakitapalli wrote:
> Reference the common qcom,gcc.yaml schema to unify the common
> parts of the binding.
> 
> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
> ---
>  .../devicetree/bindings/clock/qcom,qcs404-turingcc.yaml | 17 ++++-------------
>  1 file changed, 4 insertions(+), 13 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml b/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml
> index 033e010754a26bd03e02a364b0a6f36d87a3af62..794984f563fe3eb253aaf7524205097cf0c62711 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml
> @@ -13,26 +13,17 @@ properties:
>    compatible:
>      const: qcom,qcs404-turingcc
>  
> -  reg:
> -    maxItems: 1
> -
>    clocks:
>      maxItems: 1
>  
> -  '#clock-cells':
> -    const: 1
> -
> -  '#reset-cells':
> -    const: 1
> -
>  required:
>    - compatible
> -  - reg
>    - clocks
> -  - '#clock-cells'
> -  - '#reset-cells'
No, this becomes now power domain provider without explanation.

Don't just blindly copy other people's commits without understanding them.

Best regards,
Krzysztof
Re: [PATCH 4/8] dt-bindings: clock: qcom,qcs404-turingcc: Reference qcom,gcc.yaml
Posted by Satya Priya Kakitapalli 2 months, 4 weeks ago
On 7/9/2025 3:37 PM, Krzysztof Kozlowski wrote:
> On 09/07/2025 11:37, Satya Priya Kakitapalli wrote:
>> Reference the common qcom,gcc.yaml schema to unify the common
>> parts of the binding.
>>
>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
>> ---
>>   .../devicetree/bindings/clock/qcom,qcs404-turingcc.yaml | 17 ++++-------------
>>   1 file changed, 4 insertions(+), 13 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml b/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml
>> index 033e010754a26bd03e02a364b0a6f36d87a3af62..794984f563fe3eb253aaf7524205097cf0c62711 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml
>> @@ -13,26 +13,17 @@ properties:
>>     compatible:
>>       const: qcom,qcs404-turingcc
>>   
>> -  reg:
>> -    maxItems: 1
>> -
>>     clocks:
>>       maxItems: 1
>>   
>> -  '#clock-cells':
>> -    const: 1
>> -
>> -  '#reset-cells':
>> -    const: 1
>> -
>>   required:
>>     - compatible
>> -  - reg
>>     - clocks
>> -  - '#clock-cells'
>> -  - '#reset-cells'
> No, this becomes now power domain provider without explanation.


My bad, I will drop the files which do not have the power domain cells 
in my next post.


> Don't just blindly copy other people's commits without understanding them.
>
> Best regards,
> Krzysztof