[v1] Reference the common qcom,gcc.yaml schema

[PATCH 2/8] dt-bindings: clock: qcom,lcc: Reference qcom,gcc.yaml

Posted by Satya Priya Kakitapalli 3 months ago

Reference the common qcom,gcc.yaml schema to unify the common
parts of the binding.

Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
---
 Documentation/devicetree/bindings/clock/qcom,lcc.yaml | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,lcc.yaml b/Documentation/devicetree/bindings/clock/qcom,lcc.yaml
index 55985e562a34f8b1f5d8cff88fd733cdbae7d37c..b4b500dea527269a9a282b3f99714d5703dd9215 100644
--- a/Documentation/devicetree/bindings/clock/qcom,lcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,lcc.yaml
@@ -23,24 +23,11 @@ properties:
   clock-names:
     maxItems: 8
 
-  '#clock-cells':
-    const: 1
-
-  '#reset-cells':
-    const: 1
-
-  reg:
-    maxItems: 1
-
 required:
   - compatible
-  - reg
-  - '#clock-cells'
-  - '#reset-cells'
-
-additionalProperties: false
 
 allOf:
+  - $ref: qcom,gcc.yaml#
   - if:
       properties:
         compatible:
@@ -110,6 +97,8 @@ allOf:
         - clocks
         - clock-names
 
+unevaluatedProperties: false
+
 examples:
   - |
     clock-controller@28000000 {

-- 
2.25.1

Re: [PATCH 2/8] dt-bindings: clock: qcom,lcc: Reference qcom,gcc.yaml

Posted by Krzysztof Kozlowski 3 months ago

On 09/07/2025 11:37, Satya Priya Kakitapalli wrote:
> Reference the common qcom,gcc.yaml schema to unify the common
> parts of the binding.
> 
> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
> ---
>  Documentation/devicetree/bindings/clock/qcom,lcc.yaml | 17 +++--------------
>  1 file changed, 3 insertions(+), 14 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,lcc.yaml b/Documentation/devicetree/bindings/clock/qcom,lcc.yaml
> index 55985e562a34f8b1f5d8cff88fd733cdbae7d37c..b4b500dea527269a9a282b3f99714d5703dd9215 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,lcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,lcc.yaml
> @@ -23,24 +23,11 @@ properties:
>    clock-names:
>      maxItems: 8
>  
> -  '#clock-cells':
> -    const: 1
> -
For the same reasons as further patch, no. You do not understand what is
happening here (and commit msg must explain such things)...

Best regards,
Krzysztof