ACPI-based systems are required to create and register a fixed rate clock
using the new v4l2 helper devm_v4l2_sensor_clk_get() that uses the
common clk framework.

Ensure that COMMON_CLK is selected.

Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
---
 drivers/media/i2c/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index e68202954a8f..f974a0e0dcec 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -31,6 +31,7 @@ menuconfig VIDEO_CAMERA_SENSOR
 	select MEDIA_CONTROLLER
 	select V4L2_FWNODE
 	select VIDEO_V4L2_SUBDEV_API
+	select COMMON_CLK if ACPI && !HAVE_LEGACY_CLK
 	default y
 
 if VIDEO_CAMERA_SENSOR
-- 
2.49.0

On Tue, Jul 8, 2025, at 18:16, Mehdi Djait wrote:
> ACPI-based systems are required to create and register a fixed rate clock
> using the new v4l2 helper devm_v4l2_sensor_clk_get() that uses the
> common clk framework.
>
> Ensure that COMMON_CLK is selected.
>
> Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>

You should never 'select' another subsystem or a drvier from
an unrelated subsystem.

What you want here instead is 'depends on COMMON_CLK'.

      Arnd

Hello Arnd,

Thank you for the review.

On Tue, Jul 08, 2025 at 06:28:12PM +0200, Arnd Bergmann wrote:
> On Tue, Jul 8, 2025, at 18:16, Mehdi Djait wrote:
> > ACPI-based systems are required to create and register a fixed rate clock
> > using the new v4l2 helper devm_v4l2_sensor_clk_get() that uses the
> > common clk framework.
> >
> > Ensure that COMMON_CLK is selected.
> >
> > Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
> 
> You should never 'select' another subsystem or a drvier from
> an unrelated subsystem.
> 
> What you want here instead is 'depends on COMMON_CLK'.

Ack.

I will change this in the v2.

--
Kind Regards
Mehdi Djait