MAINTAINERS: Update TDX entry

[PATCH 1/3] MAINTAINERS: Update the file list in the TDX entry.

Posted by Kirill A. Shutemov 3 months ago

Include files that were previously missed in the TDX entry file list.
It also includes the recently added KVM enabling.

Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
---
 MAINTAINERS | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 993ab3d3fde9..8071871ea59c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -26952,12 +26952,18 @@ L:	linux-coco@lists.linux.dev
 S:	Supported
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/tdx
 F:	Documentation/ABI/testing/sysfs-devices-virtual-misc-tdx_guest
+F:	Documentation/arch/x86/tdx.rst
+F:	Documentation/virt/coco/tdx-guest.rst
+F:	Documentation/virt/kvm/x86/intel-tdx.rst
 F:	arch/x86/boot/compressed/tdx*
+F:	arch/x86/boot/compressed/tdcall.S
 F:	arch/x86/coco/tdx/
-F:	arch/x86/include/asm/shared/tdx.h
-F:	arch/x86/include/asm/tdx.h
+F:	arch/x86/include/asm/shared/tdx*
+F:	arch/x86/include/asm/tdx*
+F:	arch/x86/kvm/vmx/tdx*
 F:	arch/x86/virt/vmx/tdx/
-F:	drivers/virt/coco/tdx-guest
+F:	drivers/virt/coco/tdx-guest/
+F:	tools/testing/selftests/tdx/
 
 X86 VDSO
 M:	Andy Lutomirski <luto@kernel.org>
-- 
2.47.2

Re: [PATCH 1/3] MAINTAINERS: Update the file list in the TDX entry.

Posted by Xiaoyao Li 3 months ago

On 7/8/2025 6:19 PM, Kirill A. Shutemov wrote:
> Include files that were previously missed in the TDX entry file list.
> It also includes the recently added KVM enabling.

Side topic:

Could we add kvm maillist to the "L:" ?

So that KVM people can be aware of the changes on TDX.

> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
>   MAINTAINERS | 12 +++++++++---
>   1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 993ab3d3fde9..8071871ea59c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -26952,12 +26952,18 @@ L:	linux-coco@lists.linux.dev
>   S:	Supported
>   T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/tdx
>   F:	Documentation/ABI/testing/sysfs-devices-virtual-misc-tdx_guest
> +F:	Documentation/arch/x86/tdx.rst
> +F:	Documentation/virt/coco/tdx-guest.rst
> +F:	Documentation/virt/kvm/x86/intel-tdx.rst
>   F:	arch/x86/boot/compressed/tdx*
> +F:	arch/x86/boot/compressed/tdcall.S
>   F:	arch/x86/coco/tdx/
> -F:	arch/x86/include/asm/shared/tdx.h
> -F:	arch/x86/include/asm/tdx.h
> +F:	arch/x86/include/asm/shared/tdx*
> +F:	arch/x86/include/asm/tdx*
> +F:	arch/x86/kvm/vmx/tdx*
>   F:	arch/x86/virt/vmx/tdx/
> -F:	drivers/virt/coco/tdx-guest
> +F:	drivers/virt/coco/tdx-guest/
> +F:	tools/testing/selftests/tdx/
>   
>   X86 VDSO
>   M:	Andy Lutomirski <luto@kernel.org>

Re: [PATCH 1/3] MAINTAINERS: Update the file list in the TDX entry.

Posted by Dave Hansen 3 months ago

On 7/8/25 20:31, Xiaoyao Li wrote:
> On 7/8/2025 6:19 PM, Kirill A. Shutemov wrote:
>> Include files that were previously missed in the TDX entry file list.
>> It also includes the recently added KVM enabling.
> 
> Side topic:
> 
> Could we add kvm maillist to the "L:" ?

Sure, but send another patch please.

Re: [PATCH 1/3] MAINTAINERS: Update the file list in the TDX entry.

Posted by Kirill A. Shutemov 3 months ago

On Tue, Jul 08, 2025 at 09:26:21PM -0700, Dave Hansen wrote:
> On 7/8/25 20:31, Xiaoyao Li wrote:
> > On 7/8/2025 6:19 PM, Kirill A. Shutemov wrote:
> >> Include files that were previously missed in the TDX entry file list.
> >> It also includes the recently added KVM enabling.
> > 
> > Side topic:
> > 
> > Could we add kvm maillist to the "L:" ?
> 
> Sure, but send another patch please.

Xiaoyao, do you want to send a patch, or should I?

-- 
  Kiryl Shutsemau / Kirill A. Shutemov

Re: [PATCH 1/3] MAINTAINERS: Update the file list in the TDX entry.

Posted by Xiaoyao Li 3 months ago

On 7/9/2025 9:31 PM, Kirill A. Shutemov wrote:
> On Tue, Jul 08, 2025 at 09:26:21PM -0700, Dave Hansen wrote:
>> On 7/8/25 20:31, Xiaoyao Li wrote:
>>> On 7/8/2025 6:19 PM, Kirill A. Shutemov wrote:
>>>> Include files that were previously missed in the TDX entry file list.
>>>> It also includes the recently added KVM enabling.
>>>
>>> Side topic:
>>>
>>> Could we add kvm maillist to the "L:" ?
>>
>> Sure, but send another patch please.
> 
> Xiaoyao, do you want to send a patch, or should I?
> 

I just sent the patch.

Thanks!

Re: [PATCH 1/3] MAINTAINERS: Update the file list in the TDX entry.

Posted by Dave Hansen 3 months ago

On 7/8/25 03:19, Kirill A. Shutemov wrote:
> @@ -26952,12 +26952,18 @@ L:	linux-coco@lists.linux.dev
>  S:	Supported
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/tdx
>  F:	Documentation/ABI/testing/sysfs-devices-virtual-misc-tdx_guest
> +F:	Documentation/arch/x86/tdx.rst
> +F:	Documentation/virt/coco/tdx-guest.rst
> +F:	Documentation/virt/kvm/x86/intel-tdx.rst
>  F:	arch/x86/boot/compressed/tdx*
> +F:	arch/x86/boot/compressed/tdcall.S
>  F:	arch/x86/coco/tdx/
> -F:	arch/x86/include/asm/shared/tdx.h
> -F:	arch/x86/include/asm/tdx.h
> +F:	arch/x86/include/asm/shared/tdx*
> +F:	arch/x86/include/asm/tdx*
> +F:	arch/x86/kvm/vmx/tdx*
>  F:	arch/x86/virt/vmx/tdx/
> -F:	drivers/virt/coco/tdx-guest
> +F:	drivers/virt/coco/tdx-guest/
> +F:	tools/testing/selftests/tdx/

That file list is getting a bit long, but it _is_ the truth.

It's also adding some arch/x86/kvm/vmx/ files, but I assume Sean and
Paolo will welcome having some more people cc'd on those patches. The
hyper-v folks have a similar entry.

I'll plan to apply this as-is unless someone screams.

Re: [PATCH 1/3] MAINTAINERS: Update the file list in the TDX entry.

Posted by Sean Christopherson 3 months ago

On Tue, Jul 08, 2025, Dave Hansen wrote:
> On 7/8/25 03:19, Kirill A. Shutemov wrote:
> > @@ -26952,12 +26952,18 @@ L:	linux-coco@lists.linux.dev
> >  S:	Supported
> >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/tdx
> >  F:	Documentation/ABI/testing/sysfs-devices-virtual-misc-tdx_guest
> > +F:	Documentation/arch/x86/tdx.rst
> > +F:	Documentation/virt/coco/tdx-guest.rst
> > +F:	Documentation/virt/kvm/x86/intel-tdx.rst
> >  F:	arch/x86/boot/compressed/tdx*
> > +F:	arch/x86/boot/compressed/tdcall.S
> >  F:	arch/x86/coco/tdx/
> > -F:	arch/x86/include/asm/shared/tdx.h
> > -F:	arch/x86/include/asm/tdx.h
> > +F:	arch/x86/include/asm/shared/tdx*
> > +F:	arch/x86/include/asm/tdx*
> > +F:	arch/x86/kvm/vmx/tdx*
> >  F:	arch/x86/virt/vmx/tdx/
> > -F:	drivers/virt/coco/tdx-guest
> > +F:	drivers/virt/coco/tdx-guest/
> > +F:	tools/testing/selftests/tdx/
> 
> That file list is getting a bit long, but it _is_ the truth.

What about adding

K:	tdx

instead of listing each file individually?  That might also help clarify what's
up for cases where there is overlap, e.g. with KVM, to convey that this is a
"secondary" entry of sorts.

> It's also adding some arch/x86/kvm/vmx/ files, but I assume Sean and
> Paolo will welcome having some more people cc'd on those patches. The
> hyper-v folks have a similar entry.

No objection from me.

> I'll plan to apply this as-is unless someone screams.

Re: [PATCH 1/3] MAINTAINERS: Update the file list in the TDX entry.

Posted by Dave Hansen 3 months ago

On 7/8/25 07:24, Sean Christopherson wrote:
>> That file list is getting a bit long, but it _is_ the truth.
> What about adding
> 
> K:	tdx
> 
> instead of listing each file individually?  That might also help clarify what's
> up for cases where there is overlap, e.g. with KVM, to convey that this is a
> "secondary" entry of sorts.

Good idea. There are a couple of "tdx" things in the tree that aren't
TDX, but:

N:	tdx
K:	\b(tdx)

seems like it might be a _bit_ more precise. I don't see any filenames
with "tdx" in them that are false positives.