reset: eyeq: fix OF node leak

[PATCH] reset: eyeq: fix OF node leak

Posted by Johan Hovold 3 months ago

Make sure to drop the OF node reference taken when probing the auxiliary
device when the device is later unbound.

Fixes: 487b1b32e317 ("reset: eyeq: add platform driver")
Cc: Théo Lebrun <theo.lebrun@bootlin.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/reset/reset-eyeq.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/reset/reset-eyeq.c b/drivers/reset/reset-eyeq.c
index 02d50041048b..2d3998368a1c 100644
--- a/drivers/reset/reset-eyeq.c
+++ b/drivers/reset/reset-eyeq.c
@@ -410,6 +410,13 @@ static int eqr_of_xlate_twocells(struct reset_controller_dev *rcdev,
 	return eqr_of_xlate_internal(rcdev, reset_spec->args[0], reset_spec->args[1]);
 }
 
+static void eqr_of_node_put(void *_dev)
+{
+	struct device *dev = _dev;
+
+	of_node_put(dev->of_node);
+}
+
 static int eqr_probe(struct auxiliary_device *adev,
 		     const struct auxiliary_device_id *id)
 {
@@ -428,6 +435,10 @@ static int eqr_probe(struct auxiliary_device *adev,
 	if (!dev->of_node)
 		return -ENODEV;
 
+	ret = devm_add_action_or_reset(dev, eqr_of_node_put, dev);
+	if (ret)
+		return ret;
+
 	/*
 	 * Using our newfound OF node, we can get match data. We cannot use
 	 * device_get_match_data() because it does not match reused OF nodes.
-- 
2.49.0

Re: [PATCH] reset: eyeq: fix OF node leak

Posted by Philipp Zabel 1 month, 1 week ago

On Di, 2025-07-08 at 10:56 +0200, Johan Hovold wrote:
> Make sure to drop the OF node reference taken when probing the auxiliary
> device when the device is later unbound.
> 
> Fixes: 487b1b32e317 ("reset: eyeq: add platform driver")
> Cc: Théo Lebrun <theo.lebrun@bootlin.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp

Re: [PATCH] reset: eyeq: fix OF node leak

Posted by Johan Hovold 1 month, 1 week ago

On Tue, Jul 08, 2025 at 10:56:13AM +0200, Johan Hovold wrote:
> Make sure to drop the OF node reference taken when probing the auxiliary
> device when the device is later unbound.
> 
> Fixes: 487b1b32e317 ("reset: eyeq: add platform driver")
> Cc: Théo Lebrun <theo.lebrun@bootlin.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>

Can this one be picked up?

Johan

Re: [PATCH] reset: eyeq: fix OF node leak

Posted by Philipp Zabel 1 month, 1 week ago

On Mi, 2025-08-27 at 11:48 +0200, Johan Hovold wrote:
> On Tue, Jul 08, 2025 at 10:56:13AM +0200, Johan Hovold wrote:
> > Make sure to drop the OF node reference taken when probing the auxiliary
> > device when the device is later unbound.
> > 
> > Fixes: 487b1b32e317 ("reset: eyeq: add platform driver")
> > Cc: Théo Lebrun <theo.lebrun@bootlin.com>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> 
> Can this one be picked up?

Thank you for the reminder, applied to reset/fixes.

[1/1] reset: eyeq: fix OF node leak
      https://git.pengutronix.de/cgit/pza/linux/commit/?id=9a52827a9bbb

regards
Philipp