1. Patchew
  2. linux
  3. View series

[PATCH] net: usb: enable the work after stop usbnet by ip down/up

Jun Miao posted 1 patch 3 months ago 
drivers/net/usb/usbnet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] net: usb: enable the work after stop usbnet by ip down/up
Posted by Jun Miao 3 months ago 
From: Zqiang <qiang.zhang@linux.dev>

Oleksij reported that:
The smsc95xx driver fails after one down/up cycle, like this:
 $ nmcli device set enu1u1 managed no
 $ p a a 10.10.10.1/24 dev enu1u1
 $ ping -c 4 10.10.10.3
 $ ip l s dev enu1u1 down
 $ ip l s dev enu1u1 up
 $ ping -c 4 10.10.10.3
The second ping does not reach the host. Networking also fails on other interfaces.

Enable the work by replacing the disable_work_sync() with cancel_work_sync().

[Jun Miao: completely write the commit changelog]

Fixes: 2c04d279e857 ("net: usb: Convert tasklet API to new bottom half workqueue mechanism")
Reported-by: Oleksij Rempel <o.rempel@pengutronix.de>
Tested-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Zqiang <qiang.zhang@linux.dev>
Signed-off-by: Jun Miao <jun.miao@intel.com>
---
 drivers/net/usb/usbnet.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 9564478a79cc..6a3cca104af9 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -861,14 +861,14 @@ int usbnet_stop (struct net_device *net)
 	/* deferred work (timer, softirq, task) must also stop */
 	dev->flags = 0;
 	timer_delete_sync(&dev->delay);
-	disable_work_sync(&dev->bh_work);
+	cancel_work_sync(&dev->bh_work);
 	cancel_work_sync(&dev->kevent);
 
 	/* We have cyclic dependencies. Those calls are needed
 	 * to break a cycle. We cannot fall into the gaps because
 	 * we have a flag
 	 */
-	disable_work_sync(&dev->bh_work);
+	cancel_work_sync(&dev->bh_work);
 	timer_delete_sync(&dev->delay);
 	cancel_work_sync(&dev->kevent);
 
-- 
2.32.0
Re: [PATCH] net: usb: enable the work after stop usbnet by ip down/up
Posted by Oleksij Rempel 3 months ago 
Hi Jun,

please resend this patch with the name [PATCH net-next] and add all related
people suggested by scripts/get_maintainer.pl.

./scripts/get_maintainer.pl drivers/net/usb/usbnet.c 
Oliver Neukum <oneukum@suse.com> (maintainer:USB "USBNET" DRIVER FRAMEWORK)
Andrew Lunn <andrew+netdev@lunn.ch> (maintainer:NETWORKING DRIVERS)
"David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING DRIVERS)
Eric Dumazet <edumazet@google.com> (maintainer:NETWORKING DRIVERS)
Jakub Kicinski <kuba@kernel.org> (maintainer:NETWORKING DRIVERS)
Paolo Abeni <pabeni@redhat.com> (maintainer:NETWORKING DRIVERS)
netdev@vger.kernel.org (open list:USB "USBNET" DRIVER FRAMEWORK)
linux-usb@vger.kernel.org (open list:USB NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)

Best Regards,
Oleksij

On Tue, Jul 08, 2025 at 04:16:53PM +0800, Jun Miao wrote:
> From: Zqiang <qiang.zhang@linux.dev>
> 
> Oleksij reported that:
> The smsc95xx driver fails after one down/up cycle, like this:
>  $ nmcli device set enu1u1 managed no
>  $ p a a 10.10.10.1/24 dev enu1u1
>  $ ping -c 4 10.10.10.3
>  $ ip l s dev enu1u1 down
>  $ ip l s dev enu1u1 up
>  $ ping -c 4 10.10.10.3
> The second ping does not reach the host. Networking also fails on other interfaces.
> 
> Enable the work by replacing the disable_work_sync() with cancel_work_sync().
> 
> [Jun Miao: completely write the commit changelog]
> 
> Fixes: 2c04d279e857 ("net: usb: Convert tasklet API to new bottom half workqueue mechanism")
> Reported-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Tested-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Signed-off-by: Zqiang <qiang.zhang@linux.dev>
> Signed-off-by: Jun Miao <jun.miao@intel.com>
> ---
>  drivers/net/usb/usbnet.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
> index 9564478a79cc..6a3cca104af9 100644
> --- a/drivers/net/usb/usbnet.c
> +++ b/drivers/net/usb/usbnet.c
> @@ -861,14 +861,14 @@ int usbnet_stop (struct net_device *net)
>  	/* deferred work (timer, softirq, task) must also stop */
>  	dev->flags = 0;
>  	timer_delete_sync(&dev->delay);
> -	disable_work_sync(&dev->bh_work);
> +	cancel_work_sync(&dev->bh_work);
>  	cancel_work_sync(&dev->kevent);
>  
>  	/* We have cyclic dependencies. Those calls are needed
>  	 * to break a cycle. We cannot fall into the gaps because
>  	 * we have a flag
>  	 */
> -	disable_work_sync(&dev->bh_work);
> +	cancel_work_sync(&dev->bh_work);
>  	timer_delete_sync(&dev->delay);
>  	cancel_work_sync(&dev->kevent);
>  
> -- 
> 2.32.0
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
RE: [PATCH] net: usb: enable the work after stop usbnet by ip down/up
Posted by Miao, Jun 3 months ago 
>
>Hi Jun,
>
>please resend this patch with the name [PATCH net-next] and add all related
>people suggested by scripts/get_maintainer.pl.
>
Ok, I will resend again.
If you have any suggestions for patch commits, please tell me ?

Thanks 
Jun.Miao



>./scripts/get_maintainer.pl drivers/net/usb/usbnet.c Oliver Neukum
><oneukum@suse.com> (maintainer:USB "USBNET" DRIVER FRAMEWORK)
>Andrew Lunn <andrew+netdev@lunn.ch> (maintainer:NETWORKING DRIVERS)
>"David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING DRIVERS)
>Eric Dumazet <edumazet@google.com> (maintainer:NETWORKING DRIVERS)
>Jakub Kicinski <kuba@kernel.org> (maintainer:NETWORKING DRIVERS) Paolo
>Abeni <pabeni@redhat.com> (maintainer:NETWORKING DRIVERS)
>netdev@vger.kernel.org (open list:USB "USBNET" DRIVER FRAMEWORK) linux-
>usb@vger.kernel.org (open list:USB NETWORKING DRIVERS) linux-
>kernel@vger.kernel.org (open list)
>
>Best Regards,
>Oleksij
>
>On Tue, Jul 08, 2025 at 04:16:53PM +0800, Jun Miao wrote:
>> From: Zqiang <qiang.zhang@linux.dev>
>>
>> Oleksij reported that:
>> The smsc95xx driver fails after one down/up cycle, like this:
>>  $ nmcli device set enu1u1 managed no
>>  $ p a a 10.10.10.1/24 dev enu1u1
>>  $ ping -c 4 10.10.10.3
>>  $ ip l s dev enu1u1 down
>>  $ ip l s dev enu1u1 up
>>  $ ping -c 4 10.10.10.3
>> The second ping does not reach the host. Networking also fails on other
>interfaces.
>>
>> Enable the work by replacing the disable_work_sync() with
>cancel_work_sync().
>>
>> [Jun Miao: completely write the commit changelog]
>>
>> Fixes: 2c04d279e857 ("net: usb: Convert tasklet API to new bottom half
>> workqueue mechanism")
>> Reported-by: Oleksij Rempel <o.rempel@pengutronix.de>
>> Tested-by: Oleksij Rempel <o.rempel@pengutronix.de>
>> Signed-off-by: Zqiang <qiang.zhang@linux.dev>
>> Signed-off-by: Jun Miao <jun.miao@intel.com>
>> ---
>>  drivers/net/usb/usbnet.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index
>> 9564478a79cc..6a3cca104af9 100644
>> --- a/drivers/net/usb/usbnet.c
>> +++ b/drivers/net/usb/usbnet.c
>> @@ -861,14 +861,14 @@ int usbnet_stop (struct net_device *net)
>>  	/* deferred work (timer, softirq, task) must also stop */
>>  	dev->flags = 0;
>>  	timer_delete_sync(&dev->delay);
>> -	disable_work_sync(&dev->bh_work);
>> +	cancel_work_sync(&dev->bh_work);
>>  	cancel_work_sync(&dev->kevent);
>>
>>  	/* We have cyclic dependencies. Those calls are needed
>>  	 * to break a cycle. We cannot fall into the gaps because
>>  	 * we have a flag
>>  	 */
>> -	disable_work_sync(&dev->bh_work);
>> +	cancel_work_sync(&dev->bh_work);
>>  	timer_delete_sync(&dev->delay);
>>  	cancel_work_sync(&dev->kevent);
>>
>> --
>> 2.32.0
>>
>>
>
>--
>Pengutronix e.K.                           |                             |
>Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
>31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
>Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.