[PATCH v3 3/3] dt-bindings: leds: issi,is31fl3236: add issi,22kHz-pwm property

Pawel Zalewski posted 3 patches 3 months ago
There is a newer version of this series
[PATCH v3 3/3] dt-bindings: leds: issi,is31fl3236: add issi,22kHz-pwm property
Posted by Pawel Zalewski 3 months ago
Add an additional and optional control property for setting
the output PWM frequency to 22kHz. The default is 3kHz and
this option puts the operational frequency outside of the
audible range.

Signed-off-by: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>
---
 Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml b/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml
index d0f9add5af01ac06c4bb87b0cd0faec71d0ef37c..5bce0fc48f84c7ae804e6522e312c51ed2d77bc5 100644
--- a/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml
+++ b/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml
@@ -42,6 +42,12 @@ properties:
   "#size-cells":
     const: 0
 
+  issi,22kHz-pwm:
+    type: boolean
+    description:
+      When present, the chip's PWM will operate at ~22kHz as opposed
+      to ~3kHz to move the operating frequency out of the audible range.
+
 patternProperties:
   "^led@[1-9a-f]+$":
     type: object

-- 
2.48.1
Re: [PATCH v3 3/3] dt-bindings: leds: issi,is31fl3236: add issi,22kHz-pwm property
Posted by Krzysztof Kozlowski 3 months ago
On Tue, Jul 08, 2025 at 03:59:47PM +0100, Pawel Zalewski wrote:
> Add an additional and optional control property for setting
> the output PWM frequency to 22kHz. The default is 3kHz and
> this option puts the operational frequency outside of the
> audible range.
> 
> Signed-off-by: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>
> ---
>  Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml b/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml
> index d0f9add5af01ac06c4bb87b0cd0faec71d0ef37c..5bce0fc48f84c7ae804e6522e312c51ed2d77bc5 100644
> --- a/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml
> +++ b/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml
> @@ -42,6 +42,12 @@ properties:
>    "#size-cells":
>      const: 0
>  
> +  issi,22kHz-pwm:
> +    type: boolean
> +    description:
> +      When present, the chip's PWM will operate at ~22kHz as opposed
> +      to ~3kHz to move the operating frequency out of the audible range.
> +

According to your driver this is not applicable to every device, so you
need allOf:if:then: block at the end, before additionalProperties,
restricting it per variant:

.....
  then:
    properties:
      issi,22kHz-pwm: false

If that's not true, then commit msg should explain that - from the
hardware perspective.

Best regards,
Krzysztof