From: Lucca Fachinetti <luccafachinetti@gmail.com>
Keep the old maintainers field as is.
Add datasheets for reference, NB that I was not able to find an
up-to-date, funtional direct URL for si-en products datasheet
so they were skipped.
Signed-off-by: Lucca Fachinetti <luccafachinetti@gmail.com>
Co-developed-by: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>
Signed-off-by: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>
---
.../devicetree/bindings/leds/issi,is31fl3236.yaml | 98 ++++++++++++++++++++++
.../devicetree/bindings/leds/leds-is31fl32xx.txt | 52 ------------
2 files changed, 98 insertions(+), 52 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml b/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..d0f9add5af01ac06c4bb87b0cd0faec71d0ef37c
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml
@@ -0,0 +1,98 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/issi,is31fl3236.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: is31fl32xx and Si-En SN32xx IC LED driver
+
+maintainers:
+ - Pavel Machek <pavel@ucw.cz>
+ - Lee Jones <lee@kernel.org>
+
+description: |
+ The is31fl32xx/SN32xx family of LED drivers are I2C devices with multiple
+ constant-current channels, each with independent 256-level PWM control.
+ Each LED is represented as a sub-node of the device.
+
+ For more product information please see the links below:
+ https://www.lumissil.com/assets/pdf/core/IS31FL3236_DS.pdf
+ https://www.lumissil.com/assets/pdf/core/IS31FL3236A_DS.pdf
+ https://www.lumissil.com/assets/pdf/core/IS31FL3235_DS.pdf
+ https://www.lumissil.com/assets/pdf/core/IS31FL3218_DS.pdf
+ https://www.lumissil.com/assets/pdf/core/IS31FL3216_DS.pdf
+
+properties:
+ compatible:
+ enum:
+ - issi,is31fl3236
+ - issi,is31fl3236a
+ - issi,is31fl3235
+ - issi,is31fl3218
+ - issi,is31fl3216
+ - si-en,sn3218
+ - si-en,sn3216
+
+ reg:
+ maxItems: 1
+
+ '#address-cells':
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+patternProperties:
+ "^led@[1-9a-f]+$":
+ type: object
+ $ref: common.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ reg:
+ description:
+ LED channel number (1..N)
+ minimum: 1
+ maximum: 36
+
+ required:
+ - reg
+
+required:
+ - compatible
+ - reg
+ - "#size-cells"
+ - "#address-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/leds/common.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ led-controller@3c {
+ compatible = "issi,is31fl3236";
+ reg = <0x3c>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ led@1 {
+ reg = <0x1>;
+ label = "led1:red";
+ };
+ led@2 {
+ reg = <0x2>;
+ label = "led1:green";
+ };
+ led@3 {
+ reg = <0x3>;
+ label = "led1:blue";
+ };
+ };
+ };
+...
+
diff --git a/Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt b/Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt
deleted file mode 100644
index 926c2117942c4dc200fcd68156864f544b11a326..0000000000000000000000000000000000000000
--- a/Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt
+++ /dev/null
@@ -1,52 +0,0 @@
-Binding for ISSI IS31FL32xx and Si-En SN32xx LED Drivers
-
-The IS31FL32xx/SN32xx family of LED drivers are I2C devices with multiple
-constant-current channels, each with independent 256-level PWM control.
-Each LED is represented as a sub-node of the device.
-
-Required properties:
-- compatible: one of
- issi,is31fl3236
- issi,is31fl3235
- issi,is31fl3218
- issi,is31fl3216
- si-en,sn3218
- si-en,sn3216
-- reg: I2C slave address
-- address-cells : must be 1
-- size-cells : must be 0
-
-LED sub-node properties:
-- reg : LED channel number (1..N)
-- label : (optional)
- see Documentation/devicetree/bindings/leds/common.txt
-- linux,default-trigger : (optional)
- see Documentation/devicetree/bindings/leds/common.txt
-
-
-Example:
-
-is31fl3236: led-controller@3c {
- compatible = "issi,is31fl3236";
- reg = <0x3c>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- led@1 {
- reg = <1>;
- label = "EB:blue:usr0";
- };
- led@2 {
- reg = <2>;
- label = "EB:blue:usr1";
- };
- ...
- led@36 {
- reg = <36>;
- label = "EB:blue:usr35";
- };
-};
-
-For more product information please see the links below:
-http://www.issi.com/US/product-analog-fxled-driver.shtml
-http://www.si-en.com/product.asp?parentid=890
--
2.48.1On Tue, Jul 08, 2025 at 03:59:46PM +0100, Pawel Zalewski wrote: > From: Lucca Fachinetti <luccafachinetti@gmail.com> > > Keep the old maintainers field as is. > Add datasheets for reference, NB that I was not able to find an > up-to-date, funtional direct URL for si-en products datasheet > so they were skipped. > > Signed-off-by: Lucca Fachinetti <luccafachinetti@gmail.com> > Co-developed-by: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk> > Signed-off-by: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk> > --- > .../devicetree/bindings/leds/issi,is31fl3236.yaml | 98 ++++++++++++++++++++++ > .../devicetree/bindings/leds/leds-is31fl32xx.txt | 52 ------------ > 2 files changed, 98 insertions(+), 52 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml b/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..d0f9add5af01ac06c4bb87b0cd0faec71d0ef37c > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml > @@ -0,0 +1,98 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/issi,is31fl3236.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: is31fl32xx and Si-En SN32xx IC LED driver Driver as Linux driver or LED driver? If the first, then drop. > + > +maintainers: > + - Pavel Machek <pavel@ucw.cz> > + - Lee Jones <lee@kernel.org> These should be people interested in this hardware, not subsystem maintainers. > + > +description: | > + The is31fl32xx/SN32xx family of LED drivers are I2C devices with multiple > + constant-current channels, each with independent 256-level PWM control. > + Each LED is represented as a sub-node of the device. > + > + For more product information please see the links below: > + https://www.lumissil.com/assets/pdf/core/IS31FL3236_DS.pdf > + https://www.lumissil.com/assets/pdf/core/IS31FL3236A_DS.pdf > + https://www.lumissil.com/assets/pdf/core/IS31FL3235_DS.pdf > + https://www.lumissil.com/assets/pdf/core/IS31FL3218_DS.pdf > + https://www.lumissil.com/assets/pdf/core/IS31FL3216_DS.pdf > + > +properties: > + compatible: > + enum: > + - issi,is31fl3236 > + - issi,is31fl3236a > + - issi,is31fl3235 > + - issi,is31fl3218 > + - issi,is31fl3216 > + - si-en,sn3218 > + - si-en,sn3216 > + > + reg: > + maxItems: 1 > + > + '#address-cells': > + const: 1 > + > + "#size-cells": Keep consistent quotes, either " or '. You made different choice for the same properties even... > + const: 0 > + > +patternProperties: > + "^led@[1-9a-f]+$": Pattern does not match entirely the reg constraints. 36 is 0x24. Best regards, Krzysztof
> Driver as Linux driver or LED driver? If the first, then drop. LED driver, might not be obvious, could change to controller, however the datasheet refers to the device "LED driver". > These should be people interested in this hardware, not subsystem > maintainers. I will let maintainers decide who should be included here perhaps ? > Keep consistent quotes, either " or '. You made different choice for the > same properties even... Copied over from original poster, have not spotted that before, thanks. > Pattern does not match entirely the reg constraints. 36 is 0x24. Pattern allows for one or more hexadecimal values starting from 1, so the second number should start from zero is the second error here. Thanks !
On 14/07/2025 11:16, Pawel Zalewski wrote: > >> Pattern does not match entirely the reg constraints. 36 is 0x24. > > Pattern allows for one or more hexadecimal values starting from 1, > so the second number should start from zero is the second error here. You cut entire context so I really do not know how the code looks like. Anyway, they do not match and this needs to be fixed. Best regards, Krzysztof
On Tue, Jul 08, 2025 at 03:59:46PM +0100, Pawel Zalewski wrote: > From: Lucca Fachinetti <luccafachinetti@gmail.com> > > Keep the old maintainers field as is. I don't understand this. There were no old maintainers of this binding and driver. Best regards, Krzysztof
© 2016 - 2025 Red Hat, Inc.