[PATCH 2/2] arm64: defconfig: enable i.MX AIPSTZ driver

Laurentiu Mihalcea posted 2 patches 3 months ago
[PATCH 2/2] arm64: defconfig: enable i.MX AIPSTZ driver
Posted by Laurentiu Mihalcea 3 months ago
From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>

Enable the config (CONFIG_IMX_AIPSTZ) for the i.MX AIPSTZ driver, which
is required for platforms using the AIPSTZ bridge (e.g. i.MX8MP).

Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 739b19302865..4d7a60444bf5 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -262,6 +262,7 @@ CONFIG_GOOGLE_FIRMWARE=y
 CONFIG_GOOGLE_CBMEM=m
 CONFIG_GOOGLE_COREBOOT_TABLE=m
 CONFIG_EFI_CAPSULE_LOADER=y
+CONFIG_IMX_AIPSTZ=y
 CONFIG_IMX_SCU=y
 CONFIG_QCOM_TZMEM_MODE_SHMBRIDGE=y
 CONFIG_QCOM_QSEECOM=y
-- 
2.34.1
Re: [PATCH 2/2] arm64: defconfig: enable i.MX AIPSTZ driver
Posted by Alexander Stein 3 months ago
Hi,

Am Dienstag, 8. Juli 2025, 01:46:28 CEST schrieb Laurentiu Mihalcea:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> 
> Enable the config (CONFIG_IMX_AIPSTZ) for the i.MX AIPSTZ driver, which
> is required for platforms using the AIPSTZ bridge (e.g. i.MX8MP).
> 
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 739b19302865..4d7a60444bf5 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -262,6 +262,7 @@ CONFIG_GOOGLE_FIRMWARE=y
>  CONFIG_GOOGLE_CBMEM=m
>  CONFIG_GOOGLE_COREBOOT_TABLE=m
>  CONFIG_EFI_CAPSULE_LOADER=y
> +CONFIG_IMX_AIPSTZ=y

Why not =m?

Best regards
Alexander

>  CONFIG_IMX_SCU=y
>  CONFIG_QCOM_TZMEM_MODE_SHMBRIDGE=y
>  CONFIG_QCOM_QSEECOM=y
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
Re: [PATCH 2/2] arm64: defconfig: enable i.MX AIPSTZ driver
Posted by Laurentiu Mihalcea 2 months, 1 week ago

On 7/8/2025 8:42 AM, Alexander Stein wrote:
> Hi,
>
> Am Dienstag, 8. Juli 2025, 01:46:28 CEST schrieb Laurentiu Mihalcea:
>> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>>
>> Enable the config (CONFIG_IMX_AIPSTZ) for the i.MX AIPSTZ driver, which
>> is required for platforms using the AIPSTZ bridge (e.g. i.MX8MP).
>>
>> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>> ---
>>  arch/arm64/configs/defconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index 739b19302865..4d7a60444bf5 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -262,6 +262,7 @@ CONFIG_GOOGLE_FIRMWARE=y
>>  CONFIG_GOOGLE_CBMEM=m
>>  CONFIG_GOOGLE_COREBOOT_TABLE=m
>>  CONFIG_EFI_CAPSULE_LOADER=y
>> +CONFIG_IMX_AIPSTZ=y
> Why not =m?

well, the thought process here was that since the audio block control driver (i.e.: clk-imx8mp-audiomix.c)
is compiled as built-in (CONFIG_CLK_IMX8MP=y) we'd want to have the bridge as built-in too so as to not
defer the probe of the clock provider and its consumers (in case there's any compiled as built-in).

however, the bridge driver could have just as well been compiled as a module so any of the two approaches
is fine with me.

>
> Best regards
> Alexander
>
>>  CONFIG_IMX_SCU=y
>>  CONFIG_QCOM_TZMEM_MODE_SHMBRIDGE=y
>>  CONFIG_QCOM_QSEECOM=y
>>
>
Re: [PATCH 2/2] arm64: defconfig: enable i.MX AIPSTZ driver
Posted by Fabio Estevam 3 months ago
On Mon, Jul 7, 2025 at 8:46 PM Laurentiu Mihalcea
<laurentiumihalcea111@gmail.com> wrote:
>
> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>
> Enable the config (CONFIG_IMX_AIPSTZ) for the i.MX AIPSTZ driver, which
> is required for platforms using the AIPSTZ bridge (e.g. i.MX8MP).

Shouldn't this be enabled via a select in Kconfig instead?
Re: [PATCH 2/2] arm64: defconfig: enable i.MX AIPSTZ driver
Posted by Laurentiu Mihalcea 2 months, 1 week ago

On 7/8/2025 4:39 AM, Fabio Estevam wrote:
> On Mon, Jul 7, 2025 at 8:46 PM Laurentiu Mihalcea
> <laurentiumihalcea111@gmail.com> wrote:
>> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>>
>> Enable the config (CONFIG_IMX_AIPSTZ) for the i.MX AIPSTZ driver, which
>> is required for platforms using the AIPSTZ bridge (e.g. i.MX8MP).
> Shouldn't this be enabled via a select in Kconfig instead?

would've been nice but I'm not sure we have an i.MX8MP SoC-specific config option for that?
or do you have anything particular in your mind?