dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus

[PATCH] dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus

Posted by Matthew Gerlach 3 months ago

Add missing 'minItems: 1' to iommus property of the Altera SOCFPGA SoC
implementation of the Synopsys DWMAC.

Fixes: 6d359cf464f4 ("dt-bindings: net: Convert socfpga-dwmac bindings to yaml")
Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
---
 Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
index c5d8dfe5b801..ec34daff2aa0 100644
--- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
+++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
@@ -59,6 +59,7 @@ properties:
       - const: ptp_ref
 
   iommus:
+    minItems: 1
     maxItems: 2
 
   phy-mode:
-- 
2.49.0

Re: [PATCH] dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus

Posted by Krzysztof Kozlowski 3 months ago

On 07/07/2025 17:44, Matthew Gerlach wrote:
> Add missing 'minItems: 1' to iommus property of the Altera SOCFPGA SoC
> implementation of the Synopsys DWMAC.

Why? Explain why you are doing thing, not what you are doing. What is
obvious which makes entire two-line commit msg redundant and useless.

Original binding had no iommus and referenced commit does not explain
why they appeared during conversion in the first place.

> 
> Fixes: 6d359cf464f4 ("dt-bindings: net: Convert socfpga-dwmac bindings to yaml")
> Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
> ---
>  Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> index c5d8dfe5b801..ec34daff2aa0 100644
> --- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> +++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> @@ -59,6 +59,7 @@ properties:
>        - const: ptp_ref
>  
>    iommus:
> +    minItems: 1
>      maxItems: 2

Why this has to be flexible on given SoC? This is weird. Same hardware
differs somehow?

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus

Posted by Matthew Gerlach 2 months, 4 weeks ago


On 7/8/25 11:54 PM, Krzysztof Kozlowski wrote:
> On 07/07/2025 17:44, Matthew Gerlach wrote:
> > Add missing 'minItems: 1' to iommus property of the Altera SOCFPGA SoC
> > implementation of the Synopsys DWMAC.
>
> Why? Explain why you are doing thing, not what you are doing. What is
> obvious which makes entire two-line commit msg redundant and useless.
This conversion to yaml was a merge of two separate conversions from 
Ding Nguyen and myself plus some resolved issues highlighted by Rob 
Herring, but I missed the minItems:

https://lore.kernel.org/lkml/20250626234816.GB1398428-robh@kernel.org/

>
> Original binding had no iommus and referenced commit does not explain
> why they appeared during conversion in the first place.
The text version of the binding was created before the device trees for 
the Agilex family, which do support iommus, were accepted into the kernel.
>
> > 
> > Fixes: 6d359cf464f4 ("dt-bindings: net: Convert socfpga-dwmac bindings to yaml")
> > Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
> > ---
> >  Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> > index c5d8dfe5b801..ec34daff2aa0 100644
> > --- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> > @@ -59,6 +59,7 @@ properties:
> >        - const: ptp_ref
> >  
> >    iommus:
> > +    minItems: 1
> >      maxItems: 2
>
> Why this has to be flexible on given SoC? This is weird. Same hardware
> differs somehow?
Dinh can you comment on this binding from 
https://lore.kernel.org/all/20250624191549.474686-1-dinguyen@kernel.org/?

>
> Best regards,
> Krzysztof

Re: [PATCH] dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus

Posted by Dinh Nguyen 2 months, 3 weeks ago

On 7/9/25 17:23, Matthew Gerlach wrote:
> 
> 
> On 7/8/25 11:54 PM, Krzysztof Kozlowski wrote:
>> On 07/07/2025 17:44, Matthew Gerlach wrote:
>> > Add missing 'minItems: 1' to iommus property of the Altera SOCFPGA SoC
>> > implementation of the Synopsys DWMAC.
>>
>> Why? Explain why you are doing thing, not what you are doing. What is
>> obvious which makes entire two-line commit msg redundant and useless.
> This conversion to yaml was a merge of two separate conversions from 
> Ding Nguyen and myself plus some resolved issues highlighted by Rob 
> Herring, but I missed the minItems:
> 
> https://lore.kernel.org/lkml/20250626234816.GB1398428-robh@kernel.org/
> 
>>
>> Original binding had no iommus and referenced commit does not explain
>> why they appeared during conversion in the first place.
> The text version of the binding was created before the device trees for 
> the Agilex family, which do support iommus, were accepted into the kernel.
>>
>> > > Fixes: 6d359cf464f4 ("dt-bindings: net: Convert socfpga-dwmac 
>> bindings to yaml")
>> > Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
>> > ---
>> >  Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml | 1 +
>> >  1 file changed, 1 insertion(+)
>> > > diff --git 
>> a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml 
>> b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
>> > index c5d8dfe5b801..ec34daff2aa0 100644
>> > --- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
>> > +++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
>> > @@ -59,6 +59,7 @@ properties:
>> >        - const: ptp_ref
>> > >    iommus:
>> > +    minItems: 1
>> >      maxItems: 2
>>
>> Why this has to be flexible on given SoC? This is weird. Same hardware
>> differs somehow?
> Dinh can you comment on this binding from 
> https://lore.kernel.org/all/20250624191549.474686-1-dinguyen@kernel.org/?
> 

This might have been a copy/paste error.

DInh

Re: [PATCH] dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus

Posted by Rob Herring (Arm) 3 months ago

On Mon, 07 Jul 2025 08:44:09 -0700, Matthew Gerlach wrote:
> Add missing 'minItems: 1' to iommus property of the Altera SOCFPGA SoC
> implementation of the Synopsys DWMAC.
> 
> Fixes: 6d359cf464f4 ("dt-bindings: net: Convert socfpga-dwmac bindings to yaml")
> Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
> ---
>  Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH] dt-bindings: net: altr,socfpga-stmmac.yaml: add minItems to iommus

Posted by Yanteng Si 3 months ago

在 7/7/25 11:44 PM, Matthew Gerlach 写道:
> Add missing 'minItems: 1' to iommus property of the Altera SOCFPGA SoC
> implementation of the Synopsys DWMAC.
> 
> Fixes: 6d359cf464f4 ("dt-bindings: net: Convert socfpga-dwmac bindings to yaml")
> Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
Reviewed-by: Yanteng Si <siyanteng@cqsoftware.com.cn>

Thanks,
Yanteng
> ---
>   Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> index c5d8dfe5b801..ec34daff2aa0 100644
> --- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> +++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> @@ -59,6 +59,7 @@ properties:
>         - const: ptp_ref
>   
>     iommus:
> +    minItems: 1
>       maxItems: 2
>   
>     phy-mode: