mfd: simple-mfd-i2c: add compatible strings for Layerscape QIXIS FPGA

[PATCH] mfd: simple-mfd-i2c: add compatible strings for Layerscape QIXIS FPGA

Posted by Ioana Ciornei 3 months ago

The QIXIS FPGA found on Layerscape boards such as LX2160AQDS, LS1028AQDS
etc deals with power-on-reset timing, muxing etc. Use the simple-mfd-i2c
as its core driver by adding its compatible string (already found in
some dt files). By using the simple-mfd-i2c driver, any child device
will have access to the i2c regmap created by it.

Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
---
 drivers/mfd/simple-mfd-i2c.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c
index 22159913bea0..f7798bd92222 100644
--- a/drivers/mfd/simple-mfd-i2c.c
+++ b/drivers/mfd/simple-mfd-i2c.c
@@ -99,6 +99,8 @@ static const struct of_device_id simple_mfd_i2c_of_match[] = {
 	{ .compatible = "maxim,max5970", .data = &maxim_max5970},
 	{ .compatible = "maxim,max5978", .data = &maxim_max5970},
 	{ .compatible = "maxim,max77705-battery", .data = &maxim_mon_max77705},
+	{ .compatible = "fsl,lx2160aqds-fpga" },
+	{ .compatible = "fsl,ls1028aqds-fpga" },
 	{}
 };
 MODULE_DEVICE_TABLE(of, simple_mfd_i2c_of_match);
-- 
2.25.1

Re: (subset) [PATCH] mfd: simple-mfd-i2c: add compatible strings for Layerscape QIXIS FPGA

Posted by Lee Jones 2 months, 1 week ago

On Mon, 07 Jul 2025 18:31:20 +0300, Ioana Ciornei wrote:
> The QIXIS FPGA found on Layerscape boards such as LX2160AQDS, LS1028AQDS
> etc deals with power-on-reset timing, muxing etc. Use the simple-mfd-i2c
> as its core driver by adding its compatible string (already found in
> some dt files). By using the simple-mfd-i2c driver, any child device
> will have access to the i2c regmap created by it.
> 
> 
> [...]

Applied, thanks!

[1/1] mfd: simple-mfd-i2c: add compatible strings for Layerscape QIXIS FPGA
      commit: d3a09d5e5ce66a91acfdbcf09d7193d2167b69c9

--
Lee Jones [李琼斯]

Re: (subset) [PATCH] mfd: simple-mfd-i2c: add compatible strings for Layerscape QIXIS FPGA

Posted by Ioana Ciornei 1 month, 3 weeks ago

On Thu, Jul 31, 2025 at 09:59:39AM +0100, Lee Jones wrote:
> On Mon, 07 Jul 2025 18:31:20 +0300, Ioana Ciornei wrote:
> > The QIXIS FPGA found on Layerscape boards such as LX2160AQDS, LS1028AQDS
> > etc deals with power-on-reset timing, muxing etc. Use the simple-mfd-i2c
> > as its core driver by adding its compatible string (already found in
> > some dt files). By using the simple-mfd-i2c driver, any child device
> > will have access to the i2c regmap created by it.
> > 
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/1] mfd: simple-mfd-i2c: add compatible strings for Layerscape QIXIS FPGA
>       commit: d3a09d5e5ce66a91acfdbcf09d7193d2167b69c9

Hi Lee,

What tree should this patch be present in? I did seach
git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for it but no
luck.

Thanks!

Ioana

Re: (subset) [PATCH] mfd: simple-mfd-i2c: add compatible strings for Layerscape QIXIS FPGA

Posted by Lee Jones 1 month, 2 weeks ago

On Wed, 13 Aug 2025, Ioana Ciornei wrote:

> On Thu, Jul 31, 2025 at 09:59:39AM +0100, Lee Jones wrote:
> > On Mon, 07 Jul 2025 18:31:20 +0300, Ioana Ciornei wrote:
> > > The QIXIS FPGA found on Layerscape boards such as LX2160AQDS, LS1028AQDS
> > > etc deals with power-on-reset timing, muxing etc. Use the simple-mfd-i2c
> > > as its core driver by adding its compatible string (already found in
> > > some dt files). By using the simple-mfd-i2c driver, any child device
> > > will have access to the i2c regmap created by it.
> > > 
> > > 
> > > [...]
> > 
> > Applied, thanks!
> > 
> > [1/1] mfd: simple-mfd-i2c: add compatible strings for Layerscape QIXIS FPGA
> >       commit: d3a09d5e5ce66a91acfdbcf09d7193d2167b69c9
> 
> Hi Lee,
> 
> What tree should this patch be present in? I did seach
> git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for it but no
> luck.

It was probably in the staging branch -next-next.

Also the subject line was changed to match the style of the subsystem:

  6aa6f19e7670 ("mfd: simple-mfd-i2c: Add compatible strings for Layerscape QIXIS FPGA")

-- 
Lee Jones [李琼斯]

Re: [PATCH] mfd: simple-mfd-i2c: add compatible strings for Layerscape QIXIS FPGA

Posted by Ioana Ciornei 2 months, 3 weeks ago

On Mon, Jul 07, 2025 at 06:31:20PM +0300, Ioana Ciornei wrote:
> The QIXIS FPGA found on Layerscape boards such as LX2160AQDS, LS1028AQDS
> etc deals with power-on-reset timing, muxing etc. Use the simple-mfd-i2c
> as its core driver by adding its compatible string (already found in
> some dt files). By using the simple-mfd-i2c driver, any child device
> will have access to the i2c regmap created by it.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
>  drivers/mfd/simple-mfd-i2c.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c
> index 22159913bea0..f7798bd92222 100644
> --- a/drivers/mfd/simple-mfd-i2c.c
> +++ b/drivers/mfd/simple-mfd-i2c.c
> @@ -99,6 +99,8 @@ static const struct of_device_id simple_mfd_i2c_of_match[] = {
>  	{ .compatible = "maxim,max5970", .data = &maxim_max5970},
>  	{ .compatible = "maxim,max5978", .data = &maxim_max5970},
>  	{ .compatible = "maxim,max77705-battery", .data = &maxim_mon_max77705},
> +	{ .compatible = "fsl,lx2160aqds-fpga" },
> +	{ .compatible = "fsl,ls1028aqds-fpga" },
>  	{}
>  };

Hi Michael,

I somehow missed to cc you on this. Are you ok with this patch?

Ioana