From: Yu Kuai <yukuai3@huawei.com>
It's set to 'false' for all callers, hence it's useless and can be
removed.
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
drivers/md/dm-raid.c | 2 +-
drivers/md/md-bitmap.c | 5 ++---
drivers/md/md-bitmap.h | 3 +--
drivers/md/md-cluster.c | 2 +-
drivers/md/raid1.c | 2 +-
drivers/md/raid10.c | 8 ++++----
drivers/md/raid5.c | 2 +-
7 files changed, 11 insertions(+), 13 deletions(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index d296770478b2..9757c32ea1f5 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -4068,7 +4068,7 @@ static int raid_preresume(struct dm_target *ti)
int chunksize = to_bytes(rs->requested_bitmap_chunk_sectors) ?: mddev->bitmap_info.chunksize;
r = mddev->bitmap_ops->resize(mddev, mddev->dev_sectors,
- chunksize, false);
+ chunksize);
if (r)
DMERR("Failed to resize bitmap");
}
diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c
index bd694910b01b..fc7282304b00 100644
--- a/drivers/md/md-bitmap.c
+++ b/drivers/md/md-bitmap.c
@@ -2594,15 +2594,14 @@ static int __bitmap_resize(struct bitmap *bitmap, sector_t blocks,
return ret;
}
-static int bitmap_resize(struct mddev *mddev, sector_t blocks, int chunksize,
- bool init)
+static int bitmap_resize(struct mddev *mddev, sector_t blocks, int chunksize)
{
struct bitmap *bitmap = mddev->bitmap;
if (!bitmap)
return 0;
- return __bitmap_resize(bitmap, blocks, chunksize, init);
+ return __bitmap_resize(bitmap, blocks, chunksize, false);
}
static ssize_t
diff --git a/drivers/md/md-bitmap.h b/drivers/md/md-bitmap.h
index 59e9dd45cfde..28c1f1c1cc83 100644
--- a/drivers/md/md-bitmap.h
+++ b/drivers/md/md-bitmap.h
@@ -64,8 +64,7 @@ struct md_bitmap_stats {
struct bitmap_operations {
bool (*enabled)(struct mddev *mddev);
int (*create)(struct mddev *mddev);
- int (*resize)(struct mddev *mddev, sector_t blocks, int chunksize,
- bool init);
+ int (*resize)(struct mddev *mddev, sector_t blocks, int chunksize);
int (*load)(struct mddev *mddev);
void (*destroy)(struct mddev *mddev);
diff --git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c
index 94221d964d4f..db6bbc8eebbc 100644
--- a/drivers/md/md-cluster.c
+++ b/drivers/md/md-cluster.c
@@ -630,7 +630,7 @@ static int process_recvd_msg(struct mddev *mddev, struct cluster_msg *msg)
if (le64_to_cpu(msg->high) != mddev->pers->size(mddev, 0, 0))
ret = mddev->bitmap_ops->resize(mddev,
le64_to_cpu(msg->high),
- 0, false);
+ 0);
break;
default:
ret = -1;
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 3a31e230727c..39ebe0fadacd 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -3329,7 +3329,7 @@ static int raid1_resize(struct mddev *mddev, sector_t sectors)
mddev->array_sectors > newsize)
return -EINVAL;
- ret = mddev->bitmap_ops->resize(mddev, newsize, 0, false);
+ ret = mddev->bitmap_ops->resize(mddev, newsize, 0);
if (ret)
return ret;
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index b74780af4c22..d2ef96be0150 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -4233,7 +4233,7 @@ static int raid10_resize(struct mddev *mddev, sector_t sectors)
mddev->array_sectors > size)
return -EINVAL;
- ret = mddev->bitmap_ops->resize(mddev, size, 0, false);
+ ret = mddev->bitmap_ops->resize(mddev, size, 0);
if (ret)
return ret;
@@ -4502,7 +4502,7 @@ static int raid10_start_reshape(struct mddev *mddev)
newsize = raid10_size(mddev, 0, conf->geo.raid_disks);
if (!mddev_is_clustered(mddev)) {
- ret = mddev->bitmap_ops->resize(mddev, newsize, 0, false);
+ ret = mddev->bitmap_ops->resize(mddev, newsize, 0);
if (ret)
goto abort;
else
@@ -4524,13 +4524,13 @@ static int raid10_start_reshape(struct mddev *mddev)
MD_FEATURE_RESHAPE_ACTIVE)) || (oldsize == newsize))
goto out;
- ret = mddev->bitmap_ops->resize(mddev, newsize, 0, false);
+ ret = mddev->bitmap_ops->resize(mddev, newsize, 0);
if (ret)
goto abort;
ret = mddev->cluster_ops->resize_bitmaps(mddev, newsize, oldsize);
if (ret) {
- mddev->bitmap_ops->resize(mddev, oldsize, 0, false);
+ mddev->bitmap_ops->resize(mddev, oldsize, 0);
goto abort;
}
}
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 7ec61ee7b218..999752ec636e 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -8322,7 +8322,7 @@ static int raid5_resize(struct mddev *mddev, sector_t sectors)
mddev->array_sectors > newsize)
return -EINVAL;
- ret = mddev->bitmap_ops->resize(mddev, sectors, 0, false);
+ ret = mddev->bitmap_ops->resize(mddev, sectors, 0);
if (ret)
return ret;
--
2.39.2On Mon, Jul 7, 2025 at 9:36 AM Yu Kuai <yukuai1@huaweicloud.com> wrote:
>
> From: Yu Kuai <yukuai3@huawei.com>
>
> It's set to 'false' for all callers, hence it's useless and can be
> removed.
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
> drivers/md/dm-raid.c | 2 +-
> drivers/md/md-bitmap.c | 5 ++---
> drivers/md/md-bitmap.h | 3 +--
> drivers/md/md-cluster.c | 2 +-
> drivers/md/raid1.c | 2 +-
> drivers/md/raid10.c | 8 ++++----
> drivers/md/raid5.c | 2 +-
> 7 files changed, 11 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
> index d296770478b2..9757c32ea1f5 100644
> --- a/drivers/md/dm-raid.c
> +++ b/drivers/md/dm-raid.c
> @@ -4068,7 +4068,7 @@ static int raid_preresume(struct dm_target *ti)
> int chunksize = to_bytes(rs->requested_bitmap_chunk_sectors) ?: mddev->bitmap_info.chunksize;
>
> r = mddev->bitmap_ops->resize(mddev, mddev->dev_sectors,
> - chunksize, false);
> + chunksize);
> if (r)
> DMERR("Failed to resize bitmap");
> }
> diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c
> index bd694910b01b..fc7282304b00 100644
> --- a/drivers/md/md-bitmap.c
> +++ b/drivers/md/md-bitmap.c
> @@ -2594,15 +2594,14 @@ static int __bitmap_resize(struct bitmap *bitmap, sector_t blocks,
> return ret;
> }
>
> -static int bitmap_resize(struct mddev *mddev, sector_t blocks, int chunksize,
> - bool init)
> +static int bitmap_resize(struct mddev *mddev, sector_t blocks, int chunksize)
> {
> struct bitmap *bitmap = mddev->bitmap;
>
> if (!bitmap)
> return 0;
>
> - return __bitmap_resize(bitmap, blocks, chunksize, init);
> + return __bitmap_resize(bitmap, blocks, chunksize, false);
> }
>
> static ssize_t
> diff --git a/drivers/md/md-bitmap.h b/drivers/md/md-bitmap.h
> index 59e9dd45cfde..28c1f1c1cc83 100644
> --- a/drivers/md/md-bitmap.h
> +++ b/drivers/md/md-bitmap.h
> @@ -64,8 +64,7 @@ struct md_bitmap_stats {
> struct bitmap_operations {
> bool (*enabled)(struct mddev *mddev);
> int (*create)(struct mddev *mddev);
> - int (*resize)(struct mddev *mddev, sector_t blocks, int chunksize,
> - bool init);
> + int (*resize)(struct mddev *mddev, sector_t blocks, int chunksize);
>
> int (*load)(struct mddev *mddev);
> void (*destroy)(struct mddev *mddev);
> diff --git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c
> index 94221d964d4f..db6bbc8eebbc 100644
> --- a/drivers/md/md-cluster.c
> +++ b/drivers/md/md-cluster.c
> @@ -630,7 +630,7 @@ static int process_recvd_msg(struct mddev *mddev, struct cluster_msg *msg)
> if (le64_to_cpu(msg->high) != mddev->pers->size(mddev, 0, 0))
> ret = mddev->bitmap_ops->resize(mddev,
> le64_to_cpu(msg->high),
> - 0, false);
> + 0);
> break;
> default:
> ret = -1;
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index 3a31e230727c..39ebe0fadacd 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -3329,7 +3329,7 @@ static int raid1_resize(struct mddev *mddev, sector_t sectors)
> mddev->array_sectors > newsize)
> return -EINVAL;
>
> - ret = mddev->bitmap_ops->resize(mddev, newsize, 0, false);
> + ret = mddev->bitmap_ops->resize(mddev, newsize, 0);
> if (ret)
> return ret;
>
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index b74780af4c22..d2ef96be0150 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -4233,7 +4233,7 @@ static int raid10_resize(struct mddev *mddev, sector_t sectors)
> mddev->array_sectors > size)
> return -EINVAL;
>
> - ret = mddev->bitmap_ops->resize(mddev, size, 0, false);
> + ret = mddev->bitmap_ops->resize(mddev, size, 0);
> if (ret)
> return ret;
>
> @@ -4502,7 +4502,7 @@ static int raid10_start_reshape(struct mddev *mddev)
> newsize = raid10_size(mddev, 0, conf->geo.raid_disks);
>
> if (!mddev_is_clustered(mddev)) {
> - ret = mddev->bitmap_ops->resize(mddev, newsize, 0, false);
> + ret = mddev->bitmap_ops->resize(mddev, newsize, 0);
> if (ret)
> goto abort;
> else
> @@ -4524,13 +4524,13 @@ static int raid10_start_reshape(struct mddev *mddev)
> MD_FEATURE_RESHAPE_ACTIVE)) || (oldsize == newsize))
> goto out;
>
> - ret = mddev->bitmap_ops->resize(mddev, newsize, 0, false);
> + ret = mddev->bitmap_ops->resize(mddev, newsize, 0);
> if (ret)
> goto abort;
>
> ret = mddev->cluster_ops->resize_bitmaps(mddev, newsize, oldsize);
> if (ret) {
> - mddev->bitmap_ops->resize(mddev, oldsize, 0, false);
> + mddev->bitmap_ops->resize(mddev, oldsize, 0);
> goto abort;
> }
> }
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index 7ec61ee7b218..999752ec636e 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -8322,7 +8322,7 @@ static int raid5_resize(struct mddev *mddev, sector_t sectors)
> mddev->array_sectors > newsize)
> return -EINVAL;
>
> - ret = mddev->bitmap_ops->resize(mddev, sectors, 0, false);
> + ret = mddev->bitmap_ops->resize(mddev, sectors, 0);
> if (ret)
> return ret;
>
> --
> 2.39.2
>
>
Looks good to me.
Reviewed-by: Xiao Ni <xni@redhat.com>
© 2016 - 2026 Red Hat, Inc.