Add a node for the PMU module of the WCN6855 present on the qcs615 ride
board. Assign its LDO power outputs to the existing WiFi/BT module.
Signed-off-by: Yu Zhang(Yuriy) <yu.zhang@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/qcs615-ride.dts | 135 +++++++++++++++++++++++++++++++
1 file changed, 135 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
index 011f8ae077c256f079ce1b07720374a9bf721488..2df8e7e3c1d3b6d6353a6753b8387c7411edd927 100644
--- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
@@ -18,6 +18,7 @@ aliases {
mmc0 = &sdhc_1;
mmc1 = &sdhc_2;
serial0 = &uart0;
+ serial1 = &uart7;
};
chosen {
@@ -47,6 +48,85 @@ regulator-usb2-vbus {
enable-active-high;
regulator-always-on;
};
+
+ vreg_conn_1p8: vreg_conn_1p8 {
+ compatible = "regulator-fixed";
+ regulator-name = "vreg_conn_1p8";
+ startup-delay-us = <4000>;
+ enable-active-high;
+ gpio = <&pm8150_gpios 1 GPIO_ACTIVE_HIGH>;
+ };
+
+ vreg_conn_pa: vreg_conn_pa {
+ compatible = "regulator-fixed";
+ regulator-name = "vreg_conn_pa";
+ startup-delay-us = <4000>;
+ enable-active-high;
+ gpio = <&pm8150_gpios 6 GPIO_ACTIVE_HIGH>;
+ };
+
+ wcn6855-pmu {
+ compatible = "qcom,wcn6855-pmu";
+
+ pinctrl-0 = <&bt_en_state>, <&wlan_en_state>;
+ pinctrl-names = "default";
+
+ bt-enable-gpios = <&tlmm 85 GPIO_ACTIVE_HIGH>;
+ wlan-enable-gpios = <&tlmm 98 GPIO_ACTIVE_HIGH>;
+
+ vddio-supply = <&vreg_conn_pa>;
+ vddaon-supply = <&vreg_s5a>;
+ vddpmu-supply = <&vreg_conn_1p8>;
+ vddpmumx-supply = <&vreg_conn_1p8>;
+ vddpmucx-supply = <&vreg_conn_pa>;
+ vddrfa0p95-supply = <&vreg_s5a>;
+ vddrfa1p3-supply = <&vreg_s6a>;
+ vddrfa1p9-supply = <&vreg_l15a>;
+ vddpcie1p3-supply = <&vreg_s6a>;
+ vddpcie1p9-supply = <&vreg_l15a>;
+
+ regulators {
+ vreg_pmu_rfa_cmn: ldo0 {
+ regulator-name = "vreg_pmu_rfa_cmn";
+ };
+
+ vreg_pmu_aon_0p59: ldo1 {
+ regulator-name = "vreg_pmu_aon_0p59";
+ };
+
+ vreg_pmu_wlcx_0p8: ldo2 {
+ regulator-name = "vreg_pmu_wlcx_0p8";
+ };
+
+ vreg_pmu_wlmx_0p85: ldo3 {
+ regulator-name = "vreg_pmu_wlmx_0p85";
+ };
+
+ vreg_pmu_btcmx_0p85: ldo4 {
+ regulator-name = "vreg_pmu_btcmx_0p85";
+ };
+
+ vreg_pmu_rfa_0p8: ldo5 {
+ regulator-name = "vreg_pmu_rfa_0p8";
+ };
+
+ vreg_pmu_rfa_1p2: ldo6 {
+ regulator-name = "vreg_pmu_rfa_1p2";
+ };
+
+ vreg_pmu_rfa_1p7: ldo7 {
+ regulator-name = "vreg_pmu_rfa_1p7";
+ };
+
+ vreg_pmu_pcie_0p9: ldo8 {
+ regulator-name = "vreg_pmu_pcie_0p9";
+ };
+
+ vreg_pmu_pcie_1p8: ldo9 {
+ regulator-name = "vreg_pmu_pcie_1p8";
+ };
+ };
+ };
};
&apps_rsc {
@@ -234,6 +314,25 @@ &pcie_phy {
status = "okay";
};
+&pcie_port0 {
+ wifi@0 {
+ compatible = "pci17cb,1103";
+ reg = <0x10000 0x0 0x0 0x0 0x0>;
+
+ qcom,calibration-variant = "QC_QCS615_Ride";
+
+ vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
+ vddaon-supply = <&vreg_pmu_aon_0p59>;
+ vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
+ vddwlmx-supply = <&vreg_pmu_wlmx_0p85>;
+ vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
+ vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
+ vddrfa1p8-supply = <&vreg_pmu_rfa_1p7>;
+ vddpcie0p9-supply = <&vreg_pmu_pcie_0p9>;
+ vddpcie1p8-supply = <&vreg_pmu_pcie_1p8>;
+ };
+};
+
&pm8150_gpios {
usb2_en: usb2-en-state {
pins = "gpio10";
@@ -257,6 +356,10 @@ &qupv3_id_0 {
status = "okay";
};
+&qupv3_id_1 {
+ status = "okay";
+};
+
&remoteproc_adsp {
firmware-name = "qcom/qcs615/adsp.mbn";
@@ -274,6 +377,13 @@ &rpmhcc {
};
&tlmm {
+ bt_en_state: bt-en-state {
+ pins = "gpio85";
+ function = "gpio";
+ bias-pull-down;
+ output-low;
+ };
+
pcie_default_state: pcie-default-state {
clkreq-pins {
pins = "gpio90";
@@ -296,6 +406,13 @@ wake-pins {
bias-pull-up;
};
};
+
+ wlan_en_state: wlan-en-state {
+ pins = "gpio98";
+ function = "gpio";
+ bias-pull-down;
+ output-low;
+ };
};
&sdhc_1 {
@@ -336,6 +453,24 @@ &uart0 {
status = "okay";
};
+&uart7 {
+ status = "okay";
+
+ bluetooth {
+ compatible = "qcom,wcn6855-bt";
+ firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
+
+ vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
+ vddaon-supply = <&vreg_pmu_aon_0p59>;
+ vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
+ vddwlmx-supply = <&vreg_pmu_wlmx_0p85>;
+ vddbtcmx-supply = <&vreg_pmu_btcmx_0p85>;
+ vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
+ vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
+ vddrfa1p8-supply = <&vreg_pmu_rfa_1p7>;
+ };
+};
+
&usb_1_hsphy {
vdd-supply = <&vreg_l5a>;
vdda-pll-supply = <&vreg_l12a>;
--
2.34.1On 07/07/2025 04:51, Yu Zhang(Yuriy) wrote:
> Add a node for the PMU module of the WCN6855 present on the qcs615 ride
> board. Assign its LDO power outputs to the existing WiFi/BT module.
>
> Signed-off-by: Yu Zhang(Yuriy) <yu.zhang@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 135 +++++++++++++++++++++++++++++++
> 1 file changed, 135 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> index 011f8ae077c256f079ce1b07720374a9bf721488..2df8e7e3c1d3b6d6353a6753b8387c7411edd927 100644
> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> @@ -18,6 +18,7 @@ aliases {
> mmc0 = &sdhc_1;
> mmc1 = &sdhc_2;
> serial0 = &uart0;
> + serial1 = &uart7;
> };
>
> chosen {
> @@ -47,6 +48,85 @@ regulator-usb2-vbus {
> enable-active-high;
> regulator-always-on;
> };
> +
> + vreg_conn_1p8: vreg_conn_1p8 {
Are you going to keep sending the same? Third or fourth time, even
though there were comments? Please take comments seriously and implement
them or at least RESPOND.
NAK
Best regards,
Krzysztof
On 7/23/2025 8:12 PM, Krzysztof Kozlowski wrote:
> On 07/07/2025 04:51, Yu Zhang(Yuriy) wrote:
>> Add a node for the PMU module of the WCN6855 present on the qcs615 ride
>> board. Assign its LDO power outputs to the existing WiFi/BT module.
>>
>> Signed-off-by: Yu Zhang(Yuriy) <yu.zhang@oss.qualcomm.com>
>> ---
>> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 135 +++++++++++++++++++++++++++++++
>> 1 file changed, 135 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> index 011f8ae077c256f079ce1b07720374a9bf721488..2df8e7e3c1d3b6d6353a6753b8387c7411edd927 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> @@ -18,6 +18,7 @@ aliases {
>> mmc0 = &sdhc_1;
>> mmc1 = &sdhc_2;
>> serial0 = &uart0;
>> + serial1 = &uart7;
>> };
>>
>> chosen {
>> @@ -47,6 +48,85 @@ regulator-usb2-vbus {
>> enable-active-high;
>> regulator-always-on;
>> };
>> +
>> + vreg_conn_1p8: vreg_conn_1p8 {
>
>
> Are you going to keep sending the same? Third or fourth time, even
> though there were comments? Please take comments seriously and implement
> them or at least RESPOND.
>
I appreciate your comments and apologize for the repeated submissions.
Due to a possible issue with my Thunderbird client, I did not receive
earlier replies and was unaware of additional feedback.
The v3 and v4 revisions were based solely on Rob Herring’s suggestions
and included some dependency adjustments and rebasing.
I will ensure to properly address and respond to all comments in future
revisions.
Thanks a lot.
> NAK
>
> Best regards,
> Krzysztof
On Mon, Jul 07, 2025 at 10:51:06AM +0800, Yu Zhang(Yuriy) wrote:
> Add a node for the PMU module of the WCN6855 present on the qcs615 ride
> board. Assign its LDO power outputs to the existing WiFi/BT module.
What is "existing WiFI/BT module"? There is no module in the DT. Not to
mention that PMU is a part of the WCN6855.
>
> Signed-off-by: Yu Zhang(Yuriy) <yu.zhang@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 135 +++++++++++++++++++++++++++++++
> 1 file changed, 135 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> index 011f8ae077c256f079ce1b07720374a9bf721488..2df8e7e3c1d3b6d6353a6753b8387c7411edd927 100644
> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> @@ -18,6 +18,7 @@ aliases {
> mmc0 = &sdhc_1;
> mmc1 = &sdhc_2;
> serial0 = &uart0;
> + serial1 = &uart7;
> };
>
> chosen {
> @@ -47,6 +48,85 @@ regulator-usb2-vbus {
> enable-active-high;
> regulator-always-on;
> };
> +
> + vreg_conn_1p8: vreg_conn_1p8 {
No improvement. Please try again.
> + compatible = "regulator-fixed";
> + regulator-name = "vreg_conn_1p8";
> + startup-delay-us = <4000>;
> + enable-active-high;
> + gpio = <&pm8150_gpios 1 GPIO_ACTIVE_HIGH>;
> + };
> +
> + vreg_conn_pa: vreg_conn_pa {
> + compatible = "regulator-fixed";
> + regulator-name = "vreg_conn_pa";
> + startup-delay-us = <4000>;
> + enable-active-high;
> + gpio = <&pm8150_gpios 6 GPIO_ACTIVE_HIGH>;
> + };
> +
--
With best wishes
Dmitry
On 7/19/2025 6:13 PM, Dmitry Baryshkov wrote:
> On Mon, Jul 07, 2025 at 10:51:06AM +0800, Yu Zhang(Yuriy) wrote:
>> Add a node for the PMU module of the WCN6855 present on the qcs615 ride
>> board. Assign its LDO power outputs to the existing WiFi/BT module.
>
>
> What is "existing WiFI/BT module"? There is no module in the DT. Not to
> mention that PMU is a part of the WCN6855.
>
>>
>> Signed-off-by: Yu Zhang(Yuriy) <yu.zhang@oss.qualcomm.com>
>> ---
>> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 135 +++++++++++++++++++++++++++++++
>> 1 file changed, 135 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> index 011f8ae077c256f079ce1b07720374a9bf721488..2df8e7e3c1d3b6d6353a6753b8387c7411edd927 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> @@ -18,6 +18,7 @@ aliases {
>> mmc0 = &sdhc_1;
>> mmc1 = &sdhc_2;
>> serial0 = &uart0;
>> + serial1 = &uart7;
>> };
>>
>> chosen {
>> @@ -47,6 +48,85 @@ regulator-usb2-vbus {
>> enable-active-high;
>> regulator-always-on;
>> };
>> +
>> + vreg_conn_1p8: vreg_conn_1p8 {
>
> No improvement. Please try again.
>
you mean should be "vreg_conn_1p8: vreg-conn-1p8",right? I'll update it,
thanks.>> + compatible = "regulator-fixed";
>> + regulator-name = "vreg_conn_1p8";
>> + startup-delay-us = <4000>;
>> + enable-active-high;
>> + gpio = <&pm8150_gpios 1 GPIO_ACTIVE_HIGH>;
>> + };
>> +
>> + vreg_conn_pa: vreg_conn_pa {
>> + compatible = "regulator-fixed";
>> + regulator-name = "vreg_conn_pa";
>> + startup-delay-us = <4000>;
>> + enable-active-high;
>> + gpio = <&pm8150_gpios 6 GPIO_ACTIVE_HIGH>;
>> + };
>> +
>
On 22/07/2025 18:58, Yu Zhang(Yuriy) wrote:
>
>
> On 7/19/2025 6:13 PM, Dmitry Baryshkov wrote:
>> On Mon, Jul 07, 2025 at 10:51:06AM +0800, Yu Zhang(Yuriy) wrote:
>>> Add a node for the PMU module of the WCN6855 present on the qcs615 ride
>>> board. Assign its LDO power outputs to the existing WiFi/BT module.
>>
>>
>> What is "existing WiFI/BT module"? There is no module in the DT. Not to
>> mention that PMU is a part of the WCN6855.
>>
>>>
>>> Signed-off-by: Yu Zhang(Yuriy) <yu.zhang@oss.qualcomm.com>
>>> ---
>>> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 135 ++++++++++++++++++++
>>> +++++++++++
>>> 1 file changed, 135 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/
>>> boot/dts/qcom/qcs615-ride.dts
>>> index
>>> 011f8ae077c256f079ce1b07720374a9bf721488..2df8e7e3c1d3b6d6353a6753b8387c7411edd927 100644
>>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>> @@ -18,6 +18,7 @@ aliases {
>>> mmc0 = &sdhc_1;
>>> mmc1 = &sdhc_2;
>>> serial0 = &uart0;
>>> + serial1 = &uart7;
>>> };
>>> chosen {
>>> @@ -47,6 +48,85 @@ regulator-usb2-vbus {
>>> enable-active-high;
>>> regulator-always-on;
>>> };
>>> +
>>> + vreg_conn_1p8: vreg_conn_1p8 {
>>
>> No improvement. Please try again.
>>
> you mean should be "vreg_conn_1p8: vreg-conn-1p8",right? I'll update it,
What is the node name for the previous regulator device? Anything
preventing you from following the pattern?
> thanks.>> + compatible = "regulator-fixed";
>>> + regulator-name = "vreg_conn_1p8";
>>> + startup-delay-us = <4000>;
>>> + enable-active-high;
>>> + gpio = <&pm8150_gpios 1 GPIO_ACTIVE_HIGH>;
>>> + };
>>> +
>>> + vreg_conn_pa: vreg_conn_pa {
>>> + compatible = "regulator-fixed";
>>> + regulator-name = "vreg_conn_pa";
>>> + startup-delay-us = <4000>;
>>> + enable-active-high;
>>> + gpio = <&pm8150_gpios 6 GPIO_ACTIVE_HIGH>;
>>> + };
>>> +
>>
>
--
With best wishes
Dmitry
On 7/23/2025 1:36 AM, Dmitry Baryshkov wrote:
> On 22/07/2025 18:58, Yu Zhang(Yuriy) wrote:
>>
>>
>> On 7/19/2025 6:13 PM, Dmitry Baryshkov wrote:
>>> On Mon, Jul 07, 2025 at 10:51:06AM +0800, Yu Zhang(Yuriy) wrote:
>>>> Add a node for the PMU module of the WCN6855 present on the qcs615 ride
>>>> board. Assign its LDO power outputs to the existing WiFi/BT module.
>>>
>>>
>>> What is "existing WiFI/BT module"? There is no module in the DT. Not to
>>> mention that PMU is a part of the WCN6855.
>>>
>>>>
>>>> Signed-off-by: Yu Zhang(Yuriy) <yu.zhang@oss.qualcomm.com>
>>>> ---
>>>> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 135 +++++++++++++++++++
>>>> + +++++++++++
>>>> 1 file changed, 135 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/
>>>> boot/dts/qcom/qcs615-ride.dts
>>>> index
>>>> 011f8ae077c256f079ce1b07720374a9bf721488..2df8e7e3c1d3b6d6353a6753b8387c7411edd927 100644
>>>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>> @@ -18,6 +18,7 @@ aliases {
>>>> mmc0 = &sdhc_1;
>>>> mmc1 = &sdhc_2;
>>>> serial0 = &uart0;
>>>> + serial1 = &uart7;
>>>> };
>>>> chosen {
>>>> @@ -47,6 +48,85 @@ regulator-usb2-vbus {
>>>> enable-active-high;
>>>> regulator-always-on;
>>>> };
>>>> +
>>>> + vreg_conn_1p8: vreg_conn_1p8 {
>>>
>>> No improvement. Please try again.
>>>
>> you mean should be "vreg_conn_1p8: vreg-conn-1p8",right? I'll update it,
>
> What is the node name for the previous regulator device? Anything
> preventing you from following the pattern?
>
Do you mean the prefix 'regulator'?
I just want to keep 'vreg_conn_1p8' and 'vreg_conn_pa' the same as in
sa8775p-ride.dtsi, because they're using the same module.
>> thanks.>> + compatible = "regulator-fixed";
>>>> + regulator-name = "vreg_conn_1p8";
>>>> + startup-delay-us = <4000>;
>>>> + enable-active-high;
>>>> + gpio = <&pm8150_gpios 1 GPIO_ACTIVE_HIGH>;
>>>> + };
>>>> +
>>>> + vreg_conn_pa: vreg_conn_pa {
>>>> + compatible = "regulator-fixed";
>>>> + regulator-name = "vreg_conn_pa";
>>>> + startup-delay-us = <4000>;
>>>> + enable-active-high;
>>>> + gpio = <&pm8150_gpios 6 GPIO_ACTIVE_HIGH>;
>>>> + };
>>>> +
>>>
>>
>
>
On Wed, Jul 23, 2025 at 10:02:36AM +0800, Yu Zhang(Yuriy) wrote:
>
>
> On 7/23/2025 1:36 AM, Dmitry Baryshkov wrote:
> > On 22/07/2025 18:58, Yu Zhang(Yuriy) wrote:
> > >
> > >
> > > On 7/19/2025 6:13 PM, Dmitry Baryshkov wrote:
> > > > On Mon, Jul 07, 2025 at 10:51:06AM +0800, Yu Zhang(Yuriy) wrote:
> > > > > Add a node for the PMU module of the WCN6855 present on the qcs615 ride
> > > > > board. Assign its LDO power outputs to the existing WiFi/BT module.
> > > >
> > > >
> > > > What is "existing WiFI/BT module"? There is no module in the DT. Not to
> > > > mention that PMU is a part of the WCN6855.
> > > >
> > > > >
> > > > > Signed-off-by: Yu Zhang(Yuriy) <yu.zhang@oss.qualcomm.com>
> > > > > ---
> > > > > arch/arm64/boot/dts/qcom/qcs615-ride.dts | 135
> > > > > +++++++++++++++++++ + +++++++++++
> > > > > 1 file changed, 135 insertions(+)
> > > > >
> > > > > diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> > > > > b/arch/arm64/ boot/dts/qcom/qcs615-ride.dts
> > > > > index 011f8ae077c256f079ce1b07720374a9bf721488..2df8e7e3c1d3b6d6353a6753b8387c7411edd927
> > > > > 100644
> > > > > --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> > > > > +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> > > > > @@ -18,6 +18,7 @@ aliases {
> > > > > mmc0 = &sdhc_1;
> > > > > mmc1 = &sdhc_2;
> > > > > serial0 = &uart0;
> > > > > + serial1 = &uart7;
> > > > > };
> > > > > chosen {
> > > > > @@ -47,6 +48,85 @@ regulator-usb2-vbus {
> > > > > enable-active-high;
> > > > > regulator-always-on;
> > > > > };
> > > > > +
> > > > > + vreg_conn_1p8: vreg_conn_1p8 {
> > > >
> > > > No improvement. Please try again.
> > > >
> > > you mean should be "vreg_conn_1p8: vreg-conn-1p8",right? I'll update
> > > it,
> >
> > What is the node name for the previous regulator device? Anything
> > preventing you from following the pattern?
> >
> Do you mean the prefix 'regulator'?
> I just want to keep 'vreg_conn_1p8' and 'vreg_conn_pa' the same as in
> sa8775p-ride.dtsi, because they're using the same module.
That's a different device. Please use the style of the file that you are
patching.
>
> > > thanks.>> + compatible = "regulator-fixed";
> > > > > + regulator-name = "vreg_conn_1p8";
> > > > > + startup-delay-us = <4000>;
> > > > > + enable-active-high;
> > > > > + gpio = <&pm8150_gpios 1 GPIO_ACTIVE_HIGH>;
> > > > > + };
> > > > > +
> > > > > + vreg_conn_pa: vreg_conn_pa {
> > > > > + compatible = "regulator-fixed";
> > > > > + regulator-name = "vreg_conn_pa";
> > > > > + startup-delay-us = <4000>;
> > > > > + enable-active-high;
> > > > > + gpio = <&pm8150_gpios 6 GPIO_ACTIVE_HIGH>;
> > > > > + };
> > > > > +
> > > >
> > >
> >
> >
>
--
With best wishes
Dmitry
On 7/23/2025 7:31 PM, Dmitry Baryshkov wrote:
> On Wed, Jul 23, 2025 at 10:02:36AM +0800, Yu Zhang(Yuriy) wrote:
>>
>>
>> On 7/23/2025 1:36 AM, Dmitry Baryshkov wrote:
>>> On 22/07/2025 18:58, Yu Zhang(Yuriy) wrote:
>>>>
>>>>
>>>> On 7/19/2025 6:13 PM, Dmitry Baryshkov wrote:
>>>>> On Mon, Jul 07, 2025 at 10:51:06AM +0800, Yu Zhang(Yuriy) wrote:
>>>>>> Add a node for the PMU module of the WCN6855 present on the qcs615 ride
>>>>>> board. Assign its LDO power outputs to the existing WiFi/BT module.
>>>>>
>>>>>
>>>>> What is "existing WiFI/BT module"? There is no module in the DT. Not to
>>>>> mention that PMU is a part of the WCN6855.
>>>>>
>>>>>>
>>>>>> Signed-off-by: Yu Zhang(Yuriy) <yu.zhang@oss.qualcomm.com>
>>>>>> ---
>>>>>> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 135
>>>>>> +++++++++++++++++++ + +++++++++++
>>>>>> 1 file changed, 135 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>>>> b/arch/arm64/ boot/dts/qcom/qcs615-ride.dts
>>>>>> index 011f8ae077c256f079ce1b07720374a9bf721488..2df8e7e3c1d3b6d6353a6753b8387c7411edd927
>>>>>> 100644
>>>>>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>>>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>>>> @@ -18,6 +18,7 @@ aliases {
>>>>>> mmc0 = &sdhc_1;
>>>>>> mmc1 = &sdhc_2;
>>>>>> serial0 = &uart0;
>>>>>> + serial1 = &uart7;
>>>>>> };
>>>>>> chosen {
>>>>>> @@ -47,6 +48,85 @@ regulator-usb2-vbus {
>>>>>> enable-active-high;
>>>>>> regulator-always-on;
>>>>>> };
>>>>>> +
>>>>>> + vreg_conn_1p8: vreg_conn_1p8 {
>>>>>
>>>>> No improvement. Please try again.
>>>>>
>>>> you mean should be "vreg_conn_1p8: vreg-conn-1p8",right? I'll update
>>>> it,
>>>
>>> What is the node name for the previous regulator device? Anything
>>> preventing you from following the pattern?
>>>
>> Do you mean the prefix 'regulator'?
>> I just want to keep 'vreg_conn_1p8' and 'vreg_conn_pa' the same as in
>> sa8775p-ride.dtsi, because they're using the same module.
>
> That's a different device. Please use the style of the file that you are
> patching.
>
Got it, thanks.>>
>>>> thanks.>> + compatible = "regulator-fixed";
>>>>>> + regulator-name = "vreg_conn_1p8";
>>>>>> + startup-delay-us = <4000>;
>>>>>> + enable-active-high;
>>>>>> + gpio = <&pm8150_gpios 1 GPIO_ACTIVE_HIGH>;
>>>>>> + };
>>>>>> +
>>>>>> + vreg_conn_pa: vreg_conn_pa {
>>>>>> + compatible = "regulator-fixed";
>>>>>> + regulator-name = "vreg_conn_pa";
>>>>>> + startup-delay-us = <4000>;
>>>>>> + enable-active-high;
>>>>>> + gpio = <&pm8150_gpios 6 GPIO_ACTIVE_HIGH>;
>>>>>> + };
>>>>>> +
>>>>>
>>>>
>>>
>>>
>>
>
© 2016 - 2025 Red Hat, Inc.