[PATCH 6/6] MIPS: dts: ralink: mt7628a: add wifi binding

Rosen Penev posted 6 patches 3 months ago
There is a newer version of this series
[PATCH 6/6] MIPS: dts: ralink: mt7628a: add wifi binding
Posted by Rosen Penev 3 months ago
MT7620A devices all contain a wifi device as part of the SOC. Add it
here to get it working.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 arch/mips/boot/dts/ralink/mt7620a.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/mips/boot/dts/ralink/mt7620a.dtsi b/arch/mips/boot/dts/ralink/mt7620a.dtsi
index d66045948a83..460164bdd430 100644
--- a/arch/mips/boot/dts/ralink/mt7620a.dtsi
+++ b/arch/mips/boot/dts/ralink/mt7620a.dtsi
@@ -62,4 +62,14 @@ uartlite@c00 {
 			reg-shift = <2>;
 		};
 	};
+
+	wmac: wifi@10180000 {
+		compatible = "ralink,rt2880-wifi";
+		reg = <0x10180000 0x40000>;
+
+		clocks = <&sysc 16>;
+
+		interrupt-parent = <&cpuintc>;
+		interrupts = <6>;
+	};
 };
-- 
2.50.0
Re: [PATCH 6/6] MIPS: dts: ralink: mt7628a: add wifi binding
Posted by Daniel Golle 3 months ago
On Sun, Jul 06, 2025 at 02:41:11PM -0700, Rosen Penev wrote:
> MT7620A devices all contain a wifi device as part of the SOC. Add it
> here to get it working.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>  arch/mips/boot/dts/ralink/mt7620a.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)

The commit title

MIPS: dts: ralink: mt7628a: add wifi binding 

seems wrong as the commit (correctly) touches mt7620a.dtsi and not
mt7628a.dtsi (which would be wrong as the WiFi part of MT7628A is
already supported by the mt76 driver and part of the device tree).
Also the word 'binding' seems wrong in this context, you are adding
a node to the device tree, not to the device tree bindings.

I'd hence suggest to change the commit title to

MIPS: dts: ralink: mt7620a: add wifi
Re: [PATCH 6/6] MIPS: dts: ralink: mt7628a: add wifi binding
Posted by Rosen Penev 3 months ago
On Mon, Jul 7, 2025 at 6:19 PM Daniel Golle <daniel@makrotopia.org> wrote:
>
> On Sun, Jul 06, 2025 at 02:41:11PM -0700, Rosen Penev wrote:
> > MT7620A devices all contain a wifi device as part of the SOC. Add it
> > here to get it working.
> >
> > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> > ---
> >  arch/mips/boot/dts/ralink/mt7620a.dtsi | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
>
> The commit title
>
> MIPS: dts: ralink: mt7628a: add wifi binding
That is embarrassing. I'm blaming my new Linux setup.
>
> seems wrong as the commit (correctly) touches mt7620a.dtsi and not
> mt7628a.dtsi (which would be wrong as the WiFi part of MT7628A is
> already supported by the mt76 driver and part of the device tree).
> Also the word 'binding' seems wrong in this context, you are adding
> a node to the device tree, not to the device tree bindings.
>
> I'd hence suggest to change the commit title to
>
> MIPS: dts: ralink: mt7620a: add wifi
Will do