Il 06/07/25 15:21, Frank Wunderlich ha scritto:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> In preparation for MT7988 and RSS/LRO allow the interrupt-names
> property.
> In this way driver can request the interrupts by name which is much
> more readable in the driver code and SoC's dtsi than relying on a
> specific order.
>
> Frame-engine-IRQs (fe0..3):
> MT7621, MT7628: 1 IRQ
> MT7622, MT7623: 3 IRQs (only two used by the driver for now)
> MT7981, MT7986: 4 IRQs (only two used by the driver for now)
>
> RSS/LRO IRQs (pdma0..3) only on Filogic (MT798x) with count of 4.
>
> Set boundaries for all compatibles same as irq count.
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
I'm fine with that, as long as you don't break the driver's ability to keep
getting the interrupts without any interrupt-names, at least for the currently
supported interrupts.
This commit ain't touching any driver, anyway, and the change is valid IMO, so:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> v8:
> - fixed typo in mt7621 section "interrupt-namess"
> - separated interrupt count from interrupt-names
> - rephrased description a bit to explain the "why"
> v7: fixed wrong rebase
> v6: new patch splitted from the mt7988 changes
> ---
> .../devicetree/bindings/net/mediatek,net.yaml | 36 +++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
> index 766224e4ed86..da7bda20786a 100644
> --- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
> +++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml
> @@ -42,6 +42,18 @@ properties:
> minItems: 1
> maxItems: 8
>
> + interrupt-names:
> + minItems: 1
> + items:
> + - const: fe0
> + - const: fe1
> + - const: fe2
> + - const: fe3
> + - const: pdma0
> + - const: pdma1
> + - const: pdma2
> + - const: pdma3
> +
> power-domains:
> maxItems: 1
>
> @@ -135,6 +147,10 @@ allOf:
> minItems: 3
> maxItems: 3
>
> + interrupt-names:
> + minItems: 3
> + maxItems: 3
> +
> clocks:
> minItems: 4
> maxItems: 4
> @@ -166,6 +182,9 @@ allOf:
> interrupts:
> maxItems: 1
>
> + interrupt-names:
> + maxItems: 1
> +
> clocks:
> minItems: 2
> maxItems: 2
> @@ -192,6 +211,10 @@ allOf:
> minItems: 3
> maxItems: 3
>
> + interrupt-names:
> + minItems: 3
> + maxItems: 3
> +
> clocks:
> minItems: 11
> maxItems: 11
> @@ -232,6 +255,10 @@ allOf:
> minItems: 3
> maxItems: 3
>
> + interrupt-names:
> + minItems: 3
> + maxItems: 3
> +
> clocks:
> minItems: 17
> maxItems: 17
> @@ -274,6 +301,9 @@ allOf:
> interrupts:
> minItems: 4
>
> + interrupt-names:
> + minItems: 4
> +
> clocks:
> minItems: 15
> maxItems: 15
> @@ -312,6 +342,9 @@ allOf:
> interrupts:
> minItems: 4
>
> + interrupt-names:
> + minItems: 4
> +
> clocks:
> minItems: 15
> maxItems: 15
> @@ -350,6 +383,9 @@ allOf:
> interrupts:
> minItems: 4
>
> + interrupt-names:
> + minItems: 4
> +
> clocks:
> minItems: 24
> maxItems: 24