[PATCH v2] ACPI: FAN: Update fps count debug print

Sumeet Pawnikar posted 1 patch 3 months ago
drivers/acpi/fan_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v2] ACPI: FAN: Update fps count debug print
Posted by Sumeet Pawnikar 3 months ago
Update invalid control value returned debug print with
appropriate message as no matching fps control value
for checking fan fps count condition.

Signed-off-by: Sumeet Pawnikar <sumeet4linux@gmail.com>
---
v1->v2: Addressed review comment received from Rafael Wysocki
        to update the debug message appropriately.
---
 drivers/acpi/fan_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/fan_core.c b/drivers/acpi/fan_core.c
index 8ad12ad3aaaf..095502086b41 100644
--- a/drivers/acpi/fan_core.c
+++ b/drivers/acpi/fan_core.c
@@ -102,7 +102,7 @@ static int fan_get_state_acpi4(struct acpi_device *device, unsigned long *state)
 			break;
 	}
 	if (i == fan->fps_count) {
-		dev_dbg(&device->dev, "Invalid control value returned\n");
+		dev_dbg(&device->dev, "No matching fps control value\n");
 		return -EINVAL;
 	}
 
-- 
2.43.0
Re: [PATCH v2] ACPI: FAN: Update fps count debug print
Posted by Rafael J. Wysocki 3 months ago
On Sat, Jul 5, 2025 at 1:00 PM Sumeet Pawnikar <sumeet4linux@gmail.com> wrote:
>
> Update invalid control value returned debug print with
> appropriate message as no matching fps control value
> for checking fan fps count condition.
>
> Signed-off-by: Sumeet Pawnikar <sumeet4linux@gmail.com>
> ---
> v1->v2: Addressed review comment received from Rafael Wysocki
>         to update the debug message appropriately.
> ---
>  drivers/acpi/fan_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/fan_core.c b/drivers/acpi/fan_core.c
> index 8ad12ad3aaaf..095502086b41 100644
> --- a/drivers/acpi/fan_core.c
> +++ b/drivers/acpi/fan_core.c
> @@ -102,7 +102,7 @@ static int fan_get_state_acpi4(struct acpi_device *device, unsigned long *state)
>                         break;
>         }
>         if (i == fan->fps_count) {
> -               dev_dbg(&device->dev, "Invalid control value returned\n");
> +               dev_dbg(&device->dev, "No matching fps control value\n");
>                 return -EINVAL;
>         }
>
> --

Applied as 6.17 material with edited subject, thanks!